* [PATCH v2 1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property
@ 2024-10-07 21:24 Frank Li
2024-10-08 13:34 ` Krzysztof Kozlowski
2024-10-31 19:02 ` Frank Li
0 siblings, 2 replies; 6+ messages in thread
From: Frank Li @ 2024-10-07 21:24 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, open list:WATCHDOG DEVICE DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Cc: imx
From: Animesh Agarwal <animeshagarwal28@gmail.com>
Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only
allow big-endian property for ls1012a and ls1043a.
Fix dtbs_check errors.
arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@2ad0000:
Unevaluated properties are not allowed ('big-endian' was unexpected)
Cc: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v1 to v2:
only allow big endian for layerscape platform.
previous post at:
https://lore.kernel.org/imx/20240806103819.10890-1-animeshagarwal28@gmail.com/
check spec, and dump watch dog reset value
at ls1043a platform.
0x02A80000: 00 30 00 00 00 10 00 04 00 01 00 00 00 00 00 0
It is big-endian. imx2_wdt.c use regmap which call regmap_get_val_endian()
to handle endian.
So this change is corret.
big-endian for wdt is necessary
---
.../devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
index 36b836d0620c9..0da953cb71272 100644
--- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
@@ -48,6 +48,8 @@ properties:
clocks:
maxItems: 1
+ big-endian: true
+
fsl,ext-reset-output:
$ref: /schemas/types.yaml#/definitions/flag
description: |
@@ -93,6 +95,18 @@ allOf:
properties:
fsl,suspend-in-wait: false
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - fsl,ls1012a-wdt
+ - fsl,ls1043a-wdt
+ then:
+ properties:
+ big-endian: false
+
unevaluatedProperties: false
examples:
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property
2024-10-07 21:24 [PATCH v2 1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property Frank Li
@ 2024-10-08 13:34 ` Krzysztof Kozlowski
2024-10-31 19:02 ` Frank Li
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-10-08 13:34 UTC (permalink / raw)
To: Frank Li
Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, open list:WATCHDOG DEVICE DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On Mon, Oct 07, 2024 at 05:24:33PM -0400, Frank Li wrote:
> From: Animesh Agarwal <animeshagarwal28@gmail.com>
>
> Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only
> allow big-endian property for ls1012a and ls1043a.
>
> Fix dtbs_check errors.
> arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@2ad0000:
> Unevaluated properties are not allowed ('big-endian' was unexpected)
>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property
2024-10-07 21:24 [PATCH v2 1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property Frank Li
2024-10-08 13:34 ` Krzysztof Kozlowski
@ 2024-10-31 19:02 ` Frank Li
2024-11-05 8:32 ` Wim Van Sebroeck
1 sibling, 1 reply; 6+ messages in thread
From: Frank Li @ 2024-10-31 19:02 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, open list:WATCHDOG DEVICE DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On Mon, Oct 07, 2024 at 05:24:33PM -0400, Frank Li wrote:
> From: Animesh Agarwal <animeshagarwal28@gmail.com>
>
> Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only
> allow big-endian property for ls1012a and ls1043a.
>
> Fix dtbs_check errors.
> arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@2ad0000:
> Unevaluated properties are not allowed ('big-endian' was unexpected)
>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
Wim Van Sebroeck:
Any update this patch? Kyzy already acked.
Frank
>
> Change from v1 to v2:
> only allow big endian for layerscape platform.
>
> previous post at:
> https://lore.kernel.org/imx/20240806103819.10890-1-animeshagarwal28@gmail.com/
>
> check spec, and dump watch dog reset value
> at ls1043a platform.
>
> 0x02A80000: 00 30 00 00 00 10 00 04 00 01 00 00 00 00 00 0
>
> It is big-endian. imx2_wdt.c use regmap which call regmap_get_val_endian()
> to handle endian.
>
> So this change is corret.
>
> big-endian for wdt is necessary
> ---
> .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> index 36b836d0620c9..0da953cb71272 100644
> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> @@ -48,6 +48,8 @@ properties:
> clocks:
> maxItems: 1
>
> + big-endian: true
> +
> fsl,ext-reset-output:
> $ref: /schemas/types.yaml#/definitions/flag
> description: |
> @@ -93,6 +95,18 @@ allOf:
> properties:
> fsl,suspend-in-wait: false
>
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - fsl,ls1012a-wdt
> + - fsl,ls1043a-wdt
> + then:
> + properties:
> + big-endian: false
> +
> unevaluatedProperties: false
>
> examples:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property
2024-10-31 19:02 ` Frank Li
@ 2024-11-05 8:32 ` Wim Van Sebroeck
2024-11-05 13:02 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Wim Van Sebroeck @ 2024-11-05 8:32 UTC (permalink / raw)
To: Frank Li
Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, open list:WATCHDOG DEVICE DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Hi Frank,
> On Mon, Oct 07, 2024 at 05:24:33PM -0400, Frank Li wrote:
> > From: Animesh Agarwal <animeshagarwal28@gmail.com>
> >
> > Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only
> > allow big-endian property for ls1012a and ls1043a.
> >
> > Fix dtbs_check errors.
> > arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@2ad0000:
> > Unevaluated properties are not allowed ('big-endian' was unexpected)
> >
> > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
>
> Wim Van Sebroeck:
>
> Any update this patch? Kyzy already acked.
>
Acked-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Via which tree will this go upsteam?
Kind regards,
Wim.
>
> Frank
>
>
> >
> > Change from v1 to v2:
> > only allow big endian for layerscape platform.
> >
> > previous post at:
> > https://lore.kernel.org/imx/20240806103819.10890-1-animeshagarwal28@gmail.com/
> >
> > check spec, and dump watch dog reset value
> > at ls1043a platform.
> >
> > 0x02A80000: 00 30 00 00 00 10 00 04 00 01 00 00 00 00 00 0
> >
> > It is big-endian. imx2_wdt.c use regmap which call regmap_get_val_endian()
> > to handle endian.
> >
> > So this change is corret.
> >
> > big-endian for wdt is necessary
> > ---
> > .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > index 36b836d0620c9..0da953cb71272 100644
> > --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > @@ -48,6 +48,8 @@ properties:
> > clocks:
> > maxItems: 1
> >
> > + big-endian: true
> > +
> > fsl,ext-reset-output:
> > $ref: /schemas/types.yaml#/definitions/flag
> > description: |
> > @@ -93,6 +95,18 @@ allOf:
> > properties:
> > fsl,suspend-in-wait: false
> >
> > + - if:
> > + not:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - fsl,ls1012a-wdt
> > + - fsl,ls1043a-wdt
> > + then:
> > + properties:
> > + big-endian: false
> > +
> > unevaluatedProperties: false
> >
> > examples:
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property
2024-11-05 8:32 ` Wim Van Sebroeck
@ 2024-11-05 13:02 ` Rob Herring
2024-11-06 8:01 ` Wim Van Sebroeck
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2024-11-05 13:02 UTC (permalink / raw)
To: Wim Van Sebroeck
Cc: Frank Li, Guenter Roeck, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
open list:WATCHDOG DEVICE DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
On Tue, Nov 5, 2024 at 3:00 AM Wim Van Sebroeck <wim@linux-watchdog.org> wrote:
>
> Hi Frank,
>
> > On Mon, Oct 07, 2024 at 05:24:33PM -0400, Frank Li wrote:
> > > From: Animesh Agarwal <animeshagarwal28@gmail.com>
> > >
> > > Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only
> > > allow big-endian property for ls1012a and ls1043a.
> > >
> > > Fix dtbs_check errors.
> > > arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@2ad0000:
> > > Unevaluated properties are not allowed ('big-endian' was unexpected)
> > >
> > > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> >
> > Wim Van Sebroeck:
> >
> > Any update this patch? Kyzy already acked.
> >
>
> Acked-by: Wim Van Sebroeck <wim@linux-watchdog.org>
>
> Via which tree will this go upsteam?
Your tree.
DT bindings go in via $subsystem tree. I only take DT bindings if they
don't get picked up by the subsystem maintainer.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property
2024-11-05 13:02 ` Rob Herring
@ 2024-11-06 8:01 ` Wim Van Sebroeck
0 siblings, 0 replies; 6+ messages in thread
From: Wim Van Sebroeck @ 2024-11-06 8:01 UTC (permalink / raw)
To: Rob Herring
Cc: Wim Van Sebroeck, Frank Li, Guenter Roeck, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, open list:WATCHDOG DEVICE DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Hi Frank, Rob,
> On Tue, Nov 5, 2024 at 3:00 AM Wim Van Sebroeck <wim@linux-watchdog.org> wrote:
> >
> > Hi Frank,
> >
> > > On Mon, Oct 07, 2024 at 05:24:33PM -0400, Frank Li wrote:
> > > > From: Animesh Agarwal <animeshagarwal28@gmail.com>
> > > >
> > > > Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema. Only
> > > > allow big-endian property for ls1012a and ls1043a.
> > > >
> > > > Fix dtbs_check errors.
> > > > arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: watchdog@2ad0000:
> > > > Unevaluated properties are not allowed ('big-endian' was unexpected)
> > > >
> > > > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > > > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > >
> > > Wim Van Sebroeck:
> > >
> > > Any update this patch? Kyzy already acked.
> > >
> >
> > Acked-by: Wim Van Sebroeck <wim@linux-watchdog.org>
> >
> > Via which tree will this go upsteam?
>
> Your tree.
>
> DT bindings go in via $subsystem tree. I only take DT bindings if they
> don't get picked up by the subsystem maintainer.
>
> Rob
Added.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-11-06 8:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 21:24 [PATCH v2 1/1] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property Frank Li
2024-10-08 13:34 ` Krzysztof Kozlowski
2024-10-31 19:02 ` Frank Li
2024-11-05 8:32 ` Wim Van Sebroeck
2024-11-05 13:02 ` Rob Herring
2024-11-06 8:01 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox