public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Aaron Rainbolt <arainbolt@kfocus.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: YehezkelShB@gmail.com, michael.jamet@intel.com,
	andreas.noever@gmail.com, linux-usb@vger.kernel.org,
	mmikowski@kfocus.org, linux-kernel@vger.kernel.org,
	Gil Fine <gil.fine@linux.intel.com>
Subject: Re: USB-C DisplayPort display failing to stay active with Intel Barlow Ridge USB4 controller, power-management related issue?
Date: Tue, 5 Nov 2024 14:16:36 -0600	[thread overview]
Message-ID: <20241105141627.5e5199b3@kf-ir16> (raw)
In-Reply-To: <20241104060159.GY275077@black.fi.intel.com>

On Mon, 4 Nov 2024 08:01:59 +0200
Mika Westerberg <mika.westerberg@linux.intel.com> wrote:

...snip...

> Okay, thanks again for testing!
> 
> It means disabling adapter 16 in DROM is actually intentional as that
> is not connected to the dGPU and so makes sense.
> 
> > * Boot the system up, nothing connected.
> > * Wait for Barlow Ridge to enter runtime suspend. This takes ~15
> >   seconds so waiting for > 15 seconds should be enough.
> > * Plug in USB-C monitor to the USB-C port of the Barlow Ridge.
> >   Screen shows in log, screen wakes, but then no signal is
> > received, and no image ever appears. Screen then sleeps after its
> > timeout.
> > * Run lspci -k to wake up the monitors. Once this is run, the
> > display shows correctly and is stable. Adding another USB-C display
> > after this also works correctly: It is recognized and lights up in
> > seconds to show the desktop background, and remains stable.
> > 
> > Notice that pre-6.5 kernels work fine with Barlow Ridge, which
> > implies that new code is causing this. It may be new support code
> > for tbt capability (and therefore pretty much required). But
> > regardless, it's still new code. With the current patch, we can run
> > a udev rule that enables hot plugging that likely always work, or
> > (worst case) at least empowers the customer to refresh monitors by
> > clicking a button.  
> 
> We definitely want to fix this properly so there is no need for anyone
> to run 'lspci' or similar hacks but because I'm unable to reproduce
> this with my reference Barlow Ridge setup, I need some help from you.
> 
> You say with v6.5 it works? That's interesting because we only added
> this redrive mode workaround for v6.9 and without that the domain
> surely will not be kept powered but maybe I'm missing something.

6.5 is *broken*. 6.1 works correctly, but that's probably because it
doesn't have Thunderbolt support for Barlow Ridge chips at all. I
suspect this is because the chip is just acting as a USB-C controller,
and that works just fine without the Thunderbolt driver.

> I wonder if your test team could provide log from v6.5 as well
> following the same steps, no need to run 'lspci' just do:
> 
>   1. Boot the system up, nothing connected.
>   2. Wait for ~15 seconds for the domain to enter runtime suspend.
>   3. Plug in USB-C monitor to the USB-C port of Barlow Ridge.
>   4. Verify that it wakes up and, there is picture on the screen.
>   5. Wait for ~15 seconds.
> 
> Expectation: After step 5 the monitor still displays picture.
> 
> If this works as above then I'm really surprised but if that's the
> case then we can maybe think of another approach of dealing with the
> redrive mode.

We'd be happy to run this testing on the 6.1 kernel if it would be
helpful. Will that work, or is 6.1 too old?

  reply	other threads:[~2024-11-05 20:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-10  3:01 USB-C DisplayPort display failing to stay active with Intel Barlow Ridge USB4 controller, power-management related issue? Aaron Rainbolt
2024-10-10  4:49 ` Mika Westerberg
2024-10-11  4:26   ` Aaron Rainbolt
2024-10-11 16:38     ` Mika Westerberg
2024-10-11 18:02       ` Aaron Rainbolt
2024-10-11 23:37       ` Aaron Rainbolt
2024-10-23  6:27         ` Mika Westerberg
2024-10-23  7:39           ` Mika Westerberg
2024-10-23 22:44             ` Aaron Rainbolt
2024-10-24 15:43               ` Mika Westerberg
2024-10-31 14:55                 ` Aaron Rainbolt
2024-11-01  7:21                   ` Mika Westerberg
2024-11-01 23:13                     ` Aaron Rainbolt
2024-11-04  6:01                       ` Mika Westerberg
2024-11-05 20:16                         ` Aaron Rainbolt [this message]
2024-11-06  6:06                           ` Mika Westerberg
2024-11-06 17:01                             ` Aaron Rainbolt
2024-11-07  9:45                               ` Mika Westerberg
2024-11-11  8:22                                 ` Mika Westerberg
2024-11-12 21:44                                   ` Aaron Rainbolt
2024-11-14 11:51                                     ` Mika Westerberg
2024-11-14 16:41                                       ` Aaron Rainbolt
2024-11-15 13:20                                         ` Mika Westerberg
2024-12-12 22:12                                           ` Aaron Rainbolt
2024-12-13 12:03                                             ` Mika Westerberg
2025-01-24 23:05                                           ` Aaron Rainbolt
2025-01-26  5:53                                             ` Mika Westerberg
2025-01-26 16:12                                               ` Gil Fine
2025-01-28  8:29                                                 ` Gil Fine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241105141627.5e5199b3@kf-ir16 \
    --to=arainbolt@kfocus.org \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=gil.fine@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=mmikowski@kfocus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox