public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Clark Williams <williams@redhat.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
	Howard Chu <howardchu95@gmail.com>,
	James Clark <james.clark@linaro.org>, Leo Yan <leo.yan@linux.dev>,
	Thomas Richter <tmricht@linux.ibm.com>,
	Veronika Molnarova <vmolnaro@redhat.com>
Subject: [PATCH v2 perf-tools-next 0/4] 'perf test' fixes/improvements
Date: Tue,  5 Nov 2024 11:26:12 -0300	[thread overview]
Message-ID: <20241105142616.761042-1-acme@kernel.org> (raw)

Hi,

        While evaluating what is needed for having shell tests that test
python functionality conditionally, i.e. so that we don't try to test
the python binding if NO_LIBPYTHON=1 is used, I stumbled into these
problems.

        The first patch its more for documenting that strange system()
behaviour and to check if this was something that would have
implications in other 'perf test' cases besides this python one, maybe
somebody will spot the problem, but at least it seems more compact now
using 'python -c inline-python-source'.

v2:

- Don't suppress the python binding test, instead skip it and tell the
  reason: the binding isn't available.

- Treat NO_LIBTRACEVENT=1 like NO_LIBPYTHON=1, not suppressing tests, just
  skipping them, warn the user on explicit suppression of the library.

- Also reduce a patch description verbosity, as noted by Ian.

- Arnaldo

Arnaldo Carvalho de Melo (4):
  perf test python: Robustify the 'perf test python' test case
  perf test: Skip the python binding builtin test case with NO_LIBPYTHON=1
  perf test: Don't suppress the libtraceevent tests, skip them
  perf build: Emit a warning when libtraceevent is explicitely disabled

 tools/perf/Makefile.config                  |  4 +++-
 tools/perf/tests/Build                      | 12 +++++-----
 tools/perf/tests/builtin-test.c             |  6 -----
 tools/perf/tests/evsel-tp-sched.c           | 16 +++++++++++--
 tools/perf/tests/mmap-basic.c               | 26 +++++++++++++++++++--
 tools/perf/tests/openat-syscall-all-cpus.c  | 11 ++++++++-
 tools/perf/tests/openat-syscall-tp-fields.c | 11 ++++++++-
 tools/perf/tests/openat-syscall.c           | 11 ++++++++-
 tools/perf/tests/python-use.c               | 24 ++++++++++++++++---
 tools/perf/tests/switch-tracking.c          | 23 +++++++++++++++++-
 10 files changed, 120 insertions(+), 24 deletions(-)

-- 
2.47.0


             reply	other threads:[~2024-11-05 14:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05 14:26 Arnaldo Carvalho de Melo [this message]
2024-11-05 14:26 ` [PATCH v2 1/4] perf test python: Robustify the 'perf test python' test case Arnaldo Carvalho de Melo
2024-11-05 14:26 ` [PATCH v2 2/4] perf test: Skip the python binding builtin test case with NO_LIBPYTHON=1 Arnaldo Carvalho de Melo
2024-11-05 14:26 ` [PATCH v2 3/4] perf test: Don't suppress the libtraceevent tests, skip them Arnaldo Carvalho de Melo
2024-11-05 15:50   ` Ian Rogers
2024-11-08 17:50     ` Namhyung Kim
2024-11-09  0:14   ` Namhyung Kim
2024-11-05 14:26 ` [PATCH v2 4/4] perf build: Emit a warning when libtraceevent is explicitely disabled Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241105142616.761042-1-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=howardchu95@gmail.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=leo.yan@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tmricht@linux.ibm.com \
    --cc=vmolnaro@redhat.com \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox