From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, kernel test robot <lkp@intel.com>,
Damien Le Moal <dlemoal@kernel.org>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: block/blk-zoned.c:579:5-24: WARNING: atomic_dec_and_test variation before object free at line 583.
Date: Tue, 5 Nov 2024 16:37:33 +0100 [thread overview]
Message-ID: <20241105153733.GA7219@lst.de> (raw)
In-Reply-To: <e86904d7-bf42-4b38-889e-3978e89358f2@kernel.dk>
On Tue, Nov 05, 2024 at 08:36:33AM -0700, Jens Axboe wrote:
> On 11/5/24 8:34 AM, Christoph Hellwig wrote:
> > On Tue, Nov 05, 2024 at 06:52:25AM +0800, kernel test robot wrote:
> >>>> block/blk-zoned.c:579:5-24: WARNING: atomic_dec_and_test variation before object free at line 583.
> >
> > Does anyone know what this warning is supposed to mean?
>
> It's supposed to mean "use refcount_t for things like this".
Have we finally resolved the performance problems with refcount_t for
fast path operations?
next prev parent reply other threads:[~2024-11-05 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 22:52 block/blk-zoned.c:579:5-24: WARNING: atomic_dec_and_test variation before object free at line 583 kernel test robot
2024-11-05 15:34 ` Christoph Hellwig
2024-11-05 15:36 ` Jens Axboe
2024-11-05 15:37 ` Christoph Hellwig [this message]
2024-11-05 15:56 ` Jens Axboe
2024-11-06 22:53 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105153733.GA7219@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox