From: Lee Jones <lee@kernel.org>
To: George Stark <gnstark@salutedevices.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
robh@kernel.org, pavel@ucw.cz, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@salutedevices.com
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: pwm: Add default-brightness property
Date: Tue, 5 Nov 2024 15:57:54 +0000 [thread overview]
Message-ID: <20241105155754.GD1807686@google.com> (raw)
In-Reply-To: <aa96e9ab-00d6-413b-a7e8-8c709087f5bc@salutedevices.com>
On Sun, 03 Nov 2024, George Stark wrote:
> Hello Krzysztof, Rob
>
> Thanks for noticing it, missed the tag not by purpose, sorry about it.
> Sure I'll add the tag to v3 if v3 happens.
Please reply directly under the text you're referring to. Top-posting
is not allowed.
Please submit a v2 [RESEND] complete with the missing tags.
> On 11/2/24 16:06, Krzysztof Kozlowski wrote:
> > On Fri, Nov 01, 2024 at 06:48:43PM +0300, George Stark wrote:
> > > Optional default-brightness property specifies brightness value to be
> > > used if default LED state is on.
> > >
> > > Signed-off-by: George Stark <gnstark@salutedevices.com>
> > > ---
> > > Documentation/devicetree/bindings/leds/leds-pwm.yaml | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> >
> > <form letter>
> > This is a friendly reminder during the review process.
> >
> > It looks like you received a tag and forgot to add it.
> >
> > If you do not know the process, here is a short explanation: Please add
> > Acked-by/Reviewed-by/Tested-by tags when posting new versions, under
> > or above your Signed-off-by tag. Tag is "received", when provided
> > in a message replied to you on the mailing list. Tools like b4 can help
> > here. However, there's no need to repost patches *only* to add the tags.
> > The upstream maintainer will do that for tags received on the version
> > they apply.
> >
> > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
> >
> > If a tag was not added on purpose, please state why and what changed.
> > </form letter>
> >
> > Best regards,
> > Krzysztof
> >
>
> --
> Best regards
> George
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-11-05 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 15:48 [PATCH v2 0/2] leds: pwm: Add default-brightness property George Stark
2024-11-01 15:48 ` [PATCH v2 1/2] dt-bindings: " George Stark
2024-11-02 13:06 ` Krzysztof Kozlowski
2024-11-02 23:15 ` George Stark
2024-11-05 15:57 ` Lee Jones [this message]
2024-11-01 15:48 ` [PATCH v2 2/2] leds: pwm: Add optional DT property default-brightness George Stark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105155754.GD1807686@google.com \
--to=lee@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gnstark@salutedevices.com \
--cc=kernel@salutedevices.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox