From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 350DC1D7E5C for ; Wed, 6 Nov 2024 09:07:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730884073; cv=none; b=mdxanUohgtUARaQW3rXYek6pTQsqlYFowV6PvmyDBQlVgNTV4ujfE0v6makE1wtiudKyK22s/ysskKHZHeeBELhZ+GB0mRriRiOJ1srtLQrwedS2Xouo6pdFfvUPibwgacDquul4YS/A53pTlehFF9O7gSONaA6Zv0P7XctvyXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730884073; c=relaxed/simple; bh=iRDvP6Fds9e6sAJFt7TFL1RE85f61k0qNzCwm6EI0ik=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DiKKhcKQHZOUr/zTF15XEWSyMM+1n0C9UvcgZDHrTfCa+H4rr50YLpgxJ6faBN/CvApcH+sAnCqtnpUnDOZRTww7w0b3LhjLNETeCvIfAie87sOLKm4dwq8mNhbzgsNjN34KwpiI/2+YNsMzx2J4bf1oNEdXcgzk7jwEugr6aLU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DQmyahKL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DQmyahKL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730884071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=stsh36U7LL9w1fGvl92BzQf3qg6o4uyL96zdePlIQ+M=; b=DQmyahKLpa4uBsotLYNKDmHbDXgvZUnNoisXHyP5lY4MHhdN1ZZDOpcxTEJ8V8C5aELA2B unXYYdnB7WlxvJkVP0DZXVEcTqWy+FNLJfLSn3aljD1WI01uVAqyca0NFZNBy7IVO6L+UC bCzQupBxeyEYSLOOP8c2Mx3odJfJ2wE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-304-I589kpojOpmhwFcYRDTDtw-1; Wed, 06 Nov 2024 04:07:50 -0500 X-MC-Unique: I589kpojOpmhwFcYRDTDtw-1 X-Mimecast-MFC-AGG-ID: I589kpojOpmhwFcYRDTDtw Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-431604a3b47so40760225e9.3 for ; Wed, 06 Nov 2024 01:07:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730884069; x=1731488869; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=stsh36U7LL9w1fGvl92BzQf3qg6o4uyL96zdePlIQ+M=; b=jdDLQOpsye6BaYmXGNBpvBEVNAvbJ9s41tVaW6BzJ6SC7XHiJ6UZ/23a4WRnE/dOAi PkBP5O1mWoSyuFjXe24lxswH/qGW9NBo3SSynUzEocxELi+Y8PAmSCpigtq2dsTVBh/U GWfM6HKycxEwD7k7mtn8G8GZmVwKCEfNLZxR+H3Sc6674IlDfAUHyzfVP0hSFXlnw9sG RUPNwiGU/e0nUJdAd0GH0+Re97RYy88VAEDZNeT5wrsmbK0cySyjeaGRjWGH1jXpvRtg +BCgJbq4Adj9k5EN92IHAVimIWOvLSNSwceFBX4+dqlDn2bHw0BH6JOK09zbWWXVgVj2 BSXg== X-Forwarded-Encrypted: i=1; AJvYcCWPuH+ffVn0QyFfDAh12mm0eQZsU8fe6WJZdN388sQLtKopfrvp7/oFxYjvxipow7h1rGhttMeQW6pSo1w=@vger.kernel.org X-Gm-Message-State: AOJu0YzhbMisdvsBgzxjQ5nESmVcOjO3LfUTTn3D2VlSRryGtKMayumC l7NYs0NsEYMTjHHhuUX4B/pRNDvtl9XBYZn+Joqb6DxnKI4bw5tBlNlkjTr6n3cnX3RYH1J4nLB myk052SnQB4DRWEQ6tMOv7Os5fF3MVyyUJfdmUFl0DLj/yLUKUgOx8ZPx73z2EA== X-Received: by 2002:a5d:6902:0:b0:37d:4ebe:164f with SMTP id ffacd0b85a97d-38061200d23mr24637619f8f.46.1730884068795; Wed, 06 Nov 2024 01:07:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4QdCH0opectVmr8dgwxLSrIB+qc8WNu2CPVa8NB18xSiYf7L6K01+/errC2pGSWF3kucn/A== X-Received: by 2002:a5d:6902:0:b0:37d:4ebe:164f with SMTP id ffacd0b85a97d-38061200d23mr24637597f8f.46.1730884068451; Wed, 06 Nov 2024 01:07:48 -0800 (PST) Received: from redhat.com ([2a02:14f:178:e74:5fcf:8a69:659d:f2b2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c10b7e1bsm18681481f8f.1.2024.11.06.01.07.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 01:07:47 -0800 (PST) Date: Wed, 6 Nov 2024 04:07:44 -0500 From: "Michael S. Tsirkin" To: Jakub Kicinski Cc: Aleksandr Mikhalitsyn , Stefano Garzarella , stefanha@redhat.com, Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org Subject: Re: [PATCH v2] vhost/vsock: specify module version Message-ID: <20241106040705-mutt-send-email-mst@kernel.org> References: <20240929182103.21882-1-aleksandr.mikhalitsyn@canonical.com> <20241002071602.793d3e2d@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241002071602.793d3e2d@kernel.org> On Wed, Oct 02, 2024 at 07:16:02AM -0700, Jakub Kicinski wrote: > On Mon, 30 Sep 2024 19:03:52 +0200 Aleksandr Mikhalitsyn wrote: > > > At this point my question is, should we solve the problem higher and > > > show all the modules in /sys/modules, either way? > > > > Probably, yes. We can ask Luis Chamberlain's opinion on this one. > > > > +cc Luis Chamberlain > > > > > > > > Your use case makes sense to me, so that we could try something like > > > that, but obviously it requires more work I think. > > > > I personally am pretty happy to do more work on the generic side if > > it's really valuable > > for other use cases and folks support the idea. > > IMHO a generic solution would be much better. I can't help but feel > like exposing an arbitrary version to get the module to show up in > sysfs is a hack. > > IIUC the list of built in modules is available in > /lib/modules/*/modules.builtin, the user space can't read that? So what are we doing about this? Aleksandr? -- MST