* [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low
@ 2024-11-06 10:38 ahaslam
2024-11-06 15:47 ` Conor Dooley
2024-12-14 20:24 ` David Lechner
0 siblings, 2 replies; 4+ messages in thread
From: ahaslam @ 2024-11-06 10:38 UTC (permalink / raw)
To: jic23, krzk+dt, dlechner
Cc: Michael.Hennerich, robh, conor+dt, ahaslam, linux-iio, devicetree,
linux-kernel
From: Axel Haslam <ahaslam@baylibre.com>
On the example, the ldac gpio is flagged as active high, when in reality
its an active low gpio. Fix the example by using the active low flag for
the ldac gpio.
Fixes: baaa92d284d5 ("dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios")
Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
---
Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
index 79cb4b78a88a..2bd89e0aa46b 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
@@ -91,7 +91,7 @@ examples:
vrefn-supply = <&dac_vrefn>;
reset-gpios = <&gpio_bd 16 GPIO_ACTIVE_LOW>;
clear-gpios = <&gpio_bd 17 GPIO_ACTIVE_LOW>;
- ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_HIGH>;
+ ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_LOW>;
};
};
...
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low
2024-11-06 10:38 [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low ahaslam
@ 2024-11-06 15:47 ` Conor Dooley
2024-12-15 13:03 ` Jonathan Cameron
2024-12-14 20:24 ` David Lechner
1 sibling, 1 reply; 4+ messages in thread
From: Conor Dooley @ 2024-11-06 15:47 UTC (permalink / raw)
To: ahaslam
Cc: jic23, krzk+dt, dlechner, Michael.Hennerich, robh, conor+dt,
linux-iio, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
On Wed, Nov 06, 2024 at 11:38:24AM +0100, ahaslam@baylibre.com wrote:
> From: Axel Haslam <ahaslam@baylibre.com>
>
> On the example, the ldac gpio is flagged as active high, when in reality
> its an active low gpio. Fix the example by using the active low flag for
> the ldac gpio.
>
> Fixes: baaa92d284d5 ("dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios")
> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low
2024-11-06 10:38 [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low ahaslam
2024-11-06 15:47 ` Conor Dooley
@ 2024-12-14 20:24 ` David Lechner
1 sibling, 0 replies; 4+ messages in thread
From: David Lechner @ 2024-12-14 20:24 UTC (permalink / raw)
To: ahaslam, jic23
Cc: Michael.Hennerich, robh, conor+dt, krzk+dt, linux-iio, devicetree,
linux-kernel
On 11/6/24 4:38 AM, ahaslam@baylibre.com wrote:
> From: Axel Haslam <ahaslam@baylibre.com>
>
> On the example, the ldac gpio is flagged as active high, when in reality
> its an active low gpio. Fix the example by using the active low flag for
> the ldac gpio.
>
> Fixes: baaa92d284d5 ("dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios")
> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
> ---
> Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> index 79cb4b78a88a..2bd89e0aa46b 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> @@ -91,7 +91,7 @@ examples:
> vrefn-supply = <&dac_vrefn>;
> reset-gpios = <&gpio_bd 16 GPIO_ACTIVE_LOW>;
> clear-gpios = <&gpio_bd 17 GPIO_ACTIVE_LOW>;
> - ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_HIGH>;
> + ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_LOW>;
> };
> };
> ...
Hi Jonathan, any reason this one didn't get picked up yet?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low
2024-11-06 15:47 ` Conor Dooley
@ 2024-12-15 13:03 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2024-12-15 13:03 UTC (permalink / raw)
To: Conor Dooley
Cc: ahaslam, krzk+dt, dlechner, Michael.Hennerich, robh, conor+dt,
linux-iio, devicetree, linux-kernel
On Wed, 6 Nov 2024 15:47:01 +0000
Conor Dooley <conor@kernel.org> wrote:
> On Wed, Nov 06, 2024 at 11:38:24AM +0100, ahaslam@baylibre.com wrote:
> > From: Axel Haslam <ahaslam@baylibre.com>
> >
> > On the example, the ldac gpio is flagged as active high, when in reality
> > its an active low gpio. Fix the example by using the active low flag for
> > the ldac gpio.
> >
> > Fixes: baaa92d284d5 ("dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios")
> > Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Applied thanks. I'd dropped the ball on this one, so only noticed when reviewing
the older stuff in patchwork for dependencies that had resolved.
Jonathan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-15 13:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-06 10:38 [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low ahaslam
2024-11-06 15:47 ` Conor Dooley
2024-12-15 13:03 ` Jonathan Cameron
2024-12-14 20:24 ` David Lechner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox