public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wesley Cheng <quic_wcheng@quicinc.com>
To: <srinivas.kandagatla@linaro.org>, <mathias.nyman@intel.com>,
	<perex@perex.cz>, <conor+dt@kernel.org>,
	<dmitry.torokhov@gmail.com>, <corbet@lwn.net>,
	<broonie@kernel.org>, <lgirdwood@gmail.com>, <krzk+dt@kernel.org>,
	<pierre-louis.bossart@linux.intel.com>,
	<Thinh.Nguyen@synopsys.com>, <tiwai@suse.com>, <robh@kernel.org>,
	<gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-sound@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<linux-input@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-doc@vger.kernel.org>,
	Wesley Cheng <quic_wcheng@quicinc.com>
Subject: [PATCH v30 04/30] usb: host: xhci-mem: Allow for interrupter clients to choose specific index
Date: Wed, 6 Nov 2024 11:33:47 -0800	[thread overview]
Message-ID: <20241106193413.1730413-5-quic_wcheng@quicinc.com> (raw)
In-Reply-To: <20241106193413.1730413-1-quic_wcheng@quicinc.com>

Some clients may operate only on a specific XHCI interrupter instance.
Allow for the associated class driver to request for the interrupter that
it requires.

Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
---
 drivers/usb/host/xhci-mem.c       | 24 ++++++++++++++----------
 drivers/usb/host/xhci-sec-intr.c  |  5 +++--
 drivers/usb/host/xhci.h           |  2 +-
 include/linux/usb/xhci-sec-intr.h |  2 +-
 4 files changed, 19 insertions(+), 14 deletions(-)

diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index f6cfc989e28e..598d0b92c6fe 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -2338,14 +2338,15 @@ xhci_add_interrupter(struct xhci_hcd *xhci, struct xhci_interrupter *ir,
 
 struct xhci_interrupter *
 xhci_create_secondary_interrupter(struct usb_hcd *hcd, unsigned int segs,
-				  u32 imod_interval)
+				  u32 imod_interval, unsigned int intr_num)
 {
 	struct xhci_hcd *xhci = hcd_to_xhci(hcd);
 	struct xhci_interrupter *ir;
 	unsigned int i;
 	int err = -ENOSPC;
 
-	if (!xhci->interrupters || xhci->max_interrupters <= 1)
+	if (!xhci->interrupters || xhci->max_interrupters <= 1 ||
+	    intr_num >= xhci->max_interrupters)
 		return NULL;
 
 	ir = xhci_alloc_interrupter(xhci, segs, GFP_KERNEL);
@@ -2353,15 +2354,18 @@ xhci_create_secondary_interrupter(struct usb_hcd *hcd, unsigned int segs,
 		return NULL;
 
 	spin_lock_irq(&xhci->lock);
-
-	/* Find available secondary interrupter, interrupter 0 is reserved for primary */
-	for (i = 1; i < xhci->max_interrupters; i++) {
-		if (xhci->interrupters[i] == NULL) {
-			err = xhci_add_interrupter(xhci, ir, i);
-			break;
+	if (!intr_num) {
+		/* Find available secondary interrupter, interrupter 0 is reserved for primary */
+		for (i = 1; i < xhci->max_interrupters; i++) {
+			if (!xhci->interrupters[i]) {
+				err = xhci_add_interrupter(xhci, ir, i);
+				break;
+			}
 		}
+	} else {
+		if (!xhci->interrupters[intr_num])
+			err = xhci_add_interrupter(xhci, ir, intr_num);
 	}
-
 	spin_unlock_irq(&xhci->lock);
 
 	if (err) {
@@ -2377,7 +2381,7 @@ xhci_create_secondary_interrupter(struct usb_hcd *hcd, unsigned int segs,
 			  i, imod_interval);
 
 	xhci_dbg(xhci, "Add secondary interrupter %d, max interrupters %d\n",
-		 i, xhci->max_interrupters);
+		 ir->intr_num, xhci->max_interrupters);
 
 	return ir;
 }
diff --git a/drivers/usb/host/xhci-sec-intr.c b/drivers/usb/host/xhci-sec-intr.c
index b112c3388368..80d889979f30 100644
--- a/drivers/usb/host/xhci-sec-intr.c
+++ b/drivers/usb/host/xhci-sec-intr.c
@@ -273,7 +273,7 @@ EXPORT_SYMBOL_GPL(xhci_sec_intr_get_event_buffer);
  */
 int
 xhci_sec_intr_create_interrupter(struct xhci_sec_intr *si, int num_seg,
-				 bool ip_autoclear, u32 imod_interval)
+				 bool ip_autoclear, u32 imod_interval, int intr_num)
 {
 	int ret = 0;
 
@@ -287,7 +287,8 @@ xhci_sec_intr_create_interrupter(struct xhci_sec_intr *si, int num_seg,
 	}
 
 	si->ir = xhci_create_secondary_interrupter(xhci_to_hcd(si->xhci),
-						   num_seg, imod_interval);
+						   num_seg, imod_interval,
+						   intr_num);
 	if (!si->ir) {
 		ret = -ENOMEM;
 		goto out;
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index cde0105a7f1e..a95adbfc583b 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1833,7 +1833,7 @@ void xhci_free_container_ctx(struct xhci_hcd *xhci,
 		struct xhci_container_ctx *ctx);
 struct xhci_interrupter *
 xhci_create_secondary_interrupter(struct usb_hcd *hcd, unsigned int segs,
-				  u32 imod_interval);
+				  u32 imod_interval, unsigned int intr_num);
 void xhci_remove_secondary_interrupter(struct usb_hcd
 				       *hcd, struct xhci_interrupter *ir);
 void xhci_skip_sec_intr_events(struct xhci_hcd *xhci,
diff --git a/include/linux/usb/xhci-sec-intr.h b/include/linux/usb/xhci-sec-intr.h
index f6edb27b1d99..6e9b891bdced 100644
--- a/include/linux/usb/xhci-sec-intr.h
+++ b/include/linux/usb/xhci-sec-intr.h
@@ -59,7 +59,7 @@ xhci_sec_intr_get_event_buffer(struct xhci_sec_intr *si);
 
 int
 xhci_sec_intr_create_interrupter(struct xhci_sec_intr *si, int num_seg,
-				 bool ip_autoclear, u32 imod_interval);
+				 bool ip_autoclear, u32 imod_interval, int intr_num);
 
 void
 xhci_sec_intr_remove_interrupter(struct xhci_sec_intr *si);

  parent reply	other threads:[~2024-11-06 19:34 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06 19:33 [PATCH v30 00/30] Introduce QC USB SND audio offloading support Wesley Cheng
2024-11-06 19:33 ` [PATCH v30 01/30] usb: host: xhci: Repurpose event handler for skipping interrupter events Wesley Cheng
2024-11-20 11:48   ` Mathias Nyman
2024-11-20 18:48     ` Wesley Cheng
2024-11-06 19:33 ` [PATCH v30 02/30] xhci: sec-intr: add initial api to register a secondary interrupter entity Wesley Cheng
2024-11-20 14:36   ` Mathias Nyman
2024-11-21  1:34     ` Wesley Cheng
2024-11-21 19:15       ` Mathias Nyman
2024-11-21 20:24         ` Wesley Cheng
2024-11-06 19:33 ` [PATCH v30 03/30] usb: host: xhci-mem: Cleanup pending secondary event ring events Wesley Cheng
2024-11-06 19:33 ` Wesley Cheng [this message]
2024-11-06 19:33 ` [PATCH v30 05/30] usb: host: xhci-plat: Set XHCI max interrupters if property is present Wesley Cheng
2024-11-06 19:33 ` [PATCH v30 06/30] usb: dwc3: Specify maximum number of XHCI interrupters Wesley Cheng
2024-11-06 19:33 ` [PATCH v30 07/30] ALSA: Add USB audio device jack type Wesley Cheng
2024-11-20 11:51   ` Takashi Iwai
2024-11-06 19:33 ` [PATCH v30 08/30] ALSA: usb-audio: Export USB SND APIs for modules Wesley Cheng
2024-11-06 19:33 ` [PATCH v30 09/30] ALSA: usb-audio: Check for support for requested audio format Wesley Cheng
2024-11-06 19:33 ` [PATCH v30 10/30] ALSA: usb-audio: Save UAC sample size information Wesley Cheng
2024-11-06 19:33 ` [PATCH v30 11/30] ALSA: usb-audio: Prevent starting of audio stream if in use Wesley Cheng
2024-11-06 19:33 ` [PATCH v30 12/30] ASoC: Add SOC USB APIs for adding an USB backend Wesley Cheng
2024-11-06 19:33 ` [PATCH v30 13/30] ASoC: usb: Add PCM format check API for " Wesley Cheng
2024-11-06 19:33 ` [PATCH v30 14/30] ASoC: usb: Create SOC USB SND jack kcontrol Wesley Cheng
2024-12-03 16:14   ` Cezary Rojewski
2024-12-03 23:52     ` Wesley Cheng
2024-11-06 19:33 ` [PATCH v30 15/30] ASoC: usb: Fetch ASoC card and pcm device information Wesley Cheng
2024-11-20 12:23   ` Takashi Iwai
2024-11-20 22:36     ` Wesley Cheng
2024-11-06 19:33 ` [PATCH v30 16/30] ASoC: doc: Add documentation for SOC USB Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 17/30] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add USB_RX port Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 18/30] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 19/30] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 20/30] ASoC: qcom: qdsp6: q6afe: Increase APR timeout Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 21/30] ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6 Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 22/30] ASoC: qcom: qdsp6: Add headphone jack for offload connection status Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 23/30] ASoC: qcom: qdsp6: Fetch USB offload mapped card and PCM device Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 24/30] ALSA: usb-audio: Introduce USB SND platform op callbacks Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 25/30] ALSA: usb-audio: qcom: Add USB QMI definitions Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 26/30] ALSA: usb-audio: qcom: Introduce QC USB SND offloading support Wesley Cheng
2024-11-20 12:15   ` Takashi Iwai
2024-11-20 22:10     ` Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 27/30] ALSA: usb-audio: qcom: Don't allow USB offload path if PCM device is in use Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 28/30] ALSA: usb-audio: Add USB offload route kcontrol Wesley Cheng
2024-11-20 12:12   ` Takashi Iwai
2024-11-20 19:13     ` Wesley Cheng
2024-11-21 15:50       ` Takashi Iwai
2024-11-25 20:33         ` Wesley Cheng
2024-11-26 14:14           ` Takashi Iwai
2024-11-26 23:19             ` Wesley Cheng
2024-12-03 16:13   ` Cezary Rojewski
2024-12-03 23:15     ` Wesley Cheng
2024-12-06  9:09       ` Cezary Rojewski
2024-12-06 20:43         ` Wesley Cheng
2024-12-10 15:24           ` Cezary Rojewski
2024-12-10 16:52             ` Takashi Iwai
2024-12-06 23:35         ` Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 29/30] ALSA: usb-audio: Allow for rediscovery of connected USB SND devices Wesley Cheng
2024-11-06 19:34 ` [PATCH v30 30/30] ASoC: usb: Rediscover USB SND devices on USB port add Wesley Cheng
2024-11-15 22:42 ` [PATCH v30 00/30] Introduce QC USB SND audio offloading support Wesley Cheng
2024-11-16  7:42   ` Greg KH
2024-11-19 17:50     ` Wesley Cheng
2024-11-20 12:39       ` Takashi Iwai
2024-11-20 23:18         ` Wesley Cheng
2024-12-01  3:14           ` Pierre-Louis Bossart
2024-12-03 16:17             ` Cezary Rojewski
2024-12-03 16:57               ` Greg KH
2024-12-04 21:14                 ` Cezary Rojewski
2024-12-05  1:15                   ` Wesley Cheng
2024-12-05  6:50                     ` Greg KH
2024-12-03 20:38               ` Wesley Cheng
2024-12-04 22:01                 ` Cezary Rojewski
2024-12-06  0:28                   ` Wesley Cheng
2024-12-10 15:18                     ` Cezary Rojewski
2024-12-10 22:20                       ` Wesley Cheng
2024-12-17 23:20                       ` Pierre-Louis Bossart
     [not found]               ` <4C900353-B977-451C-B003-BAA51E458726@linux.dev>
2024-12-04 22:11                 ` Cezary Rojewski
     [not found]                   ` <4E9925AF-F297-42A5-9CB8-F8568F0A5EDF@linux.dev>
2024-12-06  0:53                     ` Wesley Cheng
2024-12-10  0:59                       ` Wesley Cheng
2024-12-10 16:40                         ` Takashi Iwai
2024-12-11  2:00                           ` Wesley Cheng
2024-12-13  9:10                             ` Guan-Yu Lin
2024-12-03 16:16   ` Cezary Rojewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241106193413.1730413-5-quic_wcheng@quicinc.com \
    --to=quic_wcheng@quicinc.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox