From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: Huacai Chen <chenhuacai@kernel.org>,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev, Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6.1.y] LoongArch: Fix build errors due to backported TIMENS
Date: Wed, 6 Nov 2024 08:27:36 +0100 [thread overview]
Message-ID: <2024110622-dejected-underfeed-ac4a@gregkh> (raw)
In-Reply-To: <20241102033616.3517188-1-chenhuacai@loongson.cn>
On Sat, Nov 02, 2024 at 11:36:16AM +0800, Huacai Chen wrote:
> Commit eb3710efffce1dcff83761db4615f91d93aabfcb ("LoongArch: Add support
> to clone a time namespace") backports the TIMENS support for LoongArch
> (corresponding upstream commit aa5e65dc0818bbf676bf06927368ec46867778fd)
> but causes build errors:
>
> CC arch/loongarch/kernel/vdso.o
> arch/loongarch/kernel/vdso.c: In function ‘vvar_fault’:
> arch/loongarch/kernel/vdso.c:54:36: error: implicit declaration of
> function ‘find_timens_vvar_page’ [-Werror=implicit-function-declaration]
> 54 | struct page *timens_page = find_timens_vvar_page(vma);
> | ^~~~~~~~~~~~~~~~~~~~~
> arch/loongarch/kernel/vdso.c:54:36: warning: initialization of ‘struct
> page *’ from ‘int’ makes pointer from integer without a cast
> [-Wint-conversion]
> arch/loongarch/kernel/vdso.c: In function ‘vdso_join_timens’:
> arch/loongarch/kernel/vdso.c:143:25: error: implicit declaration of
> function ‘zap_vma_pages’; did you mean ‘zap_vma_ptes’?
> [-Werror=implicit-function-declaration]
> 143 | zap_vma_pages(vma);
> | ^~~~~~~~~~~~~
> | zap_vma_ptes
> cc1: some warnings being treated as errors
>
> Because in 6.1.y we should define find_timens_vvar_page() by ourselves
> and use zap_page_range() instead of zap_vma_pages(), so fix it.
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
> arch/loongarch/kernel/vdso.c | 28 +++++++++++++++++++++++++++-
> 1 file changed, 27 insertions(+), 1 deletion(-)
Now queued up, thanks!
greg k-h
prev parent reply other threads:[~2024-11-06 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-02 3:36 [PATCH 6.1.y] LoongArch: Fix build errors due to backported TIMENS Huacai Chen
2024-11-06 7:27 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024110622-dejected-underfeed-ac4a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox