From: Christoph Hellwig <hch@lst.de>
To: zhangguopeng <zhangguopeng@kylinos.cn>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, hch@lst.de,
ming.lei@redhat.com, yukuai3@huawei.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Replace sprintf() with sysfs_emit()
Date: Thu, 7 Nov 2024 06:44:20 +0100 [thread overview]
Message-ID: <20241107054420.GA2336@lst.de> (raw)
In-Reply-To: <20241106083454.45887-1-zhangguopeng@kylinos.cn>
On Wed, Nov 06, 2024 at 04:34:54PM +0800, zhangguopeng wrote:
> - return sprintf(page, "%llu\n", \
> + return sysfs_emit(page, "%llu\n", \
Please keep the \ aligned for all the multi-line macros.
Otherwise this looks fine to me.
prev parent reply other threads:[~2024-11-07 5:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 8:34 [PATCH] block: Replace sprintf() with sysfs_emit() zhangguopeng
2024-11-07 5:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107054420.GA2336@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yukuai3@huawei.com \
--cc=zhangguopeng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox