From: Mithil Bavishi <bavishimithil@gmail.com>
To: andreas@kemnade.info
Cc: aaro.koskinen@iki.fi, bavishimithil@gmail.com,
conor+dt@kernel.org, devicetree@vger.kernel.org,
khilman@baylibre.com, krzk+dt@kernel.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, robh@kernel.org, rogerq@kernel.org,
tony@atomide.com
Subject: Re: [PATCH v2 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series
Date: Fri, 8 Nov 2024 09:51:07 +0000 [thread overview]
Message-ID: <20241108095107.5338-1-bavishimithil@gmail.com> (raw)
In-Reply-To: <20241103183636.40cc37fc@akair>
> probably you did not notice an error in make dtbs and the old
> devicetree on the device was still there and was used.
I messed up my PowerVR tree with mainline, hence the problems. I've fixed
it now locally.
> are not the ones you need to fix, so just the diff between old and new.
Yeah, I ran the command for espresso and then panda for a comparision.
The diff is what i worked on, but I have some doubts which I'd like to ask
dts/ti/omap/omap4-samsung-espresso7.dtb: /: irled@0: 'anyOf' conditional
failed, one must be fixed:
'reg' is a required property
'ranges' is a required property
from schema $id: http://devicetree.org/schemas/root-node.yaml#
Documentation/devicetree/bindings/leds/irled/gpio-ir-tx.yaml does not say
those properties to be required, is the node placed incorrectly?
/home/mighty/linux/arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb:
/: pwm@10: 'anyOf' conditional failed, one must be fixed:
'reg' is a required property
'ranges' is a required property
from schema $id: http://devicetree.org/schemas/root-node.yaml#
Similarly here as well.
/home/mighty/linux/arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb:
current-sense-shunt: 'io-channel-ranges' does not match any of the
regexes: 'pinctrl-[0-9]+'
from schema $id:
http://devicetree.org/schemas/iio/afe/current-sense-shunt.yaml#
I tried searching the tree for "io-channel-ranges" which has only one
example - ste-ux500-samsung-janice.dts. In that dts the node is same as
in espresso.
Best Regards,
Mithil
next prev parent reply other threads:[~2024-11-08 9:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 21:12 [PATCH v2 0/6] Initial support for Samsung Galaxy Tab 2 series Mithil Bavishi
2024-10-30 21:12 ` [PATCH v2 1/6] ARM: dts: twl6032: Add DTS file for TWL6032 PMIC Mithil Bavishi
2024-10-30 21:12 ` [PATCH v2 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series Mithil Bavishi
2024-10-30 22:42 ` Andreas Kemnade
2024-10-31 6:55 ` Mithil Bavishi
2024-10-31 7:32 ` Andreas Kemnade
2024-10-31 10:41 ` Mithil Bavishi
2024-11-03 17:36 ` Andreas Kemnade
2024-11-08 9:51 ` Mithil Bavishi [this message]
2024-11-08 10:41 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108095107.5338-1-bavishimithil@gmail.com \
--to=bavishimithil@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox