From: kernel test robot <lkp@intel.com>
To: Jocelyn Falempe <jfalempe@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
John Ogness <john.ogness@linutronix.de>,
Javier Martinez Canillas <javierm@redhat.com>,
"Guilherme G . Piccoli" <gpiccoli@igalia.com>,
bluescreen_avenger@verizon.net,
Caleb Connolly <caleb.connolly@linaro.org>,
Petr Mladek <pmladek@suse.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, Jocelyn Falempe <jfalempe@redhat.com>
Subject: Re: [PATCH v7 2/7] drm/client: Always select DRM_CLIENT_LIB
Date: Fri, 8 Nov 2024 19:56:21 +0800 [thread overview]
Message-ID: <202411081923.vkZSFxL2-lkp@intel.com> (raw)
In-Reply-To: <20241108082025.1004653-3-jfalempe@redhat.com>
Hi Jocelyn,
kernel test robot noticed the following build errors:
[auto build test ERROR on baf4afc5831438b35de4b0e951b9cd58435a6d99]
url: https://github.com/intel-lab-lkp/linux/commits/Jocelyn-Falempe/drm-panic-Move-drawing-functions-to-drm_draw/20241108-162222
base: baf4afc5831438b35de4b0e951b9cd58435a6d99
patch link: https://lore.kernel.org/r/20241108082025.1004653-3-jfalempe%40redhat.com
patch subject: [PATCH v7 2/7] drm/client: Always select DRM_CLIENT_LIB
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20241108/202411081923.vkZSFxL2-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241108/202411081923.vkZSFxL2-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411081923.vkZSFxL2-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/drm_client_setup.c:25:6: error: redefinition of 'drm_client_setup'
25 | void drm_client_setup(struct drm_device *dev, const struct drm_format_info *format)
| ^~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/drm_client_setup.c:3:
include/drm/drm_client_setup.h:16:20: note: previous definition of 'drm_client_setup' with type 'void(struct drm_device *, const struct drm_format_info *)'
16 | static inline void drm_client_setup(struct drm_device *dev,
| ^~~~~~~~~~~~~~~~
>> drivers/gpu/drm/drm_client_setup.c:43:6: error: redefinition of 'drm_client_setup_with_fourcc'
43 | void drm_client_setup_with_fourcc(struct drm_device *dev, u32 fourcc)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/drm_client_setup.c:3:
include/drm/drm_client_setup.h:19:20: note: previous definition of 'drm_client_setup_with_fourcc' with type 'void(struct drm_device *, u32)' {aka 'void(struct drm_device *, unsigned int)'}
19 | static inline void drm_client_setup_with_fourcc(struct drm_device *dev, u32 fourcc)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/drm_client_setup.c:60:6: error: redefinition of 'drm_client_setup_with_color_mode'
60 | void drm_client_setup_with_color_mode(struct drm_device *dev, unsigned int color_mode)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/drm_client_setup.c:3:
include/drm/drm_client_setup.h:21:20: note: previous definition of 'drm_client_setup_with_color_mode' with type 'void(struct drm_device *, unsigned int)'
21 | static inline void drm_client_setup_with_color_mode(struct drm_device *dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/drm_client_setup +25 drivers/gpu/drm/drm_client_setup.c
d07fdf9225922d Thomas Zimmermann 2024-09-24 8
d07fdf9225922d Thomas Zimmermann 2024-09-24 9 /**
d07fdf9225922d Thomas Zimmermann 2024-09-24 10 * drm_client_setup() - Setup in-kernel DRM clients
d07fdf9225922d Thomas Zimmermann 2024-09-24 11 * @dev: DRM device
d07fdf9225922d Thomas Zimmermann 2024-09-24 12 * @format: Preferred pixel format for the device. Use NULL, unless
d07fdf9225922d Thomas Zimmermann 2024-09-24 13 * there is clearly a driver-preferred format.
d07fdf9225922d Thomas Zimmermann 2024-09-24 14 *
d07fdf9225922d Thomas Zimmermann 2024-09-24 15 * This function sets up the in-kernel DRM clients. Restore, hotplug
d07fdf9225922d Thomas Zimmermann 2024-09-24 16 * events and teardown are all taken care of.
d07fdf9225922d Thomas Zimmermann 2024-09-24 17 *
d07fdf9225922d Thomas Zimmermann 2024-09-24 18 * Drivers should call drm_client_setup() after registering the new
d07fdf9225922d Thomas Zimmermann 2024-09-24 19 * DRM device with drm_dev_register(). This function is safe to call
d07fdf9225922d Thomas Zimmermann 2024-09-24 20 * even when there are no connectors present. Setup will be retried
d07fdf9225922d Thomas Zimmermann 2024-09-24 21 * on the next hotplug event.
d07fdf9225922d Thomas Zimmermann 2024-09-24 22 *
d07fdf9225922d Thomas Zimmermann 2024-09-24 23 * The clients are destroyed by drm_dev_unregister().
d07fdf9225922d Thomas Zimmermann 2024-09-24 24 */
d07fdf9225922d Thomas Zimmermann 2024-09-24 @25 void drm_client_setup(struct drm_device *dev, const struct drm_format_info *format)
d07fdf9225922d Thomas Zimmermann 2024-09-24 26 {
d07fdf9225922d Thomas Zimmermann 2024-09-24 27 int ret;
d07fdf9225922d Thomas Zimmermann 2024-09-24 28
d07fdf9225922d Thomas Zimmermann 2024-09-24 29 ret = drm_fbdev_client_setup(dev, format);
d07fdf9225922d Thomas Zimmermann 2024-09-24 30 if (ret)
d07fdf9225922d Thomas Zimmermann 2024-09-24 31 drm_warn(dev, "Failed to set up DRM client; error %d\n", ret);
d07fdf9225922d Thomas Zimmermann 2024-09-24 32 }
d07fdf9225922d Thomas Zimmermann 2024-09-24 33 EXPORT_SYMBOL(drm_client_setup);
d07fdf9225922d Thomas Zimmermann 2024-09-24 34
d07fdf9225922d Thomas Zimmermann 2024-09-24 35 /**
d07fdf9225922d Thomas Zimmermann 2024-09-24 36 * drm_client_setup_with_fourcc() - Setup in-kernel DRM clients for color mode
d07fdf9225922d Thomas Zimmermann 2024-09-24 37 * @dev: DRM device
d07fdf9225922d Thomas Zimmermann 2024-09-24 38 * @fourcc: Preferred pixel format as 4CC code for the device
d07fdf9225922d Thomas Zimmermann 2024-09-24 39 *
d07fdf9225922d Thomas Zimmermann 2024-09-24 40 * This function sets up the in-kernel DRM clients. It is equivalent
d07fdf9225922d Thomas Zimmermann 2024-09-24 41 * to drm_client_setup(), but expects a 4CC code as second argument.
d07fdf9225922d Thomas Zimmermann 2024-09-24 42 */
d07fdf9225922d Thomas Zimmermann 2024-09-24 @43 void drm_client_setup_with_fourcc(struct drm_device *dev, u32 fourcc)
d07fdf9225922d Thomas Zimmermann 2024-09-24 44 {
d07fdf9225922d Thomas Zimmermann 2024-09-24 45 drm_client_setup(dev, drm_format_info(fourcc));
d07fdf9225922d Thomas Zimmermann 2024-09-24 46 }
d07fdf9225922d Thomas Zimmermann 2024-09-24 47 EXPORT_SYMBOL(drm_client_setup_with_fourcc);
d07fdf9225922d Thomas Zimmermann 2024-09-24 48
d07fdf9225922d Thomas Zimmermann 2024-09-24 49 /**
d07fdf9225922d Thomas Zimmermann 2024-09-24 50 * drm_client_setup_with_color_mode() - Setup in-kernel DRM clients for color mode
d07fdf9225922d Thomas Zimmermann 2024-09-24 51 * @dev: DRM device
d07fdf9225922d Thomas Zimmermann 2024-09-24 52 * @color_mode: Preferred color mode for the device
d07fdf9225922d Thomas Zimmermann 2024-09-24 53 *
d07fdf9225922d Thomas Zimmermann 2024-09-24 54 * This function sets up the in-kernel DRM clients. It is equivalent
d07fdf9225922d Thomas Zimmermann 2024-09-24 55 * to drm_client_setup(), but expects a color mode as second argument.
d07fdf9225922d Thomas Zimmermann 2024-09-24 56 *
d07fdf9225922d Thomas Zimmermann 2024-09-24 57 * Do not use this function in new drivers. Prefer drm_client_setup() with a
d07fdf9225922d Thomas Zimmermann 2024-09-24 58 * format of NULL.
d07fdf9225922d Thomas Zimmermann 2024-09-24 59 */
d07fdf9225922d Thomas Zimmermann 2024-09-24 @60 void drm_client_setup_with_color_mode(struct drm_device *dev, unsigned int color_mode)
d07fdf9225922d Thomas Zimmermann 2024-09-24 61 {
d07fdf9225922d Thomas Zimmermann 2024-09-24 62 u32 fourcc = drm_driver_color_mode_format(dev, color_mode);
d07fdf9225922d Thomas Zimmermann 2024-09-24 63
d07fdf9225922d Thomas Zimmermann 2024-09-24 64 drm_client_setup_with_fourcc(dev, fourcc);
d07fdf9225922d Thomas Zimmermann 2024-09-24 65 }
d07fdf9225922d Thomas Zimmermann 2024-09-24 66 EXPORT_SYMBOL(drm_client_setup_with_color_mode);
dadd28d4142f9a Thomas Zimmermann 2024-10-14 67
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-11-08 11:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 8:10 [PATCH v7 0/7] drm/log: Introduce a new boot logger to draw the kmsg on the screen Jocelyn Falempe
2024-11-08 8:10 ` [PATCH v7 1/7] drm/panic: Move drawing functions to drm_draw Jocelyn Falempe
2024-11-11 13:03 ` Thomas Zimmermann
2024-11-08 8:10 ` [PATCH v7 2/7] drm/client: Always select DRM_CLIENT_LIB Jocelyn Falempe
2024-11-08 11:56 ` kernel test robot [this message]
2024-11-08 8:10 ` [PATCH v7 3/7] drm/log: Introduce a new boot logger to draw the kmsg on the screen Jocelyn Falempe
2024-11-08 12:27 ` kernel test robot
2024-11-08 13:08 ` kernel test robot
2024-11-08 8:10 ` [PATCH v7 4/7] drm/log: Do not draw if drm_master is taken Jocelyn Falempe
2024-11-08 13:33 ` Thomas Zimmermann
2024-11-08 13:51 ` Jocelyn Falempe
2024-11-08 8:10 ` [PATCH v7 5/7] drm/log: Color the timestamp, to improve readability Jocelyn Falempe
2024-11-08 8:10 ` [PATCH v7 6/7] drm/log: Implement suspend/resume Jocelyn Falempe
2024-11-08 8:10 ` [PATCH v7 7/7] drm/log: Add integer scaling support Jocelyn Falempe
2024-11-11 13:06 ` Thomas Zimmermann
2024-11-12 9:51 ` Jocelyn Falempe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411081923.vkZSFxL2-lkp@intel.com \
--to=lkp@intel.com \
--cc=airlied@gmail.com \
--cc=bluescreen_avenger@verizon.net \
--cc=caleb.connolly@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gpiccoli@igalia.com \
--cc=javierm@redhat.com \
--cc=jfalempe@redhat.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pmladek@suse.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox