From: Greg KH <gregkh@linuxfoundation.org>
To: Brendan Jackman <jackmanb@google.com>
Cc: cve@kernel.org, linux-cve-announce@vger.kernel.org,
linux-kernel@vger.kernel.org, kpsing@google.com,
ciprietti@google.com, melotti@google.com,
sanjay.k.kumar@intel.com
Subject: Re: CVE-2024-49993: iommu/vt-d: Fix potential lockup if qi_submit_sync called with 0 count
Date: Sun, 10 Nov 2024 10:40:57 +0100 [thread overview]
Message-ID: <2024111012-proofs-tinsmith-9569@gregkh> (raw)
In-Reply-To: <20241029114008.2436272-1-jackmanb@google.com>
On Tue, Oct 29, 2024 at 11:40:08AM +0000, Brendan Jackman wrote:
> Hi Greg,
>
> > Currently, there is no impact
> > by this bug on the existing users because no callers are submitting
> > invalidations with 0 descriptors.
>
> I think this CVE could be discarded, the count arg is always hard-coded to 1.
> The buggy function isn't even exposed to modules so I think even if we care
> about out-of-tree code we should be OK here. (But based on [1] it sounds like
> out-of-tree code is probably out-of-scope for kernel CVEs anyway?)
>
> [1] https://docs.kernel.org/process/cve.html#invalid-cves
Yes, out-of-tree code is on its own, for obvious reasons (i.e. we have
no idea what they are doing, and they know exactly what we are doing...)
> FWIW, I don't have any burning desire to kill this CVE in particular, I'm just
> testing the water to see if this is one reasonable way we could share some
> triage effort among consumers of kernel CVEs...
Yes, you are right, this one should be rejected, and that's now done,
thanks for the review.
greg k-h
prev parent reply other threads:[~2024-11-10 9:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2024102138-CVE-2024-49993-5b57@gregkh>
2024-10-29 11:40 ` CVE-2024-49993: iommu/vt-d: Fix potential lockup if qi_submit_sync called with 0 count Brendan Jackman
2024-11-10 9:40 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024111012-proofs-tinsmith-9569@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ciprietti@google.com \
--cc=cve@kernel.org \
--cc=jackmanb@google.com \
--cc=kpsing@google.com \
--cc=linux-cve-announce@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=melotti@google.com \
--cc=sanjay.k.kumar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox