From: Arnd Bergmann <arnd@kernel.org>
To: "Nipun Gupta" <nipun.gupta@amd.com>,
"Nikhil Agarwal" <nikhil.agarwal@amd.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Andrew Donnellan" <ajd@linux.ibm.com>,
"Thomas Weißschuh" <linux@weissschuh.net>
Cc: Arnd Bergmann <arnd@arndb.de>,
Abhijit Gangurde <abhijit.gangurde@amd.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] cdx: constify bin_attribute callback
Date: Mon, 11 Nov 2024 11:33:24 +0100 [thread overview]
Message-ID: <20241111103333.3355250-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
This one was missed in the treewide conversion:
drivers/cdx/cdx.c: In function 'cdx_create_res_attr':
drivers/cdx/cdx.c:773:24: error: assignment to 'int (*)(struct file *, struct kobject *, const struct bin_attribute *, struct vm_area_struct *)' from incompatible pointer type 'int (*)(struct file *, struct kobject *, struct bin_attribute *, struct vm_area_struct *)' [-Wincompatible-pointer-types]
773 | res_attr->mmap = cdx_mmap_resource;
| ^
Fixes: 94a20fb9af16 ("sysfs: treewide: constify attribute callback of bin_attribute::mmap()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/cdx/cdx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c
index 07371cb653d3..316bd89a95ca 100644
--- a/drivers/cdx/cdx.c
+++ b/drivers/cdx/cdx.c
@@ -707,7 +707,7 @@ static const struct vm_operations_struct cdx_phys_vm_ops = {
* Return: true on success, false otherwise.
*/
static int cdx_mmap_resource(struct file *fp, struct kobject *kobj,
- struct bin_attribute *attr,
+ const struct bin_attribute *attr,
struct vm_area_struct *vma)
{
struct cdx_device *cdx_dev = to_cdx_device(kobj_to_dev(kobj));
--
2.39.5
next reply other threads:[~2024-11-11 10:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 10:33 Arnd Bergmann [this message]
2024-11-11 11:09 ` [PATCH] cdx: constify bin_attribute callback Agarwal, Nikhil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111103333.3355250-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=abhijit.gangurde@amd.com \
--cc=ajd@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=nikhil.agarwal@amd.com \
--cc=nipun.gupta@amd.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox