From: Rob Herring <robh@kernel.org>
To: Valentina Fernandez <valentina.fernandezalanis@microchip.com>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, ycliang@andestech.com,
prabhakar.mahadev-lad.rj@bp.renesas.com, peterlin@andestech.com,
samuel.holland@sifive.com, conor.dooley@microchip.com,
alexghiti@rivosinc.com, ruanjinjie@huawei.com,
takakura@valinux.co.jp, conor+dt@kernel.org,
jassisinghbrar@gmail.com, krzk+dt@kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/4] riscv: export __cpuid_to_hartid_map
Date: Mon, 11 Nov 2024 15:52:20 -0600 [thread overview]
Message-ID: <20241111215220.GA1993016-robh@kernel.org> (raw)
In-Reply-To: <20241105183513.1358736-3-valentina.fernandezalanis@microchip.com>
On Tue, Nov 05, 2024 at 06:35:11PM +0000, Valentina Fernandez wrote:
> EXPORT_SYMBOL_GPL() is missing for __cpuid_to_hartid_map array.
> Export this symbol to allow drivers compiled as modules to use
> cpuid_to_hartid_map().
>
> Signed-off-by: Valentina Fernandez <valentina.fernandezalanis@microchip.com>
> ---
> arch/riscv/kernel/smp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c
> index c180a647a30e..d58b5e751286 100644
> --- a/arch/riscv/kernel/smp.c
> +++ b/arch/riscv/kernel/smp.c
> @@ -43,6 +43,7 @@ enum ipi_message_type {
> unsigned long __cpuid_to_hartid_map[NR_CPUS] __ro_after_init = {
> [0 ... NR_CPUS-1] = INVALID_HARTID
> };
> +EXPORT_SYMBOL_GPL(__cpuid_to_hartid_map);
Why can't riscv implement cpu_logical_map() like other arches?
We really should have a common implementation too, but that's probably
too much to ask I guess.
Rob
next prev parent reply other threads:[~2024-11-11 21:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 18:35 [PATCH v3 0/4] Add Microchip IPC mailbox Valentina Fernandez
2024-11-05 18:35 ` [PATCH v3 1/4] riscv: sbi: vendorid_list: Add Microchip Technology to the vendor list Valentina Fernandez
2024-11-05 18:35 ` [PATCH v3 2/4] riscv: export __cpuid_to_hartid_map Valentina Fernandez
2024-11-11 21:52 ` Rob Herring [this message]
2024-11-19 20:32 ` Atish Patra
2024-11-05 18:35 ` [PATCH v3 3/4] dt-bindings: mailbox: add binding for Microchip IPC mailbox controller Valentina Fernandez
2024-11-19 14:12 ` Rob Herring
2024-11-05 18:35 ` [PATCH v3 4/4] mailbox: add Microchip IPC support Valentina Fernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111215220.GA1993016-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexghiti@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterlin@andestech.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=ruanjinjie@huawei.com \
--cc=samuel.holland@sifive.com \
--cc=takakura@valinux.co.jp \
--cc=valentina.fernandezalanis@microchip.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox