* [PATCH] ynl: samples: Fix the wrong format specifier
@ 2024-11-12 8:39 Luo Yifan
2024-11-12 9:50 ` Donald Hunter
2024-11-12 16:02 ` Jakub Kicinski
0 siblings, 2 replies; 6+ messages in thread
From: Luo Yifan @ 2024-11-12 8:39 UTC (permalink / raw)
To: davem, kuba, pabeni, donald.hunter; +Cc: linux-kernel, edumazet, sfr, Luo Yifan
Make a minor change to eliminate a static checker warning. The type
of s->ifc is unsigned int, so the correct format specifier should be
%u instead of %d.
Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com>
---
tools/net/ynl/samples/page-pool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/net/ynl/samples/page-pool.c b/tools/net/ynl/samples/page-pool.c
index 332f281ee..e5d521320 100644
--- a/tools/net/ynl/samples/page-pool.c
+++ b/tools/net/ynl/samples/page-pool.c
@@ -118,7 +118,7 @@ int main(int argc, char **argv)
name = if_indextoname(s->ifc, ifname);
if (name)
printf("%8s", name);
- printf("[%d]\t", s->ifc);
+ printf("[%u]\t", s->ifc);
}
printf("page pools: %u (zombies: %u)\n",
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ynl: samples: Fix the wrong format specifier
2024-11-12 8:39 [PATCH] ynl: samples: Fix the wrong format specifier Luo Yifan
@ 2024-11-12 9:50 ` Donald Hunter
2024-11-12 16:02 ` Jakub Kicinski
1 sibling, 0 replies; 6+ messages in thread
From: Donald Hunter @ 2024-11-12 9:50 UTC (permalink / raw)
To: Luo Yifan; +Cc: davem, kuba, pabeni, linux-kernel, edumazet, sfr
On Tue, 12 Nov 2024 at 08:39, Luo Yifan <luoyifan@cmss.chinamobile.com> wrote:
>
> Make a minor change to eliminate a static checker warning. The type
> of s->ifc is unsigned int, so the correct format specifier should be
> %u instead of %d.
You should include netdev@vger.kernel.org on the recipient list and
the subject should name the target tree, so it should say [PATCH
net-next] unless it is a fix that you want to go to the net tree in
which case it would be [PATCH net].
That said, the patch looks good to me.
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ynl: samples: Fix the wrong format specifier
2024-11-12 8:39 [PATCH] ynl: samples: Fix the wrong format specifier Luo Yifan
2024-11-12 9:50 ` Donald Hunter
@ 2024-11-12 16:02 ` Jakub Kicinski
2024-11-13 1:11 ` [PATCH net-next] " Luo Yifan
1 sibling, 1 reply; 6+ messages in thread
From: Jakub Kicinski @ 2024-11-12 16:02 UTC (permalink / raw)
To: Luo Yifan; +Cc: davem, pabeni, donald.hunter, linux-kernel, edumazet, sfr
On Tue, 12 Nov 2024 16:39:21 +0800 Luo Yifan wrote:
> Make a minor change to eliminate a static checker warning. The type
> of s->ifc is unsigned int, so the correct format specifier should be
> %u instead of %d.
>
> Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com>
Please repost and CC the netdev@ mailing list
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH net-next] ynl: samples: Fix the wrong format specifier
2024-11-12 16:02 ` Jakub Kicinski
@ 2024-11-13 1:11 ` Luo Yifan
2024-11-13 10:52 ` Simon Horman
2024-11-14 2:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 6+ messages in thread
From: Luo Yifan @ 2024-11-13 1:11 UTC (permalink / raw)
To: kuba, donald.hunter
Cc: davem, edumazet, linux-kernel, luoyifan, pabeni, sfr, netdev
Make a minor change to eliminate a static checker warning. The type
of s->ifc is unsigned int, so the correct format specifier should be
%u instead of %d.
Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com>
---
tools/net/ynl/samples/page-pool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/net/ynl/samples/page-pool.c b/tools/net/ynl/samples/page-pool.c
index 332f281ee..e5d521320 100644
--- a/tools/net/ynl/samples/page-pool.c
+++ b/tools/net/ynl/samples/page-pool.c
@@ -118,7 +118,7 @@ int main(int argc, char **argv)
name = if_indextoname(s->ifc, ifname);
if (name)
printf("%8s", name);
- printf("[%d]\t", s->ifc);
+ printf("[%u]\t", s->ifc);
}
printf("page pools: %u (zombies: %u)\n",
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net-next] ynl: samples: Fix the wrong format specifier
2024-11-13 1:11 ` [PATCH net-next] " Luo Yifan
@ 2024-11-13 10:52 ` Simon Horman
2024-11-14 2:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 6+ messages in thread
From: Simon Horman @ 2024-11-13 10:52 UTC (permalink / raw)
To: Luo Yifan
Cc: kuba, donald.hunter, davem, edumazet, linux-kernel, pabeni, sfr,
netdev
On Wed, Nov 13, 2024 at 09:11:42AM +0800, Luo Yifan wrote:
> Make a minor change to eliminate a static checker warning. The type
> of s->ifc is unsigned int, so the correct format specifier should be
> %u instead of %d.
>
> Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] ynl: samples: Fix the wrong format specifier
2024-11-13 1:11 ` [PATCH net-next] " Luo Yifan
2024-11-13 10:52 ` Simon Horman
@ 2024-11-14 2:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-11-14 2:50 UTC (permalink / raw)
To: Luo Yifan
Cc: kuba, donald.hunter, davem, edumazet, linux-kernel, pabeni, sfr,
netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 13 Nov 2024 09:11:42 +0800 you wrote:
> Make a minor change to eliminate a static checker warning. The type
> of s->ifc is unsigned int, so the correct format specifier should be
> %u instead of %d.
>
> Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com>
> ---
> tools/net/ynl/samples/page-pool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next] ynl: samples: Fix the wrong format specifier
https://git.kernel.org/netdev/net-next/c/a8c300ccd2e7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-11-14 2:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-12 8:39 [PATCH] ynl: samples: Fix the wrong format specifier Luo Yifan
2024-11-12 9:50 ` Donald Hunter
2024-11-12 16:02 ` Jakub Kicinski
2024-11-13 1:11 ` [PATCH net-next] " Luo Yifan
2024-11-13 10:52 ` Simon Horman
2024-11-14 2:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox