public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>,
	Nilesh Javali <njavali@marvell.com>,
	Manish Rangankar <mrangankar@marvell.com>,
	GR-QLogic-Storage-Upstream@marvell.com,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 05/21] scsi: bnx2i: Use kthread_create_on_cpu()
Date: Tue, 12 Nov 2024 15:22:29 +0100	[thread overview]
Message-ID: <20241112142248.20503-6-frederic@kernel.org> (raw)
In-Reply-To: <20241112142248.20503-1-frederic@kernel.org>

Use the proper API instead of open coding it.

However it looks like bnx2i_percpu_io_thread() kthread could be
replaced by the use of a high prio workqueue instead.

Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
 drivers/scsi/bnx2i/bnx2i_init.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
index 872ad37e2a6e..cecc3a026762 100644
--- a/drivers/scsi/bnx2i/bnx2i_init.c
+++ b/drivers/scsi/bnx2i/bnx2i_init.c
@@ -415,14 +415,11 @@ static int bnx2i_cpu_online(unsigned int cpu)
 
 	p = &per_cpu(bnx2i_percpu, cpu);
 
-	thread = kthread_create_on_node(bnx2i_percpu_io_thread, (void *)p,
-					cpu_to_node(cpu),
-					"bnx2i_thread/%d", cpu);
+	thread = kthread_create_on_cpu(bnx2i_percpu_io_thread, (void *)p,
+				       cpu, "bnx2i_thread/%d");
 	if (IS_ERR(thread))
 		return PTR_ERR(thread);
 
-	/* bind thread to the cpu */
-	kthread_bind(thread, cpu);
 	p->iothread = thread;
 	wake_up_process(thread);
 	return 0;
-- 
2.46.0


  parent reply	other threads:[~2024-11-12 14:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12 14:22 [PATCH 00/21] kthread: Introduce preferred affinity v5 Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 01/21] arm/bL_switcher: Use kthread_run_on_cpu() Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 02/21] x86/resctrl: " Frederic Weisbecker
2024-11-12 22:00   ` Fenghua Yu
2024-11-12 14:22 ` [PATCH 03/21] firmware: stratix10-svc: " Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 04/21] scsi: bnx2fc: Use kthread_create_on_cpu() Frederic Weisbecker
2024-11-12 14:22 ` Frederic Weisbecker [this message]
2024-11-12 14:22 ` [PATCH 06/21] scsi: qedi: " Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 07/21] soc/qman: test: Use kthread_run_on_cpu() Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 08/21] kallsyms: " Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 09/21] lib: test_objpool: " Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 10/21] net: pktgen: Use kthread_create_on_cpu() Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 11/21] arm64: Keep first mismatched 32bits el0 capable CPU online through its callbacks Frederic Weisbecker
2024-11-28 16:26   ` Will Deacon
2024-11-29 22:15     ` Frederic Weisbecker
2024-12-09 16:23       ` Will Deacon
2024-11-12 14:22 ` [PATCH 12/21] sched,arm64: Handle CPU isolation on last resort fallback rq selection Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 13/21] kthread: Make sure kthread hasn't started while binding it Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 14/21] kthread: Default affine kthread to its preferred NUMA node Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 15/21] mm: Create/affine kcompactd to its preferred node Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 16/21] mm: Create/affine kswapd " Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 17/21] kthread: Implement preferred affinity Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 18/21] rcu: Use kthread preferred affinity for RCU boost Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 19/21] kthread: Unify kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic format Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 20/21] treewide: Introduce kthread_run_worker[_on_cpu]() Frederic Weisbecker
2024-11-12 14:22 ` [PATCH 21/21] rcu: Use kthread preferred affinity for RCU exp kworkers Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241112142248.20503-6-frederic@kernel.org \
    --to=frederic@kernel.org \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mrangankar@marvell.com \
    --cc=njavali@marvell.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox