From: Ian Rogers <irogers@google.com>
To: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"Andi Kleen" <ak@linux.intel.com>,
"Ahelenia Ziemiańska" <nabijaczleweli@nabijaczleweli.xyz>,
"Chen Ni" <nichen@iscas.ac.cn>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 0/3] Prefer evsel over evsel->core.idx
Date: Thu, 14 Nov 2024 15:07:10 -0800 [thread overview]
Message-ID: <20241114230713.330701-1-irogers@google.com> (raw)
James Clark's patches fixing evsel->core.idx [1] reminded me that we
pass the int value around unnecessarily. Passing the evsel avoids
issues if the evlist is reordered but paired with sanitizers we can
also know when something is used when it shouldn't be. These patches
do some initial work reducing the use of evsel->core.idx or reducing
the API to pass evsels and not their interior index.
[1] https://lore.kernel.org/lkml/20241114160450.295844-2-james.clark@linaro.org/
Ian Rogers (3):
perf stream: Use evsel rather than evsel->idx
perf values: Use evsel rather than evsel->idx
perf annotate: Prefer passing evsel to evsel->core.idx
tools/perf/builtin-diff.c | 4 +-
tools/perf/builtin-report.c | 4 +-
tools/perf/builtin-top.c | 4 +-
tools/perf/ui/browsers/annotate.c | 2 +-
tools/perf/util/annotate.c | 32 +++++----
tools/perf/util/annotate.h | 20 +++---
tools/perf/util/stream.c | 7 +-
tools/perf/util/stream.h | 10 +--
tools/perf/util/values.c | 106 +++++++++++++-----------------
tools/perf/util/values.h | 9 +--
10 files changed, 90 insertions(+), 108 deletions(-)
--
2.47.0.338.g60cca15819-goog
next reply other threads:[~2024-11-14 23:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 23:07 Ian Rogers [this message]
2024-11-14 23:07 ` [PATCH v1 1/3] perf stream: Use evsel rather than evsel->idx Ian Rogers
2024-11-14 23:07 ` [PATCH v1 2/3] perf values: " Ian Rogers
2024-11-14 23:07 ` [PATCH v1 3/3] perf annotate: Prefer passing evsel to evsel->core.idx Ian Rogers
2024-12-20 19:50 ` Arnaldo Carvalho de Melo
2024-11-18 10:18 ` [PATCH v1 0/3] Prefer evsel over evsel->core.idx James Clark
2024-12-14 0:13 ` Namhyung Kim
2024-12-20 18:57 ` Ian Rogers
2024-12-20 19:45 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114230713.330701-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=namhyung@kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).