From: Breno Leitao <leitao@debian.org>
To: Jakub Kicinski <kuba@kernel.org>, stefan.wiehler@nokia.com
Cc: "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH net v2] ipmr: Fix access to mfc_cache_list without lock held
Date: Fri, 15 Nov 2024 01:16:27 -0800 [thread overview]
Message-ID: <20241115-frisky-mahogany-mouflon-19fc5b@leitao> (raw)
In-Reply-To: <20241114070308.79021413@kernel.org>
On Thu, Nov 14, 2024 at 07:03:08AM -0800, Jakub Kicinski wrote:
> On Thu, 14 Nov 2024 00:55:57 -0800 Breno Leitao wrote:
> > On Wed, Nov 13, 2024 at 07:10:23PM -0800, Jakub Kicinski wrote:
> > > On Fri, 08 Nov 2024 06:08:36 -0800 Breno Leitao wrote:
> > > > Accessing `mr_table->mfc_cache_list` is protected by an RCU lock. In the
> > > > following code flow, the RCU read lock is not held, causing the
> > > > following error when `RCU_PROVE` is not held. The same problem might
> > > > show up in the IPv6 code path.
> > >
> > > good start, I hope someone can fix the gazillion warnings the CI
> > > is hitting on the table accesses :)
> >
> > If you have an updated list, I'd be happy to take a look.
> >
> > Last time, all the problems I found were being discussed upstream
> > already. I am wondering if they didn't land upstream, or, if you have
> > warnings that are not being currently fixed.
>
> https://netdev-3.bots.linux.dev/vmksft-forwarding-dbg/results/859762/82-router-multicast-sh/stderr
This one seems to be discussed in the following thread already.
https://lore.kernel.org/all/20241017174109.85717-1-stefan.wiehler@nokia.com/
next prev parent reply other threads:[~2024-11-15 9:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 14:08 [PATCH net v2] ipmr: Fix access to mfc_cache_list without lock held Breno Leitao
2024-11-11 1:00 ` David Ahern
2024-11-14 3:10 ` Jakub Kicinski
2024-11-14 8:55 ` Breno Leitao
2024-11-14 15:03 ` Jakub Kicinski
2024-11-15 9:16 ` Breno Leitao [this message]
2024-11-15 16:00 ` Jakub Kicinski
2024-11-15 16:07 ` Stefan Wiehler
2024-11-15 16:55 ` Paolo Abeni
2024-11-15 19:16 ` Jakub Kicinski
2024-11-20 9:54 ` Paolo Abeni
2024-11-14 3:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115-frisky-mahogany-mouflon-19fc5b@leitao \
--to=leitao@debian.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stefan.wiehler@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox