public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org, bp@alien8.de
Cc: x86@kernel.org, thomas.lendacky@amd.com, Baoquan He <bhe@redhat.com>
Subject: [PATCH 1/3] x86/ioremap: introduce helper to check if physical address is in setup_data
Date: Fri, 15 Nov 2024 09:21:29 +0800	[thread overview]
Message-ID: <20241115012131.509226-2-bhe@redhat.com> (raw)
In-Reply-To: <20241115012131.509226-1-bhe@redhat.com>

Functions memremap_is_setup_data() and early_memremap_is_setup_data()
share completely the same process and handling, except of the
different memremap/unmap invocations.

Add helper __memremap_is_setup_data() to extract the common part,
parameter 'early' is used to decide what kind of memremap/unmap
APIs are called.

Signed-off-by: Baoquan He <bhe@redhat.com>
---
 arch/x86/mm/ioremap.c | 81 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 81 insertions(+)

diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index 8d29163568a7..5ef6182db630 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -628,6 +628,87 @@ static bool memremap_is_efi_data(resource_size_t phys_addr,
 	return false;
 }
 
+#define SD_SIZE sizeof(struct setup_data)
+/*
+ * Examine the physical address to determine if it is boot data by checking
+ * it against the boot params setup_data chain.
+ */
+static bool __init __memremap_is_setup_data(resource_size_t phys_addr,
+						bool early)
+{
+	struct setup_indirect *indirect;
+	struct setup_data *data;
+	u64 paddr, paddr_next;
+
+	paddr = boot_params.hdr.setup_data;
+	while (paddr) {
+		unsigned int len, size;
+
+		if (phys_addr == paddr)
+			return true;
+
+		if (early)
+			data = early_memremap_decrypted(paddr, SD_SIZE);
+		else
+			data = memremap(paddr, SD_SIZE,
+					MEMREMAP_WB | MEMREMAP_DEC);
+		if (!data) {
+			pr_warn("failed to memremap setup_data entry\n");
+			return false;
+		}
+
+		size = SD_SIZE;
+
+		paddr_next = data->next;
+		len = data->len;
+
+		if ((phys_addr > paddr) &&
+		    (phys_addr < (paddr + SD_SIZE + len))) {
+			if (early)
+				early_memunmap(data, SD_SIZE);
+			else
+				memunmap(data);
+			return true;
+		}
+
+		if (data->type == SETUP_INDIRECT) {
+			size += len;
+			if (early) {
+				early_memunmap(data, SD_SIZE);
+				data = early_memremap_decrypted(paddr, size);
+			} else {
+				memunmap(data);
+				data = memremap(paddr, size,
+						MEMREMAP_WB | MEMREMAP_DEC);
+			}
+			if (!data) {
+				pr_warn("failed to memremap indirect setup_data\n");
+				return false;
+			}
+
+			indirect = (struct setup_indirect *)data->data;
+
+			if (indirect->type != SETUP_INDIRECT) {
+				paddr = indirect->addr;
+				len = indirect->len;
+			}
+		}
+
+		if (early)
+			early_memunmap(data, size);
+		else
+			memunmap(data);
+
+		if ((phys_addr > paddr) && (phys_addr < (paddr + len)))
+			return true;
+
+		paddr = paddr_next;
+	}
+
+	return false;
+}
+#undef SD_SIZE
+
 /*
  * Examine the physical address to determine if it is boot data by checking
  * it against the boot params setup_data chain.
-- 
2.41.0


  reply	other threads:[~2024-11-15  1:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-15  1:21 [PATCH 0/3] x86/ioremap: clean up the mess in xxx_is_setup_data Baoquan He
2024-11-15  1:21 ` Baoquan He [this message]
2024-11-15 11:28   ` [tip: x86/mm] x86/ioremap: Introduce helper to check if physical address is in setup_data tip-bot2 for Baoquan He
2024-11-15 14:22   ` [PATCH 1/3] x86/ioremap: introduce " Tom Lendacky
2024-11-15 23:25     ` Baoquan He
2024-11-15  1:21 ` [PATCH 2/3] x86/ioremap: use helper to implement xxx_is_setup_data() Baoquan He
2024-11-15 11:28   ` [tip: x86/mm] x86/ioremap: Use " tip-bot2 for Baoquan He
2024-11-15 14:24   ` [PATCH 2/3] x86/ioremap: use " Tom Lendacky
2024-11-16  8:36     ` Ingo Molnar
2024-11-16 13:28       ` Baoquan He
2024-11-15  1:21 ` [PATCH 3/3] x86/mm: clean up unused parameters of functions Baoquan He
2024-11-15 11:28   ` [tip: x86/mm] x86/mm: Clean " tip-bot2 for Baoquan He
2024-11-15 14:27   ` [PATCH 3/3] x86/mm: clean " Tom Lendacky
2024-11-15  1:23 ` [PATCH 0/3] x86/ioremap: clean up the mess in xxx_is_setup_data Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241115012131.509226-2-bhe@redhat.com \
    --to=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox