From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
x86 Maintainers <x86@kernel.org>,
Patryk Wlazlyn <patryk.wlazlyn@linux.intel.com>,
"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v1] cpuidle: Do not return from cpuidle_play_dead() on callback failures
Date: Fri, 15 Nov 2024 18:40:22 +0100 [thread overview]
Message-ID: <20241115174022.GF22801@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJZ5v0jkPb-sgrMfk+KN19+R+ezucssHKUzfJZ74Qw1Ned6gaw@mail.gmail.com>
On Fri, Nov 15, 2024 at 02:25:23PM +0100, Rafael J. Wysocki wrote:
> > I mean, something like:
> >
> > if (drv->states[i].enter_dead && !drv->states[i].enter_dead(dev, i))
> > panic("Dead CPU walking...");
> >
> > is 'fun' but not very useful.
>
> The panic would be hard to debug if it ever triggers I'm afraid and
> there is the fallback to HLT in the caller.
I was being facetious, removing the return value and simply calling them
all in reverse order is fine.
prev parent reply other threads:[~2024-11-15 17:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 17:46 [PATCH v1] cpuidle: Do not return from cpuidle_play_dead() on callback failures Rafael J. Wysocki
2024-11-15 3:22 ` Mario Limonciello
2024-11-15 10:14 ` Peter Zijlstra
2024-11-15 12:46 ` Rafael J. Wysocki
2024-11-15 12:55 ` Peter Zijlstra
2024-11-15 13:25 ` Rafael J. Wysocki
2024-11-15 17:40 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115174022.GF22801@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=artem.bityutskiy@linux.intel.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=patryk.wlazlyn@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox