From: Lothar Rubusch <l.rubusch@gmail.com>
To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
eraretuya@gmail.com, l.rubusch@gmail.com
Subject: [PATCH v2 06/22] iio: accel: adxl345: add function to switch measuring
Date: Sun, 17 Nov 2024 18:26:35 +0000 [thread overview]
Message-ID: <20241117182651.115056-7-l.rubusch@gmail.com> (raw)
In-Reply-To: <20241117182651.115056-1-l.rubusch@gmail.com>
Replace the powerup / powerdown functions by a generic function to put
the sensor in STANDBY, or MEASURE mode. This is needed for several
features of the accelerometer. It allows to change e.g. FIFO settings.
Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
---
drivers/iio/accel/adxl345_core.c | 53 ++++++++++++++++++++++----------
1 file changed, 37 insertions(+), 16 deletions(-)
diff --git a/drivers/iio/accel/adxl345_core.c b/drivers/iio/accel/adxl345_core.c
index 926e397678..81688a9eaf 100644
--- a/drivers/iio/accel/adxl345_core.c
+++ b/drivers/iio/accel/adxl345_core.c
@@ -138,6 +138,39 @@ static int adxl345_write_raw_get_fmt(struct iio_dev *indio_dev,
}
}
+/**
+ * adxl345_set_measure_en() - Enable and disable measuring.
+ *
+ * @st: The device data.
+ * @en: Enable measurements, else standby mode.
+ *
+ * For lowest power operation, standby mode can be used. In standby mode,
+ * current consumption is supposed to be reduced to 0.1uA (typical). In this
+ * mode no measurements are made. Placing the device into standby mode
+ * preserves the contents of FIFO.
+ *
+ * Return: Returns 0 if successful, or a negative error value.
+ */
+static int adxl345_set_measure_en(struct adxl34x_state *st, bool en)
+{
+ unsigned int val = 0;
+ int ret;
+
+ val = (en) ? ADXL345_POWER_CTL_MEASURE : ADXL345_POWER_CTL_STANDBY;
+ ret = regmap_write(st->regmap, ADXL345_REG_POWER_CTL, val);
+ if (ret)
+ return -EINVAL;
+
+ return 0;
+}
+
+static void adxl345_powerdown(void *ptr)
+{
+ struct adxl34x_state *st = ptr;
+
+ adxl345_set_measure_en(st, false);
+}
+
static IIO_CONST_ATTR_SAMP_FREQ_AVAIL(
"0.09765625 0.1953125 0.390625 0.78125 1.5625 3.125 6.25 12.5 25 50 100 200 400 800 1600 3200"
);
@@ -158,16 +191,6 @@ static const struct iio_info adxl345_info = {
.write_raw_get_fmt = adxl345_write_raw_get_fmt,
};
-static int adxl345_powerup(void *regmap)
-{
- return regmap_write(regmap, ADXL345_REG_POWER_CTL, ADXL345_POWER_CTL_MEASURE);
-}
-
-static void adxl345_powerdown(void *regmap)
-{
- regmap_write(regmap, ADXL345_REG_POWER_CTL, ADXL345_POWER_CTL_STANDBY);
-}
-
/**
* adxl345_core_probe() - probe and setup for the adxl345 accelerometer,
* also covers the adxl375 and adxl346 accelerometer
@@ -242,14 +265,12 @@ int adxl345_core_probe(struct device *dev, struct regmap *regmap,
return dev_err_probe(dev, -ENODEV, "Invalid device ID: %x, expected %x\n",
regval, ADXL345_DEVID);
- /* Enable measurement mode */
- ret = adxl345_powerup(st->regmap);
+ ret = devm_add_action_or_reset(dev, adxl345_powerdown, st);
if (ret < 0)
- return dev_err_probe(dev, ret, "Failed to enable measurement mode\n");
+ return dev_err_probe(dev, ret, "Failed to add action or reset\n");
- ret = devm_add_action_or_reset(dev, adxl345_powerdown, st->regmap);
- if (ret < 0)
- return ret;
+ /* Enable measurement mode */
+ adxl345_set_measure_en(st, true);
return devm_iio_device_register(dev, indio_dev);
}
--
2.39.5
next prev parent reply other threads:[~2024-11-17 18:28 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-17 18:26 [PATCH v2 00/22] iio: accel: adxl345: add FIFO operating with IRQ triggered watermark events Lothar Rubusch
2024-11-17 18:26 ` [PATCH v2 01/22] iio: accel: adxl345: fix comment on probe Lothar Rubusch
2024-11-24 17:57 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 02/22] iio: accel: adxl345: rename variable data to st Lothar Rubusch
2024-11-17 18:26 ` [PATCH v2 03/22] iio: accel: adxl345: rename struct adxl34x_state Lothar Rubusch
2024-11-24 18:01 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 04/22] iio: accel: adxl345: rename to adxl34x_channels Lothar Rubusch
2024-11-24 18:02 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 05/22] iio: accel: adxl345: measure right-justified Lothar Rubusch
2024-11-24 18:07 ` Jonathan Cameron
2024-11-26 13:51 ` Lothar Rubusch
2024-11-26 17:44 ` Jonathan Cameron
2024-11-17 18:26 ` Lothar Rubusch [this message]
2024-11-24 18:10 ` [PATCH v2 06/22] iio: accel: adxl345: add function to switch measuring Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 07/22] iio: accel: adxl345: initialize IRQ number Lothar Rubusch
2024-11-24 18:14 ` Jonathan Cameron
2024-11-26 16:16 ` Lothar Rubusch
2024-11-26 17:49 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 08/22] iio: accel: adxl345: initialize FIFO delay value for SPI Lothar Rubusch
2024-11-24 18:16 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 09/22] iio: accel: adxl345: unexpose private defines Lothar Rubusch
2024-11-24 18:22 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 10/22] iio: accel: adxl345: set interrupt line to INT1 Lothar Rubusch
2024-11-24 18:23 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 11/22] iio: accel: adxl345: import adxl345 general data Lothar Rubusch
2024-11-24 18:31 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 12/22] iio: accel: adxl345: elaborate iio channel definition Lothar Rubusch
2024-11-24 18:34 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 13/22] iio: accel: adxl345: add trigger handler Lothar Rubusch
2024-11-24 18:46 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 14/22] iio: accel: adxl345: read FIFO entries Lothar Rubusch
2024-11-24 18:49 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 15/22] iio: accel: adxl345: reset the FIFO on error Lothar Rubusch
2024-11-24 18:54 ` Jonathan Cameron
2024-11-26 21:53 ` Lothar Rubusch
2024-11-17 18:26 ` [PATCH v2 16/22] iio: accel: adxl345: register trigger ops Lothar Rubusch
2024-11-24 18:56 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 17/22] iio: accel: adxl345: push FIFO data to iio Lothar Rubusch
2024-11-24 18:58 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 18/22] iio: accel: adxl345: start measure at buffer en/disable Lothar Rubusch
2024-11-24 19:00 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 19/22] iio: accel: adxl345: prepare FIFO watermark handling Lothar Rubusch
2024-11-24 19:05 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 20/22] iio: accel: adxl345: use FIFO with watermark IRQ Lothar Rubusch
2024-11-24 19:08 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 21/22] iio: accel: adxl345: sync FIFO reading with sensor Lothar Rubusch
2024-11-24 19:09 ` Jonathan Cameron
2024-11-17 18:26 ` [PATCH v2 22/22] iio: accel: adxl345: add debug printout Lothar Rubusch
2024-11-24 19:11 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241117182651.115056-7-l.rubusch@gmail.com \
--to=l.rubusch@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=eraretuya@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox