* [PATCH] drm/panthor: Fix compilation failure on panthor_fw.c
@ 2024-11-19 16:44 Liviu Dudau
2024-11-20 11:22 ` Karunika Choo
2024-11-20 11:41 ` Boris Brezillon
0 siblings, 2 replies; 4+ messages in thread
From: Liviu Dudau @ 2024-11-19 16:44 UTC (permalink / raw)
To: Boris Brezillon
Cc: Liviu Dudau, Steven Price, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel, Jann Horn
Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path") forgot
to copy the definition of glb_iface when it move one line of code.
Fixes: Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path")
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
---
drivers/gpu/drm/panthor/panthor_fw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
index 4bc52b1b1a286..c807b6ce71bd4 100644
--- a/drivers/gpu/drm/panthor/panthor_fw.c
+++ b/drivers/gpu/drm/panthor/panthor_fw.c
@@ -1133,6 +1133,7 @@ int panthor_fw_post_reset(struct panthor_device *ptdev)
* This is not needed on a slow reset because FW sections are
* re-initialized.
*/
+ struct panthor_fw_global_iface *glb_iface = panthor_fw_get_glb_iface(ptdev);
panthor_fw_update_reqs(glb_iface, req, 0, GLB_HALT);
ret = panthor_fw_start(ptdev);
--
2.47.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panthor: Fix compilation failure on panthor_fw.c
2024-11-19 16:44 [PATCH] drm/panthor: Fix compilation failure on panthor_fw.c Liviu Dudau
@ 2024-11-20 11:22 ` Karunika Choo
2024-11-20 11:41 ` Boris Brezillon
1 sibling, 0 replies; 4+ messages in thread
From: Karunika Choo @ 2024-11-20 11:22 UTC (permalink / raw)
To: Liviu Dudau
Cc: Boris Brezillon, Steven Price, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel, Jann Horn
On Tue, Nov 19, 2024 at 04:44:55PM +0000, Liviu Dudau wrote:
> Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path") forgot
> to copy the definition of glb_iface when it move one line of code.
>
> Fixes: Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path")
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Karunika Choo <karunika.choo@arm.com>
Looks good to me. Build-tested locally. Thanks for catching the mistake
in my previous patch.
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
> index 4bc52b1b1a286..c807b6ce71bd4 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.c
> +++ b/drivers/gpu/drm/panthor/panthor_fw.c
> @@ -1133,6 +1133,7 @@ int panthor_fw_post_reset(struct panthor_device *ptdev)
> * This is not needed on a slow reset because FW sections are
> * re-initialized.
> */
> + struct panthor_fw_global_iface *glb_iface = panthor_fw_get_glb_iface(ptdev);
> panthor_fw_update_reqs(glb_iface, req, 0, GLB_HALT);
>
> ret = panthor_fw_start(ptdev);
> --
> 2.47.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panthor: Fix compilation failure on panthor_fw.c
2024-11-19 16:44 [PATCH] drm/panthor: Fix compilation failure on panthor_fw.c Liviu Dudau
2024-11-20 11:22 ` Karunika Choo
@ 2024-11-20 11:41 ` Boris Brezillon
2024-11-20 11:49 ` Liviu Dudau
1 sibling, 1 reply; 4+ messages in thread
From: Boris Brezillon @ 2024-11-20 11:41 UTC (permalink / raw)
To: Liviu Dudau
Cc: Steven Price, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, dri-devel, linux-kernel, Jann Horn
On Tue, 19 Nov 2024 16:44:55 +0000
Liviu Dudau <liviu.dudau@arm.com> wrote:
> Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path") forgot
> to copy the definition of glb_iface when it move one line of code.
>
> Fixes: Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path")
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Liviu, can you queue this patch to drm-misc if that's not already done?
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
> index 4bc52b1b1a286..c807b6ce71bd4 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.c
> +++ b/drivers/gpu/drm/panthor/panthor_fw.c
> @@ -1133,6 +1133,7 @@ int panthor_fw_post_reset(struct panthor_device *ptdev)
> * This is not needed on a slow reset because FW sections are
> * re-initialized.
> */
> + struct panthor_fw_global_iface *glb_iface = panthor_fw_get_glb_iface(ptdev);
> panthor_fw_update_reqs(glb_iface, req, 0, GLB_HALT);
>
> ret = panthor_fw_start(ptdev);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panthor: Fix compilation failure on panthor_fw.c
2024-11-20 11:41 ` Boris Brezillon
@ 2024-11-20 11:49 ` Liviu Dudau
0 siblings, 0 replies; 4+ messages in thread
From: Liviu Dudau @ 2024-11-20 11:49 UTC (permalink / raw)
To: Boris Brezillon
Cc: Steven Price, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, dri-devel, linux-kernel, Jann Horn
On Wed, Nov 20, 2024 at 12:41:25PM +0100, Boris Brezillon wrote:
> On Tue, 19 Nov 2024 16:44:55 +0000
> Liviu Dudau <liviu.dudau@arm.com> wrote:
>
> > Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path") forgot
> > to copy the definition of glb_iface when it move one line of code.
> >
> > Fixes: Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path")
> > Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
>
> Liviu, can you queue this patch to drm-misc if that's not already done?
Thanks, pushed to drm-misc-next, as that's where Karunika's patch landed.
Best regards,
Liviu
>
> > ---
> > drivers/gpu/drm/panthor/panthor_fw.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
> > index 4bc52b1b1a286..c807b6ce71bd4 100644
> > --- a/drivers/gpu/drm/panthor/panthor_fw.c
> > +++ b/drivers/gpu/drm/panthor/panthor_fw.c
> > @@ -1133,6 +1133,7 @@ int panthor_fw_post_reset(struct panthor_device *ptdev)
> > * This is not needed on a slow reset because FW sections are
> > * re-initialized.
> > */
> > + struct panthor_fw_global_iface *glb_iface = panthor_fw_get_glb_iface(ptdev);
> > panthor_fw_update_reqs(glb_iface, req, 0, GLB_HALT);
> >
> > ret = panthor_fw_start(ptdev);
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-20 11:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-19 16:44 [PATCH] drm/panthor: Fix compilation failure on panthor_fw.c Liviu Dudau
2024-11-20 11:22 ` Karunika Choo
2024-11-20 11:41 ` Boris Brezillon
2024-11-20 11:49 ` Liviu Dudau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox