From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sean Rhodes <sean@starlabs.systems>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] drivers/card_reader/rtsx_usb: Restore interrupt based detection
Date: Tue, 19 Nov 2024 02:24:41 +0100 [thread overview]
Message-ID: <2024111917-anyplace-mop-47b2@gregkh> (raw)
In-Reply-To: <20241118195201.39007-1-sean@starlabs.systems>
On Mon, Nov 18, 2024 at 07:52:01PM +0000, Sean Rhodes wrote:
> This commit reintroduces interrupt-based card detection previously
> used in the rts5139 driver. This functionality was removed in commit
> 00d8521dcd23 ("staging: remove rts5139 driver code").
>
> Reintroducing this mechanism fixes presence detection for certain card
> readers, which with the current driver, will taken approximately 20
> seconds to enter S3 as `mmc_rescan` has to be frozen.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> ---
> drivers/misc/cardreader/rtsx_usb.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
So this fixes the referenced commit? If so, shouldn't that get a Fixes:
tag and cc: stable if needed?
thanks,
greg k-h
prev parent reply other threads:[~2024-11-19 1:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 19:52 [PATCH] drivers/card_reader/rtsx_usb: Restore interrupt based detection Sean Rhodes
2024-11-19 1:24 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024111917-anyplace-mop-47b2@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sean@starlabs.systems \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox