From: Carlos Llamas <cmllamas@google.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <brauner@kernel.org>,
"Carlos Llamas" <cmllamas@google.com>,
"Suren Baghdasaryan" <surenb@google.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: [PATCH v4 8/9] binder: propagate vm_insert_page() errors
Date: Tue, 19 Nov 2024 18:32:41 +0000 [thread overview]
Message-ID: <20241119183250.3497547-9-cmllamas@google.com> (raw)
In-Reply-To: <20241119183250.3497547-1-cmllamas@google.com>
Instead of always overriding errors with -ENOMEM, propagate the specific
error code returned by vm_insert_page(). This allows for more accurate
error logs and handling.
Cc: Suren Baghdasaryan <surenb@google.com>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
drivers/android/binder_alloc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
index f5dbaf1d7d65..aea35d475ee8 100644
--- a/drivers/android/binder_alloc.c
+++ b/drivers/android/binder_alloc.c
@@ -339,7 +339,6 @@ static int binder_install_single_page(struct binder_alloc *alloc,
__free_page(page);
pr_err("%d: %s failed to insert page at offset %lx with %d\n",
alloc->pid, __func__, addr - alloc->vm_start, ret);
- ret = -ENOMEM;
break;
}
out:
--
2.47.0.338.g60cca15819-goog
next prev parent reply other threads:[~2024-11-19 18:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 18:32 [PATCH v4 0/9] binder: faster page installations Carlos Llamas
2024-11-19 18:32 ` [PATCH v4 1/9] Revert "binder: switch alloc->mutex to spinlock_t" Carlos Llamas
2024-11-19 18:32 ` [PATCH v4 2/9] binder: concurrent page installation Carlos Llamas
2024-11-19 18:32 ` [PATCH v4 3/9] binder: select correct nid for pages in LRU Carlos Llamas
2024-11-19 18:32 ` [PATCH v4 4/9] binder: remove struct binder_lru_page Carlos Llamas
2024-11-19 19:10 ` Matthew Wilcox
2024-11-19 20:00 ` Greg Kroah-Hartman
2024-11-19 20:16 ` Carlos Llamas
2024-11-20 2:45 ` Matthew Wilcox
2024-11-21 5:56 ` Carlos Llamas
2024-11-19 18:32 ` [PATCH v4 5/9] binder: replace alloc->vma with alloc->mapped Carlos Llamas
2024-11-19 18:32 ` [PATCH v4 6/9] binder: rename alloc->buffer to vm_start Carlos Llamas
2024-11-19 18:32 ` [PATCH v4 7/9] binder: use per-vma lock in page installation Carlos Llamas
2024-11-19 18:32 ` Carlos Llamas [this message]
2024-11-22 15:49 ` [PATCH v4 8/9] binder: propagate vm_insert_page() errors Suren Baghdasaryan
2024-11-19 18:32 ` [PATCH v4 9/9] binder: use per-vma lock in page reclaiming Carlos Llamas
2024-11-22 16:12 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241119183250.3497547-9-cmllamas@google.com \
--to=cmllamas@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox