From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ADD11D3566; Tue, 19 Nov 2024 20:38:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732048693; cv=none; b=sN4L4nFR+I2BzAXdAeAdbeNXrIbG2C5/pIp1juRfUIWmmxmkn77Z3OwPVKyCFaBcq8vqU+amY8gVaRFAlQ2jwXsYeJF+wM89Tunj+/iDpFw2sp6GWLp5FFKaf3ndyFRlgY5NBRpWc/ijmBeoTS8PJ6WhbwAAQCBlwAzHg98LJ+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732048693; c=relaxed/simple; bh=aZtx8D0JIDJUy4jb6paGGJ/YMK9y9mdX3qt+a6Plzbw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UaR8W2PRDDoacaYXWZHvMSCnD6cNgBGBxm5XWnpb8c4K8ngIU1omD8g2pBVb9hL9HdVuZjYDRjMdPcHdvQ9SZUFIHRtn/g0u3GLpyVQVLDjHso6Is/oITxr5df/Nprw1L0p5XIf4tzTA2ZGxmmN3iXzQKbBjdO4ejB+PXclR/3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bqgdvrBa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bqgdvrBa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FDC1C4CECF; Tue, 19 Nov 2024 20:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732048692; bh=aZtx8D0JIDJUy4jb6paGGJ/YMK9y9mdX3qt+a6Plzbw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bqgdvrBaiDxMyjQzGHu5p8KD0C93igpPKRnUy5UtfEkVZeMzkIQnh6cOad/ipuMEy njpfahWj2R+Pw7cFV/WOF3ln/QTjXH6a10DMilFsgRWhnLiymRWLkgI4WHjk7UWhVO t3SicS6vDAbW1mWdeQbBEPdaPSutxU3lpYTvB+wylx3hxuogimYFLPm2J+H/cv25CB ya04g52bgAmigcw7PCCBUL/QtnTsn1pWHVHOKQZM4cor/+Kdsrr1gXdNn+XJ4IDSdd HY5mKjOk90Yh8I/NZniAmGJGWiWuzfbser0fX1fvvnhQUWi6aetB+obxHsJ8dDzcR+ 7ATtWmfHSb1uw== Date: Tue, 19 Nov 2024 12:38:08 -0800 From: Josh Poimboeuf To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Marcelo Tosatti , Yair Podemsky , Daniel Wagner , Petr Tesarik Subject: Re: [RFC PATCH v3 01/15] objtool: Make validate_call() recognize indirect calls to pv_ops[] Message-ID: <20241119203808.rb2yfqbuin35iye3@jpoimboe> References: <20241119153502.41361-1-vschneid@redhat.com> <20241119153502.41361-2-vschneid@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241119153502.41361-2-vschneid@redhat.com> On Tue, Nov 19, 2024 at 04:34:48PM +0100, Valentin Schneider wrote: > call_dest_name() does not get passed the file pointer of validate_call(), > which means its invocation of insn_reloc() will always return NULL. Make it > take a file pointer. > > While at it, make sure call_dest_name() uses arch_dest_reloc_offset(), > otherwise it gets the pv_ops[] offset wrong. > > Fabricating an intentional warning shows the change; previously: > > vmlinux.o: warning: objtool: __flush_tlb_all_noinstr+0x4: call to {dynamic}() leaves .noinstr.text section > > now: > > vmlinux.o: warning: objtool: __flush_tlb_all_noinstr+0x4: call to pv_ops[1]() leaves .noinstr.text section > > Signed-off-by: Valentin Schneider Acked-by: Josh Poimboeuf -- Josh