* [PATCH 0/1] Removed hard-coded string by using the str_true_false() helper
@ 2024-11-20 9:30 Paolo Perego
2024-11-20 9:30 ` [PATCH 1/1] Remove hard-coded strings by using the helper functions str_true_false() Paolo Perego
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Perego @ 2024-11-20 9:30 UTC (permalink / raw)
To: dri-devel, linux-fbdev, linux-staging, linux-kernel
Cc: Greg Kroah-Hartman, Thomas Zimmermann, Dan Carpenter, Lee Jones,
Jani Nikula, Paolo Perego, Riyan Dhiman
Hi everyone, this is my very first trivial contribution to the Linux kernel and
I started from a very basic task.
As the subject suggests I removed hard-coded string by using str_true_false()
helper.
Paolo Perego (1):
Remove hard-coded strings by using the helper functions
str_true_false()
drivers/staging/fbtft/fb_ssd1351.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.47.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] Remove hard-coded strings by using the helper functions str_true_false()
2024-11-20 9:30 [PATCH 0/1] Removed hard-coded string by using the str_true_false() helper Paolo Perego
@ 2024-11-20 9:30 ` Paolo Perego
2024-11-20 11:20 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Perego @ 2024-11-20 9:30 UTC (permalink / raw)
To: dri-devel, linux-fbdev, linux-staging, linux-kernel
Cc: Greg Kroah-Hartman, Thomas Zimmermann, Dan Carpenter, Lee Jones,
Jani Nikula, Paolo Perego, Riyan Dhiman
Signed-off-by: Paolo Perego <pperego@suse.de>
---
drivers/staging/fbtft/fb_ssd1351.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c
index f6db2933ebba..6736b09b2f45 100644
--- a/drivers/staging/fbtft/fb_ssd1351.c
+++ b/drivers/staging/fbtft/fb_ssd1351.c
@@ -6,6 +6,7 @@
#include <linux/init.h>
#include <linux/spi/spi.h>
#include <linux/delay.h>
+#include <linux/string_choices.h>
#include "fbtft.h"
@@ -162,7 +163,7 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
static int blank(struct fbtft_par *par, bool on)
{
fbtft_par_dbg(DEBUG_BLANK, par, "(%s=%s)\n",
- __func__, on ? "true" : "false");
+ __func__, str_true_false(on));
if (on)
write_reg(par, 0xAE);
else
--
2.47.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Remove hard-coded strings by using the helper functions str_true_false()
2024-11-20 9:30 ` [PATCH 1/1] Remove hard-coded strings by using the helper functions str_true_false() Paolo Perego
@ 2024-11-20 11:20 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-11-20 11:20 UTC (permalink / raw)
To: Paolo Perego
Cc: dri-devel, linux-fbdev, linux-staging, linux-kernel,
Greg Kroah-Hartman, Thomas Zimmermann, Lee Jones, Jani Nikula,
Riyan Dhiman
On Wed, Nov 20, 2024 at 10:30:20AM +0100, Paolo Perego wrote:
> Signed-off-by: Paolo Perego <pperego@suse.de>
You need to have a subsystem prefix in the subject. The subject is probably too
long as well. You need to have a commit message.
Otherwise, fine.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-20 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-20 9:30 [PATCH 0/1] Removed hard-coded string by using the str_true_false() helper Paolo Perego
2024-11-20 9:30 ` [PATCH 1/1] Remove hard-coded strings by using the helper functions str_true_false() Paolo Perego
2024-11-20 11:20 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox