* drivers/soc/fsl/qe/qmc.c:1942 qmc_probe() warn: missing error code 'ret'
@ 2024-11-05 6:46 Dan Carpenter
2024-11-20 9:38 ` [PATCH] soc: fsl: cpm1: qmc: Fix qmc_probe() warn missing error code ret Pei Xiao
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2024-11-05 6:46 UTC (permalink / raw)
To: oe-kbuild, Herve Codina
Cc: lkp, oe-kbuild-all, linux-kernel, Christophe Leroy
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 2e1b3cc9d7f790145a80cb705b168f05dab65df2
commit: eb680d563089e55b20cb7730ed881638fe4425b7 soc: fsl: cpm1: qmc: Add support for QUICC Engine (QE) implementation
config: powerpc64-randconfig-r071-20241104 (https://download.01.org/0day-ci/archive/20241105/202411051350.KNy6ZIWA-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 639a7ac648f1e50ccd2556e17d401c04f9cce625)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202411051350.KNy6ZIWA-lkp@intel.com/
smatch warnings:
drivers/soc/fsl/qe/qmc.c:1942 qmc_probe() warn: missing error code 'ret'
vim +/ret +1942 drivers/soc/fsl/qe/qmc.c
3178d58e0b9772 Herve Codina 2023-02-17 1828 static int qmc_probe(struct platform_device *pdev)
3178d58e0b9772 Herve Codina 2023-02-17 1829 {
3178d58e0b9772 Herve Codina 2023-02-17 1830 struct device_node *np = pdev->dev.of_node;
3178d58e0b9772 Herve Codina 2023-02-17 1831 unsigned int nb_chans;
3178d58e0b9772 Herve Codina 2023-02-17 1832 struct qmc *qmc;
3178d58e0b9772 Herve Codina 2023-02-17 1833 int irq;
3178d58e0b9772 Herve Codina 2023-02-17 1834 int ret;
3178d58e0b9772 Herve Codina 2023-02-17 1835
3178d58e0b9772 Herve Codina 2023-02-17 1836 qmc = devm_kzalloc(&pdev->dev, sizeof(*qmc), GFP_KERNEL);
3178d58e0b9772 Herve Codina 2023-02-17 1837 if (!qmc)
3178d58e0b9772 Herve Codina 2023-02-17 1838 return -ENOMEM;
3178d58e0b9772 Herve Codina 2023-02-17 1839
3178d58e0b9772 Herve Codina 2023-02-17 1840 qmc->dev = &pdev->dev;
d23ae9f1815e89 Herve Codina 2024-08-08 1841 qmc->data = of_device_get_match_data(&pdev->dev);
d23ae9f1815e89 Herve Codina 2024-08-08 1842 if (!qmc->data) {
d23ae9f1815e89 Herve Codina 2024-08-08 1843 dev_err(qmc->dev, "Missing match data\n");
d23ae9f1815e89 Herve Codina 2024-08-08 1844 return -EINVAL;
d23ae9f1815e89 Herve Codina 2024-08-08 1845 }
3178d58e0b9772 Herve Codina 2023-02-17 1846 INIT_LIST_HEAD(&qmc->chan_head);
3178d58e0b9772 Herve Codina 2023-02-17 1847
a13bf605342ea9 Herve Codina 2024-08-08 1848 qmc->tsa_serial = devm_tsa_serial_get_byphandle(qmc->dev, np, "fsl,tsa-serial");
a13bf605342ea9 Herve Codina 2024-08-08 1849 if (IS_ERR(qmc->tsa_serial)) {
a13bf605342ea9 Herve Codina 2024-08-08 1850 return dev_err_probe(qmc->dev, PTR_ERR(qmc->tsa_serial),
a13bf605342ea9 Herve Codina 2024-08-08 1851 "Failed to get TSA serial\n");
a13bf605342ea9 Herve Codina 2024-08-08 1852 }
a13bf605342ea9 Herve Codina 2024-08-08 1853
727b3ab490a5f5 Herve Codina 2024-08-08 1854 ret = qmc_init_resources(qmc, pdev);
727b3ab490a5f5 Herve Codina 2024-08-08 1855 if (ret)
727b3ab490a5f5 Herve Codina 2024-08-08 1856 return ret;
3178d58e0b9772 Herve Codina 2023-02-17 1857
3178d58e0b9772 Herve Codina 2023-02-17 1858 /* Parse channels informationss */
3178d58e0b9772 Herve Codina 2023-02-17 1859 ret = qmc_of_parse_chans(qmc, np);
3178d58e0b9772 Herve Codina 2023-02-17 1860 if (ret)
a13bf605342ea9 Herve Codina 2024-08-08 1861 return ret;
3178d58e0b9772 Herve Codina 2023-02-17 1862
3178d58e0b9772 Herve Codina 2023-02-17 1863 nb_chans = qmc_nb_chans(qmc);
3178d58e0b9772 Herve Codina 2023-02-17 1864
3178d58e0b9772 Herve Codina 2023-02-17 1865 /*
3178d58e0b9772 Herve Codina 2023-02-17 1866 * Allocate the buffer descriptor table
3178d58e0b9772 Herve Codina 2023-02-17 1867 * 8 rx and 8 tx descriptors per channel
3178d58e0b9772 Herve Codina 2023-02-17 1868 */
3178d58e0b9772 Herve Codina 2023-02-17 1869 qmc->bd_size = (nb_chans * (QMC_NB_TXBDS + QMC_NB_RXBDS)) * sizeof(cbd_t);
3178d58e0b9772 Herve Codina 2023-02-17 1870 qmc->bd_table = dmam_alloc_coherent(qmc->dev, qmc->bd_size,
3178d58e0b9772 Herve Codina 2023-02-17 1871 &qmc->bd_dma_addr, GFP_KERNEL);
3178d58e0b9772 Herve Codina 2023-02-17 1872 if (!qmc->bd_table) {
3178d58e0b9772 Herve Codina 2023-02-17 1873 dev_err(qmc->dev, "Failed to allocate bd table\n");
a13bf605342ea9 Herve Codina 2024-08-08 1874 return -ENOMEM;
3178d58e0b9772 Herve Codina 2023-02-17 1875 }
3178d58e0b9772 Herve Codina 2023-02-17 1876 memset(qmc->bd_table, 0, qmc->bd_size);
3178d58e0b9772 Herve Codina 2023-02-17 1877
3178d58e0b9772 Herve Codina 2023-02-17 1878 qmc_write32(qmc->scc_pram + QMC_GBL_MCBASE, qmc->bd_dma_addr);
3178d58e0b9772 Herve Codina 2023-02-17 1879
3178d58e0b9772 Herve Codina 2023-02-17 1880 /* Allocate the interrupt table */
3178d58e0b9772 Herve Codina 2023-02-17 1881 qmc->int_size = QMC_NB_INTS * sizeof(u16);
3178d58e0b9772 Herve Codina 2023-02-17 1882 qmc->int_table = dmam_alloc_coherent(qmc->dev, qmc->int_size,
3178d58e0b9772 Herve Codina 2023-02-17 1883 &qmc->int_dma_addr, GFP_KERNEL);
3178d58e0b9772 Herve Codina 2023-02-17 1884 if (!qmc->int_table) {
3178d58e0b9772 Herve Codina 2023-02-17 1885 dev_err(qmc->dev, "Failed to allocate interrupt table\n");
a13bf605342ea9 Herve Codina 2024-08-08 1886 return -ENOMEM;
3178d58e0b9772 Herve Codina 2023-02-17 1887 }
3178d58e0b9772 Herve Codina 2023-02-17 1888 memset(qmc->int_table, 0, qmc->int_size);
3178d58e0b9772 Herve Codina 2023-02-17 1889
3178d58e0b9772 Herve Codina 2023-02-17 1890 qmc->int_curr = qmc->int_table;
3178d58e0b9772 Herve Codina 2023-02-17 1891 qmc_write32(qmc->scc_pram + QMC_GBL_INTBASE, qmc->int_dma_addr);
3178d58e0b9772 Herve Codina 2023-02-17 1892 qmc_write32(qmc->scc_pram + QMC_GBL_INTPTR, qmc->int_dma_addr);
3178d58e0b9772 Herve Codina 2023-02-17 1893
3178d58e0b9772 Herve Codina 2023-02-17 1894 /* Set MRBLR (valid for HDLC only) max MRU + max CRC */
3178d58e0b9772 Herve Codina 2023-02-17 1895 qmc_write16(qmc->scc_pram + QMC_GBL_MRBLR, HDLC_MAX_MRU + 4);
3178d58e0b9772 Herve Codina 2023-02-17 1896
3178d58e0b9772 Herve Codina 2023-02-17 1897 qmc_write16(qmc->scc_pram + QMC_GBL_GRFTHR, 1);
3178d58e0b9772 Herve Codina 2023-02-17 1898 qmc_write16(qmc->scc_pram + QMC_GBL_GRFCNT, 1);
3178d58e0b9772 Herve Codina 2023-02-17 1899
3178d58e0b9772 Herve Codina 2023-02-17 1900 qmc_write32(qmc->scc_pram + QMC_GBL_C_MASK32, 0xDEBB20E3);
3178d58e0b9772 Herve Codina 2023-02-17 1901 qmc_write16(qmc->scc_pram + QMC_GBL_C_MASK16, 0xF0B8);
3178d58e0b9772 Herve Codina 2023-02-17 1902
eb680d563089e5 Herve Codina 2024-08-08 1903 if (qmc_is_qe(qmc)) {
eb680d563089e5 Herve Codina 2024-08-08 1904 /* Zeroed the reserved area */
eb680d563089e5 Herve Codina 2024-08-08 1905 memset_io(qmc->scc_pram + QMC_QE_GBL_RSV_B0_START, 0,
eb680d563089e5 Herve Codina 2024-08-08 1906 QMC_QE_GBL_RSV_B0_SIZE);
eb680d563089e5 Herve Codina 2024-08-08 1907
eb680d563089e5 Herve Codina 2024-08-08 1908 qmc_write32(qmc->scc_pram + QMC_QE_GBL_GCSBASE, qmc->dpram_offset);
eb680d563089e5 Herve Codina 2024-08-08 1909
eb680d563089e5 Herve Codina 2024-08-08 1910 /* Init 'framer parameters' area and set the base addresses */
eb680d563089e5 Herve Codina 2024-08-08 1911 memset_io(qmc->scc_pram + UCC_SLOW_PRAM_SIZE, 0x01, 64);
eb680d563089e5 Herve Codina 2024-08-08 1912 memset_io(qmc->scc_pram + UCC_SLOW_PRAM_SIZE + 64, 0x01, 64);
eb680d563089e5 Herve Codina 2024-08-08 1913 qmc_write16(qmc->scc_pram + QMC_QE_GBL_RX_FRM_BASE,
eb680d563089e5 Herve Codina 2024-08-08 1914 qmc->scc_pram_offset + UCC_SLOW_PRAM_SIZE);
eb680d563089e5 Herve Codina 2024-08-08 1915 qmc_write16(qmc->scc_pram + QMC_QE_GBL_TX_FRM_BASE,
eb680d563089e5 Herve Codina 2024-08-08 1916 qmc->scc_pram_offset + UCC_SLOW_PRAM_SIZE + 64);
eb680d563089e5 Herve Codina 2024-08-08 1917 }
eb680d563089e5 Herve Codina 2024-08-08 1918
2d965e25fa4180 Herve Codina 2023-12-05 1919 ret = qmc_init_tsa(qmc);
3178d58e0b9772 Herve Codina 2023-02-17 1920 if (ret)
a13bf605342ea9 Herve Codina 2024-08-08 1921 return ret;
3178d58e0b9772 Herve Codina 2023-02-17 1922
3178d58e0b9772 Herve Codina 2023-02-17 1923 qmc_write16(qmc->scc_pram + QMC_GBL_QMCSTATE, 0x8000);
3178d58e0b9772 Herve Codina 2023-02-17 1924
3178d58e0b9772 Herve Codina 2023-02-17 1925 ret = qmc_setup_chans(qmc);
3178d58e0b9772 Herve Codina 2023-02-17 1926 if (ret)
a13bf605342ea9 Herve Codina 2024-08-08 1927 return ret;
3178d58e0b9772 Herve Codina 2023-02-17 1928
3178d58e0b9772 Herve Codina 2023-02-17 1929 /* Init interrupts table */
3178d58e0b9772 Herve Codina 2023-02-17 1930 ret = qmc_setup_ints(qmc);
3178d58e0b9772 Herve Codina 2023-02-17 1931 if (ret)
a13bf605342ea9 Herve Codina 2024-08-08 1932 return ret;
a13bf605342ea9 Herve Codina 2024-08-08 1933
eb680d563089e5 Herve Codina 2024-08-08 1934 /* Init SCC (CPM1) or UCC (QE) */
de5fdb7d14b34f Herve Codina 2024-08-08 1935 ret = qmc_init_xcc(qmc);
de5fdb7d14b34f Herve Codina 2024-08-08 1936 if (ret)
a13bf605342ea9 Herve Codina 2024-08-08 1937 return ret;
a13bf605342ea9 Herve Codina 2024-08-08 1938
de5fdb7d14b34f Herve Codina 2024-08-08 1939 /* Set the irq handler */
3178d58e0b9772 Herve Codina 2023-02-17 1940 irq = platform_get_irq(pdev, 0);
3178d58e0b9772 Herve Codina 2023-02-17 1941 if (irq < 0)
de5fdb7d14b34f Herve Codina 2024-08-08 @1942 goto err_exit_xcc;
ret = irq;
3178d58e0b9772 Herve Codina 2023-02-17 1943 ret = devm_request_irq(qmc->dev, irq, qmc_irq_handler, 0, "qmc", qmc);
3178d58e0b9772 Herve Codina 2023-02-17 1944 if (ret < 0)
de5fdb7d14b34f Herve Codina 2024-08-08 1945 goto err_exit_xcc;
3178d58e0b9772 Herve Codina 2023-02-17 1946
3178d58e0b9772 Herve Codina 2023-02-17 1947 /* Enable interrupts */
3178d58e0b9772 Herve Codina 2023-02-17 1948 qmc_write16(qmc->scc_regs + SCC_SCCM,
3178d58e0b9772 Herve Codina 2023-02-17 1949 SCC_SCCE_IQOV | SCC_SCCE_GINT | SCC_SCCE_GUN | SCC_SCCE_GOV);
3178d58e0b9772 Herve Codina 2023-02-17 1950
3178d58e0b9772 Herve Codina 2023-02-17 1951 ret = qmc_finalize_chans(qmc);
3178d58e0b9772 Herve Codina 2023-02-17 1952 if (ret < 0)
3178d58e0b9772 Herve Codina 2023-02-17 1953 goto err_disable_intr;
3178d58e0b9772 Herve Codina 2023-02-17 1954
e49dd637e02589 Herve Codina 2024-08-08 1955 /* Enable transmitter and receiver */
3178d58e0b9772 Herve Codina 2023-02-17 1956 qmc_setbits32(qmc->scc_regs + SCC_GSMRL, SCC_GSMRL_ENR | SCC_GSMRL_ENT);
3178d58e0b9772 Herve Codina 2023-02-17 1957
3178d58e0b9772 Herve Codina 2023-02-17 1958 platform_set_drvdata(pdev, qmc);
3178d58e0b9772 Herve Codina 2023-02-17 1959
ba3b7e4753c5ad Herve Codina 2023-12-05 1960 /* Populate channel related devices */
ba3b7e4753c5ad Herve Codina 2023-12-05 1961 ret = devm_of_platform_populate(qmc->dev);
ba3b7e4753c5ad Herve Codina 2023-12-05 1962 if (ret)
ba3b7e4753c5ad Herve Codina 2023-12-05 1963 goto err_disable_txrx;
ba3b7e4753c5ad Herve Codina 2023-12-05 1964
3178d58e0b9772 Herve Codina 2023-02-17 1965 return 0;
3178d58e0b9772 Herve Codina 2023-02-17 1966
ba3b7e4753c5ad Herve Codina 2023-12-05 1967 err_disable_txrx:
ba3b7e4753c5ad Herve Codina 2023-12-05 1968 qmc_setbits32(qmc->scc_regs + SCC_GSMRL, 0);
ba3b7e4753c5ad Herve Codina 2023-12-05 1969
3178d58e0b9772 Herve Codina 2023-02-17 1970 err_disable_intr:
3178d58e0b9772 Herve Codina 2023-02-17 1971 qmc_write16(qmc->scc_regs + SCC_SCCM, 0);
3178d58e0b9772 Herve Codina 2023-02-17 1972
de5fdb7d14b34f Herve Codina 2024-08-08 1973 err_exit_xcc:
de5fdb7d14b34f Herve Codina 2024-08-08 1974 qmc_exit_xcc(qmc);
3178d58e0b9772 Herve Codina 2023-02-17 1975 return ret;
3178d58e0b9772 Herve Codina 2023-02-17 1976 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] soc: fsl: cpm1: qmc: Fix qmc_probe() warn missing error code ret
2024-11-05 6:46 drivers/soc/fsl/qe/qmc.c:1942 qmc_probe() warn: missing error code 'ret' Dan Carpenter
@ 2024-11-20 9:38 ` Pei Xiao
2024-11-20 11:05 ` Herve Codina
2024-11-20 11:05 ` Christophe Leroy
0 siblings, 2 replies; 5+ messages in thread
From: Pei Xiao @ 2024-11-20 9:38 UTC (permalink / raw)
To: herve.codina, qiang.zhao, christophe.leroy, linuxppc-dev,
linux-kernel
Cc: dan.carpenter, xiaopeitux, Pei Xiao
platform_get_irq() may failed,but ret still equals to 0,
will cacuse qmc_probe() return 0 but fail.
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202411051350.KNy6ZIWA-lkp@intel.com/
Fixes: 3178d58e0b97 ("soc: fsl: cpm1: Add support for QMC")
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
---
drivers/soc/fsl/qe/qmc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
index 19cc581b06d0..a78768cd6007 100644
--- a/drivers/soc/fsl/qe/qmc.c
+++ b/drivers/soc/fsl/qe/qmc.c
@@ -2004,8 +2004,10 @@ static int qmc_probe(struct platform_device *pdev)
/* Set the irq handler */
irq = platform_get_irq(pdev, 0);
- if (irq < 0)
+ if (irq < 0) {
+ ret = -EINVAL;
goto err_exit_xcc;
+ }
ret = devm_request_irq(qmc->dev, irq, qmc_irq_handler, 0, "qmc", qmc);
if (ret < 0)
goto err_exit_xcc;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] soc: fsl: cpm1: qmc: Fix qmc_probe() warn missing error code ret
2024-11-20 9:38 ` [PATCH] soc: fsl: cpm1: qmc: Fix qmc_probe() warn missing error code ret Pei Xiao
@ 2024-11-20 11:05 ` Herve Codina
2024-11-21 0:57 ` Pei Xiao
2024-11-20 11:05 ` Christophe Leroy
1 sibling, 1 reply; 5+ messages in thread
From: Herve Codina @ 2024-11-20 11:05 UTC (permalink / raw)
To: Pei Xiao
Cc: qiang.zhao, christophe.leroy, linuxppc-dev, linux-kernel,
dan.carpenter, xiaopeitux
Hi Pei,
On Wed, 20 Nov 2024 17:38:20 +0800
Pei Xiao <xiaopei01@kylinos.cn> wrote:
> platform_get_irq() may failed,but ret still equals to 0,
> will cacuse qmc_probe() return 0 but fail.
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202411051350.KNy6ZIWA-lkp@intel.com/
> Fixes: 3178d58e0b97 ("soc: fsl: cpm1: Add support for QMC")
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
> drivers/soc/fsl/qe/qmc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index 19cc581b06d0..a78768cd6007 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -2004,8 +2004,10 @@ static int qmc_probe(struct platform_device *pdev)
>
> /* Set the irq handler */
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0)
> + if (irq < 0) {
> + ret = -EINVAL;
> goto err_exit_xcc;
> + }
> ret = devm_request_irq(qmc->dev, irq, qmc_irq_handler, 0, "qmc", qmc);
> if (ret < 0)
> goto err_exit_xcc;
I already send a fix:
https://lore.kernel.org/all/20241105145623.401528-1-herve.codina@bootlin.com/
And it is available in the following PR done by Christophe:
https://lore.kernel.org/all/c3c4961b-fe2a-4fcc-a7a1-f8b5352e09a2@csgroup.eu/
Best regards,
Hervé
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] soc: fsl: cpm1: qmc: Fix qmc_probe() warn missing error code ret
2024-11-20 9:38 ` [PATCH] soc: fsl: cpm1: qmc: Fix qmc_probe() warn missing error code ret Pei Xiao
2024-11-20 11:05 ` Herve Codina
@ 2024-11-20 11:05 ` Christophe Leroy
1 sibling, 0 replies; 5+ messages in thread
From: Christophe Leroy @ 2024-11-20 11:05 UTC (permalink / raw)
To: Pei Xiao, herve.codina, qiang.zhao, linuxppc-dev, linux-kernel
Cc: dan.carpenter, xiaopeitux
Le 20/11/2024 à 10:38, Pei Xiao a écrit :
> [Vous ne recevez pas souvent de courriers de xiaopei01@kylinos.cn. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> platform_get_irq() may failed,but ret still equals to 0,
> will cacuse qmc_probe() return 0 but fail.
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202411051350.KNy6ZIWA-lkp@intel.com/
> Fixes: 3178d58e0b97 ("soc: fsl: cpm1: Add support for QMC")
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
> drivers/soc/fsl/qe/qmc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index 19cc581b06d0..a78768cd6007 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -2004,8 +2004,10 @@ static int qmc_probe(struct platform_device *pdev)
>
> /* Set the irq handler */
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0)
> + if (irq < 0) {
> + ret = -EINVAL;
Why force -EINVAL ?
What if platform_get_irq() returns -EPROBE_DEFER ?
Anyway, this problem is already fixed by
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20241105145623.401528-1-herve.codina@bootlin.com/
which is on its way to mainline.
> goto err_exit_xcc;
> + }
> ret = devm_request_irq(qmc->dev, irq, qmc_irq_handler, 0, "qmc", qmc);
> if (ret < 0)
> goto err_exit_xcc;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] soc: fsl: cpm1: qmc: Fix qmc_probe() warn missing error code ret
2024-11-20 11:05 ` Herve Codina
@ 2024-11-21 0:57 ` Pei Xiao
0 siblings, 0 replies; 5+ messages in thread
From: Pei Xiao @ 2024-11-21 0:57 UTC (permalink / raw)
To: Herve Codina
Cc: qiang.zhao, christophe.leroy, linuxppc-dev, linux-kernel,
dan.carpenter, xiaopeitux
在 2024/11/20 19:05, Herve Codina 写道:
> Hi Pei,
>
> On Wed, 20 Nov 2024 17:38:20 +0800
> Pei Xiao <xiaopei01@kylinos.cn> wrote:
>
>> platform_get_irq() may failed,but ret still equals to 0,
>> will cacuse qmc_probe() return 0 but fail.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
>> Closes: https://lore.kernel.org/r/202411051350.KNy6ZIWA-lkp@intel.com/
>> Fixes: 3178d58e0b97 ("soc: fsl: cpm1: Add support for QMC")
>> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
>> ---
>> drivers/soc/fsl/qe/qmc.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
>> index 19cc581b06d0..a78768cd6007 100644
>> --- a/drivers/soc/fsl/qe/qmc.c
>> +++ b/drivers/soc/fsl/qe/qmc.c
>> @@ -2004,8 +2004,10 @@ static int qmc_probe(struct platform_device *pdev)
>>
>> /* Set the irq handler */
>> irq = platform_get_irq(pdev, 0);
>> - if (irq < 0)
>> + if (irq < 0) {
>> + ret = -EINVAL;
>> goto err_exit_xcc;
>> + }
>> ret = devm_request_irq(qmc->dev, irq, qmc_irq_handler, 0, "qmc", qmc);
>> if (ret < 0)
>> goto err_exit_xcc;
>
> I already send a fix:
> https://lore.kernel.org/all/20241105145623.401528-1-herve.codina@bootlin.com/
>
ok, I'm so sorry for send repeated patch.
Tnanks!
Pei.
> And it is available in the following PR done by Christophe:
> https://lore.kernel.org/all/c3c4961b-fe2a-4fcc-a7a1-f8b5352e09a2@csgroup.eu/
>
> Best regards,
> Hervé
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-11-21 0:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-05 6:46 drivers/soc/fsl/qe/qmc.c:1942 qmc_probe() warn: missing error code 'ret' Dan Carpenter
2024-11-20 9:38 ` [PATCH] soc: fsl: cpm1: qmc: Fix qmc_probe() warn missing error code ret Pei Xiao
2024-11-20 11:05 ` Herve Codina
2024-11-21 0:57 ` Pei Xiao
2024-11-20 11:05 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox