From: Vladimir Oltean <olteanv@gmail.com>
To: Cong Yi <yicong.srfy@foxmail.com>, linux@armlinux.org.uk
Cc: andrew@lunn.ch, hkallweit1@gmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
yicong@kylinos.cn
Subject: Re: [PATCH] net: phylink: Separating two unrelated definitions for improving code readability
Date: Thu, 21 Nov 2024 12:50:44 +0200 [thread overview]
Message-ID: <20241121105044.rbjp2deo5orce3me@skbuf> (raw)
In-Reply-To: <tencent_0F68091620B122436D14BEA497181B17C007@qq.com>
On Wed, Nov 20, 2024 at 05:46:14PM +0800, Cong Yi wrote:
> Hi, Russell King:
>
> Thank you for your reply!
> Yes, as you say, there is no problem with the definitions themselves
> being named. When I just read from Linux-5.4 to 6.6, I thought
> that PCS_STATE_ and PHYLINK_DISABLE- were associated in some way.
> After reading the code carefully, I found that there was no correlation。
> In order to avoid similar confusion, I sent this patch.
For the record, I agree that tying together unrelated constants inside
the same anonymous enum and resetting the counter is a confusing coding
pattern, to which I don't see the benefit. Separating them and giving
names to the enums also gives the opportunity for stronger typing, which
was done here. I think the patch (or at least its idea) is ok.
next prev parent reply other threads:[~2024-11-21 10:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 6:27 [PATCH] net: phylink: Separating two unrelated definitions for improving code readability Cong Yi
2024-11-20 8:48 ` Russell King (Oracle)
2024-11-20 9:46 ` Cong Yi
2024-11-21 10:50 ` Vladimir Oltean [this message]
2024-11-21 11:21 ` Russell King (Oracle)
2024-11-21 11:52 ` Vladimir Oltean
2024-11-21 12:11 ` Russell King (Oracle)
2024-11-21 12:15 ` Vladimir Oltean
2024-11-21 12:26 ` Russell King (Oracle)
2024-11-21 12:47 ` Vladimir Oltean
2024-11-21 12:49 ` Russell King (Oracle)
2024-11-21 12:54 ` Vladimir Oltean
2024-11-21 8:32 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241121105044.rbjp2deo5orce3me@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=yicong.srfy@foxmail.com \
--cc=yicong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox