From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 855F841C79; Thu, 21 Nov 2024 15:38:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732203534; cv=none; b=WPrdy/4x8T77lr0QvhiKFl2UD1gY55lRijjzxYjV00V9ZGXJx+5fv+Z50AiWXEWP1i7D3x3HGG4kpQve7qR2FydvJGRCDoho8UjX6s3899NKIYJD4bMhQ2yrM0wfQ1mWIgfqRMo0gis6NQM22rnIeZpIxuFVQ9/Iehj3GUhAA4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732203534; c=relaxed/simple; bh=F4uZX0i0IDm8hgBs4PE3t3VadtXIOnq01cgjjFA93Rg=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=B7Cfw6ZPDRlyOgtlzcqpKB2/Hibx4VFIC1pM1/T5sOvhgRGrWB7AFTQp77Go8QjpHc0N+BjClD8B2wNiOWRn8PfJP+NsjqJEcRkkXd8QIZt6mpspzIgTiaNzzl5yMvH9daOx89KHl6VpTejoxly3WBCdgbp2kd1EWxx0zap7QXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XvMnt1L8Qz6L75h; Thu, 21 Nov 2024 23:38:26 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 5A838140AB8; Thu, 21 Nov 2024 23:38:50 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 21 Nov 2024 16:38:49 +0100 Date: Thu, 21 Nov 2024 15:38:48 +0000 From: Jonathan Cameron To: CC: , , , , , , , , , , , , , Subject: Re: [PATCH 13/13] rasdaemon: ras-mc-ctl: Update logging of CXL memory module data to align with CXL spec rev 3.1 Message-ID: <20241121153848.0000079a@huawei.com> In-Reply-To: <20241120095923.1891-14-shiju.jose@huawei.com> References: <20241120095923.1891-1-shiju.jose@huawei.com> <20241120095923.1891-14-shiju.jose@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To frapeml500008.china.huawei.com (7.182.85.71) On Wed, 20 Nov 2024 09:59:23 +0000 wrote: > From: Shiju Jose > > CXL spec 3.1 section 8.2.9.2.1.3 Table 8-47, Memory Module Event Record > has updated with following new fields and new info for Device Event Type > and Device Health Information fields. > 1. Validity Flags > 2. Component Identifier > 3. Device Event Sub-Type > > This update modifies ras-mc-ctl to parse and log CXL memory module event > data stored in the RAS SQLite database table, reflecting the > specification changes introduced in revision 3.1. > > Example output, > > ./util/ras-mc-ctl --errors > ... > CXL memory module events: > 1 2024-11-20 00:22:33 +0000 error: memdev=mem0, host=0000:0f:00.0, serial=0x3, \ > log=Fatal, hdr_uuid=fe927475-dd59-4339-a586-79bab113b774, hdr_flags=0x1, , \ > hdr_handle=0x1, hdr_related_handle=0x0, hdr_timestamp=1970-01-01 00:04:38 +0000, \ > hdr_length=128, hdr_maint_op_class=0, hdr_maint_op_sub_class=1, \ > event_type: Temperature Change, event_sub_type: Unsupported Config Data, \ > health_status: 'MAINTENANCE_NEEDED' , 'REPLACEMENT_NEEDED' , \ > media_status: All Data Loss in Event of Power Loss, life_used=8, \ > dirty_shutdown_cnt=33, cor_vol_err_cnt=25, cor_per_err_cnt=45, \ > device_temp=3, add_status=3 \ > component_id:02 74 c5 08 9a 1a 0b fc d2 7e 2f 31 9b 3c 81 4d \ > pldm_entity_id:00 00 00 00 00 00 pldm_resource_id:fc d2 7e 2f > ... > > Signed-off-by: Shiju Jose Feels like there is a lot of duplication in here, but you aren't really making it any worse and maybe it is hard to reduce it. Reviewed-by: Jonathan Cameron