Re: [PATCH v1 2/5] drivers: media: bcm2835-unicam: Allow setting of unpacked formats

Jacopo Mondi
2024-11-22T11:16:58Z

Hi Naush

On Fri, Nov 22, 2024 at 08:41:49AM +0000, Naushir Patuck wrote:
> When matching formats via try_fmt/set_fmt ioctls, test for the unpacked
> formats as well as packed formats. This allows userland clients setup
> unpacking to 16-bits from the 10/12/14-packed CSI2 formats.
>
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
j

> ---
> drivers/media/platform/broadcom/bcm2835-unicam.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
> index 36fb186a0421..d573d4d89881 100644
> --- a/drivers/media/platform/broadcom/bcm2835-unicam.c
> +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
> @@ -547,7 +547,8 @@ unicam_find_format_by_fourcc(u32 fourcc, u32 pad)
> }
>
> for (i = 0; i < num_formats; ++i) {
> - if (formats[i].fourcc == fourcc)
> + if (formats[i].fourcc == fourcc ||
> + formats[i].unpacked_fourcc == fourcc)
> return &formats[i];
> }
>
> --
> 2.34.1
>
>