From: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
To: pkshih@realtek.com, linux-wireless@vger.kernel.org
Cc: kvalo@kernel.org, linux-kernel@vger.kernel.org,
Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
Subject: [PATCH wireless-next] wifi: rtw88: Fix an unreachable code issue
Date: Fri, 22 Nov 2024 17:44:59 +0530 [thread overview]
Message-ID: <20241122121459.134107-1-dheeraj.linuxdev@gmail.com> (raw)
The error handling in rtw8821a_iqk_tx_vdf_true() contained unreachable
code due to tx_fail being explicitly set to false before the error check.
This prevented proper handling of failures and resulted in dead code.
Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
---
drivers/net/wireless/realtek/rtw88/rtw8821a.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821a.c b/drivers/net/wireless/realtek/rtw88/rtw8821a.c
index db242c9ad68f..c06ba7d615df 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8821a.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8821a.c
@@ -221,8 +221,6 @@ static void rtw8821a_iqk_tx_vdf_true(struct rtw_dev *rtwdev, u32 cal,
/* Originally: if (~tx_fail) {
* It looks like a typo, so make it more explicit.
*/
- tx_fail = false;
-
if (!tx_fail) {
rtw_write32(rtwdev, REG_RFECTL_A,
0x02000000);
--
2.34.1
next reply other threads:[~2024-11-22 12:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 12:14 Dheeraj Reddy Jonnalagadda [this message]
2024-11-22 19:10 ` [PATCH wireless-next] wifi: rtw88: Fix an unreachable code issue Bitterblue Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241122121459.134107-1-dheeraj.linuxdev@gmail.com \
--to=dheeraj.linuxdev@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox