From: Baoquan He <bhe@redhat.com>
To: mingo@kernel.org, thomas.lendacky@amd.com, bp@alien8.de,
linux-kernel@vger.kernel.org
Cc: x86@kernel.org, Baoquan He <bhe@redhat.com>
Subject: [PATCH v3 3/3] x86/mm: clean up unused parameters of functions
Date: Sat, 23 Nov 2024 19:42:21 +0800 [thread overview]
Message-ID: <20241123114221.149383-4-bhe@redhat.com> (raw)
In-Reply-To: <20241123114221.149383-1-bhe@redhat.com>
For functions memremap_is_efi_data(), memremap_is_setup_data and
early_memremap_is_setup_data(), their parameter 'size' is not used
and sometime cause confusion. Remove it now.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
arch/x86/mm/ioremap.c | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index 76be3d664e09..a11890692e4d 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -593,8 +593,7 @@ static bool memremap_should_map_decrypted(resource_size_t phys_addr,
* Examine the physical address to determine if it is EFI data. Check
* it against the boot params structure and EFI tables and memory types.
*/
-static bool memremap_is_efi_data(resource_size_t phys_addr,
- unsigned long size)
+static bool memremap_is_efi_data(resource_size_t phys_addr)
{
u64 paddr;
@@ -709,14 +708,12 @@ static bool __ref __memremap_is_setup_data(resource_size_t phys_addr,
}
#undef SD_SIZE
-static bool memremap_is_setup_data(resource_size_t phys_addr,
- unsigned long size)
+static bool memremap_is_setup_data(resource_size_t phys_addr)
{
return __memremap_is_setup_data(phys_addr, false);
}
-static bool __init early_memremap_is_setup_data(resource_size_t phys_addr,
- unsigned long size)
+static bool __init early_memremap_is_setup_data(resource_size_t phys_addr)
{
return __memremap_is_setup_data(phys_addr, true);
}
@@ -739,8 +736,8 @@ bool arch_memremap_can_ram_remap(resource_size_t phys_addr, unsigned long size,
return false;
if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)) {
- if (memremap_is_setup_data(phys_addr, size) ||
- memremap_is_efi_data(phys_addr, size))
+ if (memremap_is_setup_data(phys_addr) ||
+ memremap_is_efi_data(phys_addr))
return false;
}
@@ -765,8 +762,8 @@ pgprot_t __init early_memremap_pgprot_adjust(resource_size_t phys_addr,
encrypted_prot = true;
if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)) {
- if (early_memremap_is_setup_data(phys_addr, size) ||
- memremap_is_efi_data(phys_addr, size))
+ if (early_memremap_is_setup_data(phys_addr) ||
+ memremap_is_efi_data(phys_addr))
encrypted_prot = false;
}
--
2.41.0
next prev parent reply other threads:[~2024-11-23 11:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-23 11:42 [PATCH v3 0/3] x86/ioremap: clean up the mess in xxx_is_setup_data Baoquan He
2024-11-23 11:42 ` [PATCH v3 1/3] x86/ioremap: introduce helper to implement xxx_is_setup_data() Baoquan He
2024-12-07 16:04 ` Borislav Petkov
2024-12-09 0:52 ` Baoquan He
2024-12-08 10:39 ` [tip: x86/cleanups] x86/ioremap: Simplify setup_data mapping variants tip-bot2 for Baoquan He
2024-11-23 11:42 ` [PATCH v3 2/3] x86/ioremap: Clean up size calculations in xxx_is_setup_data() Baoquan He
2024-11-23 11:42 ` Baoquan He [this message]
2024-12-08 10:39 ` [tip: x86/cleanups] x86/ioremap: Remove unused size parameter in remapping functions tip-bot2 for Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241123114221.149383-4-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox