* [PATCH] v4l2: mc: fix endpoint iteration
@ 2024-11-22 14:55 Cosmin Tanislav
2024-11-23 21:39 ` Laurent Pinchart
2024-12-13 8:35 ` Sakari Ailus
0 siblings, 2 replies; 3+ messages in thread
From: Cosmin Tanislav @ 2024-11-22 14:55 UTC (permalink / raw)
Cc: Mauro Carvalho Chehab, Laurent Pinchart, Sakari Ailus,
Cosmin Tanislav, Hans Verkuil, Steve Longerbeam, linux-media,
linux-kernel
When creating links from a subdev to a sink, the current logic tries to
iterate over the endpoints of dev's fwnode.
This might not be correct when the subdev uses a different fwnode
compared to the dev's fwnode.
If, when registering, the subdev's fwnode is not set, the code inside
v4l2_async_register_subdev will set it to the dev's fwnode.
To fix this, just use the subdev's fwnode.
Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
Fixes: 0d3c81e82da9 ("media: v4l2-mc: add v4l2_create_fwnode_links helpers")
---
drivers/media/v4l2-core/v4l2-mc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/media/v4l2-core/v4l2-mc.c
index 4bb91359e3a9a..937d358697e19 100644
--- a/drivers/media/v4l2-core/v4l2-mc.c
+++ b/drivers/media/v4l2-core/v4l2-mc.c
@@ -329,7 +329,7 @@ int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd,
if (!(sink->flags & MEDIA_PAD_FL_SINK))
return -EINVAL;
- fwnode_graph_for_each_endpoint(dev_fwnode(src_sd->dev), endpoint) {
+ fwnode_graph_for_each_endpoint(src_sd->fwnode, endpoint) {
struct fwnode_handle *remote_ep;
int src_idx, sink_idx, ret;
struct media_pad *src;
--
2.47.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] v4l2: mc: fix endpoint iteration
2024-11-22 14:55 [PATCH] v4l2: mc: fix endpoint iteration Cosmin Tanislav
@ 2024-11-23 21:39 ` Laurent Pinchart
2024-12-13 8:35 ` Sakari Ailus
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2024-11-23 21:39 UTC (permalink / raw)
To: Cosmin Tanislav
Cc: Mauro Carvalho Chehab, Sakari Ailus, Hans Verkuil,
Steve Longerbeam, linux-media, linux-kernel
Hi Cosmin,
Thank you for the patch.
On Fri, Nov 22, 2024 at 04:55:24PM +0200, Cosmin Tanislav wrote:
> When creating links from a subdev to a sink, the current logic tries to
> iterate over the endpoints of dev's fwnode.
>
> This might not be correct when the subdev uses a different fwnode
> compared to the dev's fwnode.
>
> If, when registering, the subdev's fwnode is not set, the code inside
> v4l2_async_register_subdev will set it to the dev's fwnode.
>
> To fix this, just use the subdev's fwnode.
>
> Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
> Fixes: 0d3c81e82da9 ("media: v4l2-mc: add v4l2_create_fwnode_links helpers")
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/media/v4l2-core/v4l2-mc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/media/v4l2-core/v4l2-mc.c
> index 4bb91359e3a9a..937d358697e19 100644
> --- a/drivers/media/v4l2-core/v4l2-mc.c
> +++ b/drivers/media/v4l2-core/v4l2-mc.c
> @@ -329,7 +329,7 @@ int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd,
> if (!(sink->flags & MEDIA_PAD_FL_SINK))
> return -EINVAL;
>
> - fwnode_graph_for_each_endpoint(dev_fwnode(src_sd->dev), endpoint) {
> + fwnode_graph_for_each_endpoint(src_sd->fwnode, endpoint) {
> struct fwnode_handle *remote_ep;
> int src_idx, sink_idx, ret;
> struct media_pad *src;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] v4l2: mc: fix endpoint iteration
2024-11-22 14:55 [PATCH] v4l2: mc: fix endpoint iteration Cosmin Tanislav
2024-11-23 21:39 ` Laurent Pinchart
@ 2024-12-13 8:35 ` Sakari Ailus
1 sibling, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2024-12-13 8:35 UTC (permalink / raw)
To: Cosmin Tanislav
Cc: Mauro Carvalho Chehab, Laurent Pinchart, Hans Verkuil,
Steve Longerbeam, linux-media, linux-kernel
Hi Cosmin,
On Fri, Nov 22, 2024 at 04:55:24PM +0200, Cosmin Tanislav wrote:
> When creating links from a subdev to a sink, the current logic tries to
> iterate over the endpoints of dev's fwnode.
>
> This might not be correct when the subdev uses a different fwnode
> compared to the dev's fwnode.
>
> If, when registering, the subdev's fwnode is not set, the code inside
> v4l2_async_register_subdev will set it to the dev's fwnode.
>
> To fix this, just use the subdev's fwnode.
>
> Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
> Fixes: 0d3c81e82da9 ("media: v4l2-mc: add v4l2_create_fwnode_links helpers")
Nowadays Fixes: (almost) requires Cc: stable. I'll add that this time.
> ---
> drivers/media/v4l2-core/v4l2-mc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/media/v4l2-core/v4l2-mc.c
> index 4bb91359e3a9a..937d358697e19 100644
> --- a/drivers/media/v4l2-core/v4l2-mc.c
> +++ b/drivers/media/v4l2-core/v4l2-mc.c
> @@ -329,7 +329,7 @@ int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd,
> if (!(sink->flags & MEDIA_PAD_FL_SINK))
> return -EINVAL;
>
> - fwnode_graph_for_each_endpoint(dev_fwnode(src_sd->dev), endpoint) {
> + fwnode_graph_for_each_endpoint(src_sd->fwnode, endpoint) {
> struct fwnode_handle *remote_ep;
> int src_idx, sink_idx, ret;
> struct media_pad *src;
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-13 8:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-22 14:55 [PATCH] v4l2: mc: fix endpoint iteration Cosmin Tanislav
2024-11-23 21:39 ` Laurent Pinchart
2024-12-13 8:35 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox