From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5C571E379F; Sun, 24 Nov 2024 12:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732452441; cv=none; b=tuXG35cco9i4vMOQYUElcOGhdbKE124XPGwGsckaTIlQVHNjyjYtXY6Roqj81GV6jwUH7vLp8A9mJiMfNFH197XF+Wd7Y8dRvkjsRRo+GaDd3KqhqYFKmBkTMoPgqDXpQ6VSqkkBU8l3e28qu5ZqGxbHoPFygox++/rCbNQcogo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732452441; c=relaxed/simple; bh=NfSRL1z8JKm12VAgtd9CVbqNJGiG+dmtRuuiJAQUaVY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q1ywWrkRzwSPgBwW6cokBA7yecShr0Rg0h2eB8/nJkNE7tgWhzZAWiQWoetqnjBIUrxwvW/r5ZvUY6YMuG7Y85Ux+ylJnclCymsBaBaU1mXXuRqtz+FZjjzkxSX+58d1pF31aow+1xrTPfAeYFXsLF3aN7oqA2bkS72Pl0wzuMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MrQ7NIMa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MrQ7NIMa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 955A4C4CECC; Sun, 24 Nov 2024 12:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732452440; bh=NfSRL1z8JKm12VAgtd9CVbqNJGiG+dmtRuuiJAQUaVY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MrQ7NIMa0iCXWHmutZmH2mjmRaKtHsjNiQhCtDNDIuiYFMmxDtx6EV9SgVabbzxg2 gcOuiLGyp25OmQFylwrynIdiYFdpaLIpCHReUWDKPzFD4beOj4G19bS/Dwt1FQFYXt smlv/4VvbO6ZoCNPJ5HDghtBQdaEY3qRQapmUwXp/H1vrJmR8eFtnyKQJhAlICjA70 2nE0PmJ8aGDyA7G8RTD/lpeR2OS6f1CIWXsPico0AnR66QUi9FQ3ZiHGAZbfBNLCad R2VVsRpcot2w2WlbaMWPlOfbyFPqI8qhHYB2hDNRBAkHrYSu5DI8NkTuG47s7WMCS/ Dxxlq+IoWldQQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Breno Leitao , "Paul E . McKenney" , Peter Zijlstra , Sandipan Das , Sasha Levin , mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, tglx@linutronix.de, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, linux-perf-users@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 2/3] perf/x86/amd: Warn only on new bits set Date: Sun, 24 Nov 2024 07:47:12 -0500 Message-ID: <20241124124715.3338418-2-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124124715.3338418-1-sashal@kernel.org> References: <20241124124715.3338418-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.119 Content-Transfer-Encoding: 8bit From: Breno Leitao [ Upstream commit de20037e1b3c2f2ca97b8c12b8c7bca8abd509a7 ] Warning at every leaking bits can cause a flood of message, triggering various stall-warning mechanisms to fire, including CSD locks, which makes the machine to be unusable. Track the bits that are being leaked, and only warn when a new bit is set. That said, this patch will help with the following issues: 1) It will tell us which bits are being set, so, it is easy to communicate it back to vendor, and to do a root-cause analyzes. 2) It avoid the machine to be unusable, because, worst case scenario, the user gets less than 60 WARNs (one per unhandled bit). Suggested-by: Paul E. McKenney Signed-off-by: Breno Leitao Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Sandipan Das Reviewed-by: Paul E. McKenney Link: https://lkml.kernel.org/r/20241001141020.2620361-1-leitao@debian.org Signed-off-by: Sasha Levin --- arch/x86/events/amd/core.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c index 3ac069a4559b0..1282f1a702139 100644 --- a/arch/x86/events/amd/core.c +++ b/arch/x86/events/amd/core.c @@ -881,11 +881,12 @@ static int amd_pmu_handle_irq(struct pt_regs *regs) static int amd_pmu_v2_handle_irq(struct pt_regs *regs) { struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events); + static atomic64_t status_warned = ATOMIC64_INIT(0); + u64 reserved, status, mask, new_bits, prev_bits; struct perf_sample_data data; struct hw_perf_event *hwc; struct perf_event *event; int handled = 0, idx; - u64 reserved, status, mask; bool pmu_enabled; /* @@ -952,7 +953,12 @@ static int amd_pmu_v2_handle_irq(struct pt_regs *regs) * the corresponding PMCs are expected to be inactive according to the * active_mask */ - WARN_ON(status > 0); + if (status > 0) { + prev_bits = atomic64_fetch_or(status, &status_warned); + // A new bit was set for the very first time. + new_bits = status & ~prev_bits; + WARN(new_bits, "New overflows for inactive PMCs: %llx\n", new_bits); + } /* Clear overflow and freeze bits */ amd_pmu_ack_global_status(~status); -- 2.43.0