From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95A451F7563; Sun, 24 Nov 2024 12:52:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732452752; cv=none; b=YtwvfuV//S91QoY0bVwkuEUaBhaObrP1UbNYi2tCkZMIpCOyCvb4xYi+ypGl4KL4ALBPbONnInW22evNsd08pYPXgz4ez/E2BKkLg2bWH/D6wm6HIZJmH9l1X0MQDv+cLRRW2/qMx8qXSp94BPvihinVxGsKHFSvTduHibEYRNQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732452752; c=relaxed/simple; bh=SUm48HcYKDKR6wUc3VpZvhgjuViI2lQ8T7bFKafhnSE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a5sKgz61BKEContt/Rzp5uL84+vz2dKCHzmcW7gvxzyMmZaKpXh0TT2BB0XqpOZXALQ9A6uFsFKfm9WbgyCxuiVrpdGBYN/1azDJJzh8Xq0SkbPI2IvNnVSC5jKOzVll+C+BdgHfqh5x9zCjvbynFqEn7G+riWpc1uKxncy/l/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U4Hp1A3U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U4Hp1A3U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36BA3C4CECC; Sun, 24 Nov 2024 12:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732452752; bh=SUm48HcYKDKR6wUc3VpZvhgjuViI2lQ8T7bFKafhnSE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U4Hp1A3UJOoJSHvYNM8h8iMeGknzOWnWAMIppR8PBzZdanstmggHrOjk7sfmNt8nK a6p8XDtoKx1UrbUMXNfUC3vWSIEy0LeaZpfK65LTKPN7+0KlgvIQr3Mu7quO2hT/3Q GbCSR/SLhkPN57S7Wx+y5RY7vPfkZr1623CkP1puRyhg5cXPL00Ky7gTtUzMNaNexM irqp1omfDXQo2D/fB8YmE98Wpa1Fe8Ja5XyAxMDMXTy5GacdOPCHpjZn6hxJoS60C/ PwADr7h4VeeLmFg+4bvLYDLauPy9PIp5bVgwPiPGdNQ9gtjaH2WBDXoz13uEqgWhJB RQKoRTfT314Ug== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andy Shevchenko , Greg Kroah-Hartman , Linus Walleij , Bartosz Golaszewski , Sasha Levin , daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 6.11 19/20] USB: gadget: pxa27x_udc: Avoid using GPIOF_ACTIVE_LOW Date: Sun, 24 Nov 2024 07:50:49 -0500 Message-ID: <20241124125124.3339648-19-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124125124.3339648-1-sashal@kernel.org> References: <20241124125124.3339648-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.11.10 Content-Transfer-Encoding: 8bit From: Andy Shevchenko [ Upstream commit 62d2a940f29e6aa5a1d844a90820ca6240a99b34 ] Avoid using GPIOF_ACTIVE_LOW as it's deprecated and subject to remove. Signed-off-by: Andy Shevchenko Acked-by: Greg Kroah-Hartman Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/20241104093609.156059-6-andriy.shevchenko@linux.intel.com Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/pxa27x_udc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index 1a6317e4b2a32..ea79f85f8e0bb 100644 --- a/drivers/usb/gadget/udc/pxa27x_udc.c +++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -2355,18 +2355,19 @@ static int pxa_udc_probe(struct platform_device *pdev) struct pxa_udc *udc = &memory; int retval = 0, gpio; struct pxa2xx_udc_mach_info *mach = dev_get_platdata(&pdev->dev); - unsigned long gpio_flags; if (mach) { - gpio_flags = mach->gpio_pullup_inverted ? GPIOF_ACTIVE_LOW : 0; gpio = mach->gpio_pullup; if (gpio_is_valid(gpio)) { retval = devm_gpio_request_one(&pdev->dev, gpio, - gpio_flags, + GPIOF_OUT_INIT_LOW, "USB D+ pullup"); if (retval) return retval; udc->gpiod = gpio_to_desc(mach->gpio_pullup); + + if (mach->gpio_pullup_inverted ^ gpiod_is_active_low(udc->gpiod)) + gpiod_toggle_active_low(udc->gpiod); } udc->udc_command = mach->udc_command; } else { -- 2.43.0