From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CBFB1F9AA7; Sun, 24 Nov 2024 12:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732452861; cv=none; b=Xx4hjxHFa5k2Y5CN4T/PrVJaT97tH1F+bYiEWJb9AGh4tyMpo9ryjB64mTIdkqGdYVHeMICp8tVM5eEc+m0S93pOdpgOxqUixlmQ12QoosQuXmTxUDSpH69fI1cxAmSebkUZacIkqsm01Y3SFf474n/tgTl24J3xcvBL7dTuMLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732452861; c=relaxed/simple; bh=+iVJvc2iy6AghupPTz3ENqEhMXX0RUkQdQFWdt+V3GQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LvM48JAvisN5KeQ8fBFQHVJd96iKpKm/a2NBM5JTgezINV2CDu5GHdgSUgKq7AYEiatClW0CbUmO9xs23X0Hc3GRT/xL1LHKKP3+dMOQRCpBtjVh8wGkCi5Zsv6vFCoaeeILJ5qr7sSDg5IOz8vy0JsakhiaROGNbZQcslQwTLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rkMcjCP8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rkMcjCP8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFE3DC4CED3; Sun, 24 Nov 2024 12:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732452861; bh=+iVJvc2iy6AghupPTz3ENqEhMXX0RUkQdQFWdt+V3GQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rkMcjCP8+ngC/lEZ0T7qIFdhxmNRiqO/z5rcYfd+oZqzh6/lGFv7q21aIevF+re1h eKmW6OPFcta+aboM7/PL4BYsWG2DpGw5sXOwHUFkCIxIC11ogJxvhviruUYGUwEc3x rPgpPJ7jF9FwZq7zgTKaVfrshFagoV5qwsNfOL0hVf9lN1JCEpXnH8K1nMRvKsWNCN QFTVV8k7BIG8Xw1XWP+OnvFc+UtZXrzOx7F2ckocgcoZ+484UpImmb2Nn2n1kRSgp3 4ZVxBlrNk4MCieFHkaq7HM9kaOFCnveghNSItQvCd24Ns8CIUsvv4hGcdXhOsMBTuv 3ooE2Av7yBh9g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andy Shevchenko , Greg Kroah-Hartman , Linus Walleij , Bartosz Golaszewski , Sasha Levin , daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 6.6 15/16] USB: gadget: pxa27x_udc: Avoid using GPIOF_ACTIVE_LOW Date: Sun, 24 Nov 2024 07:52:33 -0500 Message-ID: <20241124125311.3340223-15-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124125311.3340223-1-sashal@kernel.org> References: <20241124125311.3340223-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.63 Content-Transfer-Encoding: 8bit From: Andy Shevchenko [ Upstream commit 62d2a940f29e6aa5a1d844a90820ca6240a99b34 ] Avoid using GPIOF_ACTIVE_LOW as it's deprecated and subject to remove. Signed-off-by: Andy Shevchenko Acked-by: Greg Kroah-Hartman Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/20241104093609.156059-6-andriy.shevchenko@linux.intel.com Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/pxa27x_udc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index 61424cfd2e1cb..f624b37e2e960 100644 --- a/drivers/usb/gadget/udc/pxa27x_udc.c +++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -2356,18 +2356,19 @@ static int pxa_udc_probe(struct platform_device *pdev) struct pxa_udc *udc = &memory; int retval = 0, gpio; struct pxa2xx_udc_mach_info *mach = dev_get_platdata(&pdev->dev); - unsigned long gpio_flags; if (mach) { - gpio_flags = mach->gpio_pullup_inverted ? GPIOF_ACTIVE_LOW : 0; gpio = mach->gpio_pullup; if (gpio_is_valid(gpio)) { retval = devm_gpio_request_one(&pdev->dev, gpio, - gpio_flags, + GPIOF_OUT_INIT_LOW, "USB D+ pullup"); if (retval) return retval; udc->gpiod = gpio_to_desc(mach->gpio_pullup); + + if (mach->gpio_pullup_inverted ^ gpiod_is_active_low(udc->gpiod)) + gpiod_toggle_active_low(udc->gpiod); } udc->udc_command = mach->udc_command; } else { -- 2.43.0