From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F39D21FA82F; Sun, 24 Nov 2024 12:55:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732452951; cv=none; b=hsgsyb2MNbU4K0rY1IihDJTP2H8g+p/fXLsTlhapb98fcegznv5ZF/82ll9OMnO3ND65QyMEyfPa+PrbkwLBM7KODVkMOcNtMlS3J0VaKWAxrsh1mJsSUBAlUjvzodZoLEhV2l/w7W3fcRFBLwz8bJZRzGQm6WFV/5Y1rADj8Ao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732452951; c=relaxed/simple; bh=kELF984EOeDAG++jmv0s5SBAjeHs5qsW6s/TWHFy2Pg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CAZJ1REzr39khj7FFeRNYt/WXqbveomfqwJGtpa0oP0da/wA9V45gWDxc6xsEtvCMkiSKLxHSLNwvQM79d0ovJ4gL4YS+q79D3YUeD8mvopBQ7uPSC5wBY20MHc7ySD+Cwx+nD8ZyuL3P4vWmB+xmfGphlAUf7jVXVqxHlc4I68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CanX3W0K; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CanX3W0K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E70BC4CECC; Sun, 24 Nov 2024 12:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732452950; bh=kELF984EOeDAG++jmv0s5SBAjeHs5qsW6s/TWHFy2Pg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CanX3W0KYrvAFbHDkI5z1mGqKUmTDF2lfYPLsMOMQoO+fcqTSuEGjg3K3bBUoqA8j nD/DI+NKb1y5+B63KFfWBT8UgQjCZbFNwGL/dwWrhluoiT4sXdGaUIr1rvMUg3m4La qm7/xienE8knFLPPjz07D5q/8QsU8spQY5FJhFPrqcfzaHuAox62MrIsdhxfytiWmb 9o3vh7IQSubLdeWrNCIZifZUu/GeH5coTB6hd+Hu6nJP5BkoKbafdCySQd6xFl4dYC dfo9VBDHC4+Lf1YhdOg5azAALNg3Lwb9dDsPaubqvc0ZAnmin+bECQhTKQ1oh9UTq1 TdTEuTfOghpUQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andy Shevchenko , Greg Kroah-Hartman , Linus Walleij , Bartosz Golaszewski , Sasha Levin , daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 8/9] USB: gadget: pxa27x_udc: Avoid using GPIOF_ACTIVE_LOW Date: Sun, 24 Nov 2024 07:54:22 -0500 Message-ID: <20241124125515.3340625-8-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124125515.3340625-1-sashal@kernel.org> References: <20241124125515.3340625-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.119 Content-Transfer-Encoding: 8bit From: Andy Shevchenko [ Upstream commit 62d2a940f29e6aa5a1d844a90820ca6240a99b34 ] Avoid using GPIOF_ACTIVE_LOW as it's deprecated and subject to remove. Signed-off-by: Andy Shevchenko Acked-by: Greg Kroah-Hartman Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/20241104093609.156059-6-andriy.shevchenko@linux.intel.com Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/pxa27x_udc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index 0ecdfd2ba9e9b..db29eb5aa6bf6 100644 --- a/drivers/usb/gadget/udc/pxa27x_udc.c +++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -2356,18 +2356,19 @@ static int pxa_udc_probe(struct platform_device *pdev) struct pxa_udc *udc = &memory; int retval = 0, gpio; struct pxa2xx_udc_mach_info *mach = dev_get_platdata(&pdev->dev); - unsigned long gpio_flags; if (mach) { - gpio_flags = mach->gpio_pullup_inverted ? GPIOF_ACTIVE_LOW : 0; gpio = mach->gpio_pullup; if (gpio_is_valid(gpio)) { retval = devm_gpio_request_one(&pdev->dev, gpio, - gpio_flags, + GPIOF_OUT_INIT_LOW, "USB D+ pullup"); if (retval) return retval; udc->gpiod = gpio_to_desc(mach->gpio_pullup); + + if (mach->gpio_pullup_inverted ^ gpiod_is_active_low(udc->gpiod)) + gpiod_toggle_active_low(udc->gpiod); } udc->udc_command = mach->udc_command; } else { -- 2.43.0