From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FABC1FBCB4; Sun, 24 Nov 2024 12:57:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732453028; cv=none; b=GcRiTrSuOHCVqvWZtOpu0EjLCVb1ZUGI+nQuIXxXHrGjjMObNAbbVbcPg2pK/GxcW+W3GbjSd9HWnGVocZulL0vP9FFj06Ik9apgJ5jDOQw/CVn3bLL9onQdyV5UbsegtCb26ApvB5h9DsFHNWFB0rG8587Tcvbp7FYC3kA17wE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732453028; c=relaxed/simple; bh=xdM+kv2HWu02jw89xKzwMEcH37/DzEPvCJtaXqCpG5E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CQgAIC89l8sYrCIaAhSr+F5z/UpErbt4jeon4zvVPptiaxxiyu3BVoCcX42XVNkxwA8Up5BBdmQXJ5ATb+11fUPq6FfVPmKLrU6EQTCLsH2iFAXaUy57b6BCAd/NtzwTdfRzzgsbIt8k7zQNHoBWf1rEqpXmqPeYCwh+Y3bH/wM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=B6h8vk/m; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B6h8vk/m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21931C4CECC; Sun, 24 Nov 2024 12:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732453028; bh=xdM+kv2HWu02jw89xKzwMEcH37/DzEPvCJtaXqCpG5E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B6h8vk/mHJ5Wz9uc+rV2eQSUW8Khlj47mZxP8yqioLXVjxa8if+rwRMLYpH0h8OoT VJKj7AxWfJxXaeYG1RAa6QLQNrYZvyCkzSAZqh+02y7ASbjfY3udXtkLMXvXWzEKjh Md+gSTeyosqZZDnsnPZcmWkHFWqdqJQq64WC9uhoXS/WbnKCe1ZYpJBLd1YbGv6H8Z s7ejdb+MrRByGGByBJO/LQF1nrabV4st4l9zXW3uP1V4H+xb6T7c39AwQMxq4c7DWi FKGOPGpSQYBRt/JTzgmQrQFT9xpJll19aFXfIAeBcfnwso70BqWnxFUmXOHavGgomg KhAOXKO4UROLA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andy Shevchenko , Greg Kroah-Hartman , Linus Walleij , Bartosz Golaszewski , Sasha Levin , daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 7/7] USB: gadget: pxa27x_udc: Avoid using GPIOF_ACTIVE_LOW Date: Sun, 24 Nov 2024 07:55:52 -0500 Message-ID: <20241124125636.3340867-7-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124125636.3340867-1-sashal@kernel.org> References: <20241124125636.3340867-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.173 Content-Transfer-Encoding: 8bit From: Andy Shevchenko [ Upstream commit 62d2a940f29e6aa5a1d844a90820ca6240a99b34 ] Avoid using GPIOF_ACTIVE_LOW as it's deprecated and subject to remove. Signed-off-by: Andy Shevchenko Acked-by: Greg Kroah-Hartman Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/20241104093609.156059-6-andriy.shevchenko@linux.intel.com Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/pxa27x_udc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index 282b114f382f8..ec5e903cfa675 100644 --- a/drivers/usb/gadget/udc/pxa27x_udc.c +++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -2355,18 +2355,19 @@ static int pxa_udc_probe(struct platform_device *pdev) struct pxa_udc *udc = &memory; int retval = 0, gpio; struct pxa2xx_udc_mach_info *mach = dev_get_platdata(&pdev->dev); - unsigned long gpio_flags; if (mach) { - gpio_flags = mach->gpio_pullup_inverted ? GPIOF_ACTIVE_LOW : 0; gpio = mach->gpio_pullup; if (gpio_is_valid(gpio)) { retval = devm_gpio_request_one(&pdev->dev, gpio, - gpio_flags, + GPIOF_OUT_INIT_LOW, "USB D+ pullup"); if (retval) return retval; udc->gpiod = gpio_to_desc(mach->gpio_pullup); + + if (mach->gpio_pullup_inverted ^ gpiod_is_active_low(udc->gpiod)) + gpiod_toggle_active_low(udc->gpiod); } udc->udc_command = mach->udc_command; } else { -- 2.43.0