From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 521521FBEA2; Sun, 24 Nov 2024 13:54:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456460; cv=none; b=cXd6fNV5T62nqfo+RIp1AdH+lp0hWVLJQ2LX8yIHnPBBfVJUKvDRDVkXI2f/6EhhiDVxzmGgP1qgIYgoK/CjqGaHRxWpd6luM8aRu2XHRzTmHRp8JY2I8D1scCstuu5WL/HzznfiJjp68wVgy72FudfYxMj/yiR0ICfzydQXhQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456460; c=relaxed/simple; bh=u0snkxDIwv2nxbiqT7h6JLTyhIu6adGY5Qj7vAFbXKU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VD7t+2a2H6cNloiUh8caK/Ginhn9QvPlk1wl38kOzAnoaEIIipmdoZBMqsVtTewIsMNJArJRJw0bPoIEEZKxBsE0ROw/4WK95ORZeyikDjFEkVdljYZI6kfLrCFdBSFdVB1nalZdCb4YMRwf7a4Xah0ieE9yM5WIFGd3/S6BYMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oxVY6UT3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oxVY6UT3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89549C4CED1; Sun, 24 Nov 2024 13:54:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732456459; bh=u0snkxDIwv2nxbiqT7h6JLTyhIu6adGY5Qj7vAFbXKU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oxVY6UT35FQKIw3kWx6UHhOGSwnwRtmJ7+0J7HcKUr3wn/+ZRkR63I1uLzEZLc2cE 0MtqVLZc/pHP4AjTYdXCFD41XRE3voR/ljCyR9Wl63yCDZPwUmxISedqG/q86BFt9j 6bKQA3Mv+ceCH8paiRHGftirfHiqj7YHtB11Q0YUSoU19o7mPtN44io/dhRczV4gAt ky73ugWIwOLJwG1Vfx1jjgjSYeFqk0kSL73wxpowdm2G2iIQi9d/oZbBFJIsG+i5/c PA8NOBmwBzNlHkEqxxYAPpN4/V+J2wb00snaraCfPxAt/9M5RRSof0xO8d0+i8agrc rG57Xn1e+SKRQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Heiner Kallweit , Simon Horman , Jakub Kicinski , Sasha Levin , nic_swsd@realtek.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 05/33] r8169: don't apply UDP padding quirk on RTL8126A Date: Sun, 24 Nov 2024 08:53:17 -0500 Message-ID: <20241124135410.3349976-5-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124135410.3349976-1-sashal@kernel.org> References: <20241124135410.3349976-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.230 Content-Transfer-Encoding: 8bit From: Heiner Kallweit [ Upstream commit 87e26448dbda4523b73a894d96f0f788506d3795 ] Vendor drivers r8125/r8126 indicate that this quirk isn't needed any longer for RTL8126A. Mimic this in r8169. Signed-off-by: Heiner Kallweit Reviewed-by: Simon Horman Link: https://patch.msgid.link/d1317187-aa81-4a69-b831-678436e4de62@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/realtek/r8169_main.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 3aa1dda3406cd..b60add52f4497 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -4155,8 +4155,8 @@ static unsigned int rtl8125_quirk_udp_padto(struct rtl8169_private *tp, { unsigned int padto = 0, len = skb->len; - if (rtl_is_8125(tp) && len < 128 + RTL_MIN_PATCH_LEN && - rtl_skb_is_udp(skb) && skb_transport_header_was_set(skb)) { + if (len < 128 + RTL_MIN_PATCH_LEN && rtl_skb_is_udp(skb) && + skb_transport_header_was_set(skb)) { unsigned int trans_data_len = skb_tail_pointer(skb) - skb_transport_header(skb); @@ -4180,9 +4180,15 @@ static unsigned int rtl8125_quirk_udp_padto(struct rtl8169_private *tp, static unsigned int rtl_quirk_packet_padto(struct rtl8169_private *tp, struct sk_buff *skb) { - unsigned int padto; + unsigned int padto = 0; - padto = rtl8125_quirk_udp_padto(tp, skb); + switch (tp->mac_version) { + case RTL_GIGA_MAC_VER_61 ... RTL_GIGA_MAC_VER_63: + padto = rtl8125_quirk_udp_padto(tp, skb); + break; + default: + break; + } switch (tp->mac_version) { case RTL_GIGA_MAC_VER_34: -- 2.43.0