From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B3721FDE26; Sun, 24 Nov 2024 13:56:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456573; cv=none; b=RTUX1xzsWmIK4cM03Lav/5UgRnDqxZxYCE1aJExrk8sLirnTRTByOXJl72ACDHESsS3aQUGO2JfOpwty+xbOUvdL3wjadZ7nqIVSdlpGLEBl/Qr8wCi8X5O4Zv15We8HONXlV8wBuRKVM/AQedehVPtA5Qh8+X9WelZiIV1S9QY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456573; c=relaxed/simple; bh=8qh0SkzWjEUiRey1nUl/KZ+f4kwrgU5qhkwQwNfal98=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oMmd3ICSQ1tz8meakkwiBUqujWINU27BYpzICYwooNBaR4v4GCwCSDOr8KbQO/M8FhRMkVO+Uxg3rqwKd9066mBfuo5Hpor1zlSKusLjv1DmRC0d8BStJd1lORPl0JbVEeR1RTsHASd18QYcmCcviC87yndIWuE1otkbbcIdMrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kB0gYvTx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kB0gYvTx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE211C4CECC; Sun, 24 Nov 2024 13:56:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732456573; bh=8qh0SkzWjEUiRey1nUl/KZ+f4kwrgU5qhkwQwNfal98=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kB0gYvTxJ8LfoOEL5aiibusHD2WRIokyXXMGkRxJb1r5MCkx5prcQRe6ZLQ+z6J83 WYVf7B+oTg5EECTwG2PftthDtIiAPnp9pM445lNfktEVHn35WAAtBqX5LtgheZDFIf oiryVs/4AG6IvKhBJmcnn4oRRqeFzQGRWrcXp5ahcpa4k3FRWObYdhozJfgfx+qbGw sbXxTRxWn52w/43YK06lDMkro62Z8BmKxmxenBdwdD3peimKYgnWfl3ChhUgn0Be6V T+hLZu+FgogZfrHXvor7qLHKup/q4IuJ7qa+rwVjGkjD6E/E9yrrW4HVrZtnqQJ1x/ mrcr52MypFYvw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ignat Korchagin , Kuniyuki Iwashima , Eric Dumazet , Jakub Kicinski , Sasha Levin , davem@davemloft.net, dsahern@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 12/28] net: inet: do not leave a dangling sk pointer in inet_create() Date: Sun, 24 Nov 2024 08:55:12 -0500 Message-ID: <20241124135549.3350700-12-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124135549.3350700-1-sashal@kernel.org> References: <20241124135549.3350700-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.286 Content-Transfer-Encoding: 8bit From: Ignat Korchagin [ Upstream commit 9365fa510c6f82e3aa550a09d0c5c6b44dbc78ff ] sock_init_data() attaches the allocated sk object to the provided sock object. If inet_create() fails later, the sk object is freed, but the sock object retains the dangling pointer, which may create use-after-free later. Clear the sk pointer in the sock object on error. Signed-off-by: Ignat Korchagin Reviewed-by: Kuniyuki Iwashima Reviewed-by: Eric Dumazet Link: https://patch.msgid.link/20241014153808.51894-7-ignat@cloudflare.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/ipv4/af_inet.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index be2b786cee2bd..486ab202303ff 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -369,32 +369,30 @@ static int inet_create(struct net *net, struct socket *sock, int protocol, inet->inet_sport = htons(inet->inet_num); /* Add to protocol hash chains. */ err = sk->sk_prot->hash(sk); - if (err) { - sk_common_release(sk); - goto out; - } + if (err) + goto out_sk_release; } if (sk->sk_prot->init) { err = sk->sk_prot->init(sk); - if (err) { - sk_common_release(sk); - goto out; - } + if (err) + goto out_sk_release; } if (!kern) { err = BPF_CGROUP_RUN_PROG_INET_SOCK(sk); - if (err) { - sk_common_release(sk); - goto out; - } + if (err) + goto out_sk_release; } out: return err; out_rcu_unlock: rcu_read_unlock(); goto out; +out_sk_release: + sk_common_release(sk); + sock->sk = NULL; + goto out; } -- 2.43.0