From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08BB11FF7F6; Sun, 24 Nov 2024 13:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456665; cv=none; b=S1/iUG/uNeQGDgUC/1zTzJGZGqhASSz59qmIaTzyTrBnpbgvmAczA2oLcdbNQdUPNP9aWtjUP5U5c0NPm6yH7CCf31s8DbCBpJzjs4iXPBWRVcyJHWXg6JCtfQNMxA/jZBob+wqTPMBGCuIjZmi6pogEjzh9Fd9ksILMMzDz4/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456665; c=relaxed/simple; bh=Q3NTUcQjhKJe8oHlyi1+hjuoKGBKJhWs1Qq1F51MBWE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kmx52fcCmoB6jl0p8DeGJlmpGV6jv6zcewNYrANT27hc/eB2yIw0kMoZ2FESjts/M648hQLnWbhwmNjKW5VjV1Vfz+LAZ4lfcVHfMN/EJag61VdMmJKsNCWlKd2v04Fe4RGfb/n+5CmER3wKC64Gyo/pxp0zl9TC1r6EnsoavI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dkmQyNnv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dkmQyNnv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32D6DC4CED1; Sun, 24 Nov 2024 13:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732456664; bh=Q3NTUcQjhKJe8oHlyi1+hjuoKGBKJhWs1Qq1F51MBWE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dkmQyNnvUk8Jk3MsvfSanegZW9fv2j5rBMlppkN3CKCEPNw7R1D2QduxNXhdoTmVn koMCQ+4wIefZvnaJzTaIb0JWoBGE/zH4dHdIoYsjs5dq28urVwGc8BJBJPI2kYg8o/ 9qnMJIOnHf+7f2yA4hF4eTAKbJiP5GJJm0IbfLQOwp+oCR4kVAQXjtIAoVNViEGEU8 c9KtHVoixXafOEbcYhgsJr563R9xwPVc1Di2NLBq54Ap5JkWb8ntNqUY2jiJuIVIZ4 scTGzi4kTRfOmJOD/mJXMK0FIlGUYQMlVKw9RGJt9Eb35eDjw6ju+BBnZGJ0CMVB5a XHqbIgR95RnDw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nihar Chaithanya , syzbot+412dea214d8baa3f7483@syzkaller.appspotmail.com, Dave Kleikamp , Sasha Levin , shaggy@kernel.org, rbrasga@uci.edu, ghanshyam1898@gmail.com, eadavis@qq.com, peili.dev@gmail.com, aha310510@gmail.com, jfs-discussion@lists.sourceforge.net Subject: [PATCH AUTOSEL 4.19 16/21] jfs: add a check to prevent array-index-out-of-bounds in dbAdjTree Date: Sun, 24 Nov 2024 08:56:49 -0500 Message-ID: <20241124135709.3351371-16-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124135709.3351371-1-sashal@kernel.org> References: <20241124135709.3351371-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.324 Content-Transfer-Encoding: 8bit From: Nihar Chaithanya [ Upstream commit a174706ba4dad895c40b1d2277bade16dfacdcd9 ] When the value of lp is 0 at the beginning of the for loop, it will become negative in the next assignment and we should bail out. Reported-by: syzbot+412dea214d8baa3f7483@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=412dea214d8baa3f7483 Tested-by: syzbot+412dea214d8baa3f7483@syzkaller.appspotmail.com Signed-off-by: Nihar Chaithanya Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/jfs_dmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c index 7bb2d0212c90a..7e1cc0e21eff2 100644 --- a/fs/jfs/jfs_dmap.c +++ b/fs/jfs/jfs_dmap.c @@ -2966,6 +2966,9 @@ static void dbAdjTree(dmtree_t *tp, int leafno, int newval, bool is_ctl) /* bubble the new value up the tree as required. */ for (k = 0; k < le32_to_cpu(tp->dmt_height); k++) { + if (lp == 0) + break; + /* get the index of the first leaf of the 4 leaf * group containing the specified leaf (leafno). */ -- 2.43.0