[PATCH v2 07/29] firmware: avoid pointless reference count bump

Christian Brauner
2024-11-25T14:10:37Z

The creds are allocated via prepare_kernel_cred() which has already
taken a reference.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
drivers/base/firmware_loader/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
index 96a2c3011ca82148b4ba547764a1f92e252dbf5f..324a9a3c087aa2e2c4e0b53b30a2f11f61195aa3 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -912,7 +912,7 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
ret = -ENOMEM;
goto out;
}
- old_cred = override_creds(get_new_cred(kern_cred));
+ old_cred = override_creds(kern_cred);

ret = fw_get_filesystem_firmware(device, fw->priv, "", NULL);

@@ -944,7 +944,7 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
} else
ret = assign_fw(fw, device);

- put_cred(revert_creds(old_cred));
+ revert_creds(old_cred);
put_cred(kern_cred);

out:

--
2.45.2