[PATCH v2 19/29] cifs: avoid pointless cred reference count bump

Christian Brauner
2024-11-25T14:11:04Z

During module init spnego_cred will be allocated with its own reference
which is only destroyed during module exit.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
fs/smb/client/cifs_spnego.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/smb/client/cifs_spnego.c b/fs/smb/client/cifs_spnego.c
index 3f3a662c76fa43c1e843310cc814427bcfd0e821..af7849e5974ff36619405a12e667e7543bb3926f 100644
--- a/fs/smb/client/cifs_spnego.c
+++ b/fs/smb/client/cifs_spnego.c
@@ -157,9 +157,9 @@ cifs_get_spnego_key(struct cifs_ses *sesInfo,
sprintf(dp, ";pid=0x%x", current->pid);

cifs_dbg(FYI, "key description = %s\n", description);
- saved_cred = override_creds(get_new_cred(spnego_cred));
+ saved_cred = override_creds(spnego_cred);
spnego_key = request_key(&cifs_spnego_key_type, description, "");
- put_cred(revert_creds(saved_cred));
+ revert_creds(saved_cred);

#ifdef CONFIG_CIFS_DEBUG2
if (cifsFYI && !IS_ERR(spnego_key)) {

--
2.45.2