From: kernel test robot <lkp@intel.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Wolfram Sang <wsa-dev@sang-engineering.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org,
Cosmin Tanislav <demonsingur@gmail.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Subject: Re: [PATCH 2/3] i2c: atr: Fix lockdep for nested ATRs
Date: Mon, 25 Nov 2024 20:13:20 +0800 [thread overview]
Message-ID: <202411252015.N7sBYvri-lkp@intel.com> (raw)
In-Reply-To: <20241122-i2c-atr-fixes-v1-2-62c51ce790be@ideasonboard.com>
Hi Tomi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on adc218676eef25575469234709c2d87185ca223a]
url: https://github.com/intel-lab-lkp/linux/commits/Tomi-Valkeinen/i2c-atr-Allow-unmapped-addresses-from-nested-ATRs/20241125-104419
base: adc218676eef25575469234709c2d87185ca223a
patch link: https://lore.kernel.org/r/20241122-i2c-atr-fixes-v1-2-62c51ce790be%40ideasonboard.com
patch subject: [PATCH 2/3] i2c: atr: Fix lockdep for nested ATRs
config: i386-buildonly-randconfig-001-20241125 (https://download.01.org/0day-ci/archive/20241125/202411252015.N7sBYvri-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241125/202411252015.N7sBYvri-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411252015.N7sBYvri-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/i2c/i2c-atr.c:60: warning: Function parameter or struct member 'orig_addrs_lock_key' not described in 'i2c_atr_chan'
>> drivers/i2c/i2c-atr.c:100: warning: Function parameter or struct member 'lock_key' not described in 'i2c_atr'
vim +60 drivers/i2c/i2c-atr.c
a076a860acae77 Luca Ceresoli 2023-06-19 36
a076a860acae77 Luca Ceresoli 2023-06-19 37 /**
a076a860acae77 Luca Ceresoli 2023-06-19 38 * struct i2c_atr_chan - Data for a channel.
a076a860acae77 Luca Ceresoli 2023-06-19 39 * @adap: The &struct i2c_adapter for the channel
a076a860acae77 Luca Ceresoli 2023-06-19 40 * @atr: The parent I2C ATR
a076a860acae77 Luca Ceresoli 2023-06-19 41 * @chan_id: The ID of this channel
a076a860acae77 Luca Ceresoli 2023-06-19 42 * @alias_list: List of @struct i2c_atr_alias_pair containing the
a076a860acae77 Luca Ceresoli 2023-06-19 43 * assigned aliases
a076a860acae77 Luca Ceresoli 2023-06-19 44 * @orig_addrs_lock: Mutex protecting @orig_addrs
a076a860acae77 Luca Ceresoli 2023-06-19 45 * @orig_addrs: Buffer used to store the original addresses during transmit
a076a860acae77 Luca Ceresoli 2023-06-19 46 * @orig_addrs_size: Size of @orig_addrs
a076a860acae77 Luca Ceresoli 2023-06-19 47 */
a076a860acae77 Luca Ceresoli 2023-06-19 48 struct i2c_atr_chan {
a076a860acae77 Luca Ceresoli 2023-06-19 49 struct i2c_adapter adap;
a076a860acae77 Luca Ceresoli 2023-06-19 50 struct i2c_atr *atr;
a076a860acae77 Luca Ceresoli 2023-06-19 51 u32 chan_id;
a076a860acae77 Luca Ceresoli 2023-06-19 52
a076a860acae77 Luca Ceresoli 2023-06-19 53 struct list_head alias_list;
a076a860acae77 Luca Ceresoli 2023-06-19 54
a076a860acae77 Luca Ceresoli 2023-06-19 55 /* Lock orig_addrs during xfer */
a076a860acae77 Luca Ceresoli 2023-06-19 56 struct mutex orig_addrs_lock;
f2d3b6b436282b Tomi Valkeinen 2024-11-22 57 struct lock_class_key orig_addrs_lock_key;
a076a860acae77 Luca Ceresoli 2023-06-19 58 u16 *orig_addrs;
a076a860acae77 Luca Ceresoli 2023-06-19 59 unsigned int orig_addrs_size;
a076a860acae77 Luca Ceresoli 2023-06-19 @60 };
a076a860acae77 Luca Ceresoli 2023-06-19 61
a076a860acae77 Luca Ceresoli 2023-06-19 62 /**
a076a860acae77 Luca Ceresoli 2023-06-19 63 * struct i2c_atr - The I2C ATR instance
a076a860acae77 Luca Ceresoli 2023-06-19 64 * @parent: The parent &struct i2c_adapter
a076a860acae77 Luca Ceresoli 2023-06-19 65 * @dev: The device that owns the I2C ATR instance
a076a860acae77 Luca Ceresoli 2023-06-19 66 * @ops: &struct i2c_atr_ops
a076a860acae77 Luca Ceresoli 2023-06-19 67 * @priv: Private driver data, set with i2c_atr_set_driver_data()
a076a860acae77 Luca Ceresoli 2023-06-19 68 * @algo: The &struct i2c_algorithm for adapters
a076a860acae77 Luca Ceresoli 2023-06-19 69 * @lock: Lock for the I2C bus segment (see &struct i2c_lock_operations)
a076a860acae77 Luca Ceresoli 2023-06-19 70 * @max_adapters: Maximum number of adapters this I2C ATR can have
a076a860acae77 Luca Ceresoli 2023-06-19 71 * @num_aliases: Number of aliases in the aliases array
a076a860acae77 Luca Ceresoli 2023-06-19 72 * @aliases: The aliases array
a076a860acae77 Luca Ceresoli 2023-06-19 73 * @alias_mask_lock: Lock protecting alias_use_mask
a076a860acae77 Luca Ceresoli 2023-06-19 74 * @alias_use_mask: Bitmask for used aliases in aliases array
a076a860acae77 Luca Ceresoli 2023-06-19 75 * @i2c_nb: Notifier for remote client add & del events
a076a860acae77 Luca Ceresoli 2023-06-19 76 * @adapter: Array of adapters
a076a860acae77 Luca Ceresoli 2023-06-19 77 */
a076a860acae77 Luca Ceresoli 2023-06-19 78 struct i2c_atr {
a076a860acae77 Luca Ceresoli 2023-06-19 79 struct i2c_adapter *parent;
a076a860acae77 Luca Ceresoli 2023-06-19 80 struct device *dev;
a076a860acae77 Luca Ceresoli 2023-06-19 81 const struct i2c_atr_ops *ops;
a076a860acae77 Luca Ceresoli 2023-06-19 82
a076a860acae77 Luca Ceresoli 2023-06-19 83 void *priv;
a076a860acae77 Luca Ceresoli 2023-06-19 84
a076a860acae77 Luca Ceresoli 2023-06-19 85 struct i2c_algorithm algo;
a076a860acae77 Luca Ceresoli 2023-06-19 86 /* lock for the I2C bus segment (see struct i2c_lock_operations) */
a076a860acae77 Luca Ceresoli 2023-06-19 87 struct mutex lock;
f2d3b6b436282b Tomi Valkeinen 2024-11-22 88 struct lock_class_key lock_key;
a076a860acae77 Luca Ceresoli 2023-06-19 89 int max_adapters;
a076a860acae77 Luca Ceresoli 2023-06-19 90
a076a860acae77 Luca Ceresoli 2023-06-19 91 size_t num_aliases;
a076a860acae77 Luca Ceresoli 2023-06-19 92 const u16 *aliases;
a076a860acae77 Luca Ceresoli 2023-06-19 93 /* Protects alias_use_mask */
a076a860acae77 Luca Ceresoli 2023-06-19 94 spinlock_t alias_mask_lock;
a076a860acae77 Luca Ceresoli 2023-06-19 95 unsigned long *alias_use_mask;
a076a860acae77 Luca Ceresoli 2023-06-19 96
a076a860acae77 Luca Ceresoli 2023-06-19 97 struct notifier_block i2c_nb;
a076a860acae77 Luca Ceresoli 2023-06-19 98
3a133a4e44554b Kees Cook 2023-09-22 99 struct i2c_adapter *adapter[] __counted_by(max_adapters);
a076a860acae77 Luca Ceresoli 2023-06-19 @100 };
a076a860acae77 Luca Ceresoli 2023-06-19 101
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-11-25 12:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 7:51 [PATCH 0/3] i2c: atr: A few i2c-atr fixes Tomi Valkeinen
2024-11-22 7:51 ` [PATCH 1/3] i2c: atr: Allow unmapped addresses from nested ATRs Tomi Valkeinen
2024-11-22 7:51 ` [PATCH 2/3] i2c: atr: Fix lockdep for " Tomi Valkeinen
2024-11-22 9:24 ` Andy Shevchenko
2024-11-25 12:13 ` kernel test robot [this message]
2024-11-22 7:51 ` [PATCH 3/3] i2c: atr: Fix client detach Tomi Valkeinen
2024-11-22 9:25 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411252015.N7sBYvri-lkp@intel.com \
--to=lkp@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=demonsingur@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mchehab@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox