Re: [PATCH 1/2] padata: add pd get/put refcnt helper

kernel test robot
2024-11-26T11:04:24Z

Hi Chen,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.12 next-20241126]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Chen-Ridong/padata-add-pd-get-put-refcnt-helper/20241125-111043
base: linus/master
patch link: https://lore.kernel.org/r/20241123080509.2573987-2-chenridong%40huaweicloud.com
patch subject: [PATCH 1/2] padata: add pd get/put refcnt helper
config: x86_64-randconfig-122-20241125 (https://download.01.org/0day-ci/archive/20241126/202411261818.iINyAe83-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241126/202411261818.iINyAe83-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411261818.iINyAe83-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> kernel/padata.c:1142:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct parallel_data *pd @@ got struct parallel_data [noderef] __rcu *pd @@
kernel/padata.c:1142:25: sparse: expected struct parallel_data *pd
kernel/padata.c:1142:25: sparse: got struct parallel_data [noderef] __rcu *pd
kernel/padata.c: note: in included file (through include/linux/swait.h, include/linux/completion.h):
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true

vim +1142 kernel/padata.c

1126
1127 /**
1128 * padata_free_shell - free a padata shell
1129 *
1130 * @ps: padata shell to free
1131 */
1132 void padata_free_shell(struct padata_shell *ps)
1133 {
1134 struct parallel_data *pd;
1135
1136 if (!ps)
1137 return;
1138
1139 mutex_lock(&ps->pinst->lock);
1140 list_del(&ps->list);
1141 pd = rcu_dereference_protected(ps->pd, 1);
> 1142 padata_put_pd(ps->pd);
1143 mutex_unlock(&ps->pinst->lock);
1144
1145 kfree(ps);
1146 }
1147 EXPORT_SYMBOL(padata_free_shell);
1148

--
0-DAY CI Kernel Test Service