Re: [PATCH 1/2] padata: add pd get/put refcnt helper

kernel test robot
2024-11-25T13:18:04Z

Hi Chen,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.12 next-20241125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Chen-Ridong/padata-add-pd-get-put-refcnt-helper/20241125-111043
base: linus/master
patch link: https://lore.kernel.org/r/20241123080509.2573987-2-chenridong%40huaweicloud.com
patch subject: [PATCH 1/2] padata: add pd get/put refcnt helper
config: x86_64-randconfig-161-20241125 (https://download.01.org/0day-ci/archive/20241125/202411252108.XGoGQSTI-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241125/202411252108.XGoGQSTI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411252108.XGoGQSTI-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/padata.c:1134:24: warning: variable 'pd' set but not used [-Wunused-but-set-variable]
1134 | struct parallel_data *pd;
| ^
1 warning generated.

vim +/pd +1134 kernel/padata.c

bbefa1dd6a6d53 Herbert Xu 2019-11-26 1126
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1127 /**
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1128 * padata_free_shell - free a padata shell
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1129 *
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1130 * @ps: padata shell to free
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1131 */
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1132 void padata_free_shell(struct padata_shell *ps)
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1133 {
7ddc21e317b360 WangJinchao 2023-10-16 @1134 struct parallel_data *pd;
7ddc21e317b360 WangJinchao 2023-10-16 1135
07b24c7c08bdc2 Eric Biggers 2020-02-25 1136 if (!ps)
07b24c7c08bdc2 Eric Biggers 2020-02-25 1137 return;
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1138
07b24c7c08bdc2 Eric Biggers 2020-02-25 1139 mutex_lock(&ps->pinst->lock);
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1140 list_del(&ps->list);
7ddc21e317b360 WangJinchao 2023-10-16 1141 pd = rcu_dereference_protected(ps->pd, 1);
31df8a12c672a5 Chen Ridong 2024-11-23 1142 padata_put_pd(ps->pd);
07b24c7c08bdc2 Eric Biggers 2020-02-25 1143 mutex_unlock(&ps->pinst->lock);
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1144
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1145 kfree(ps);
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1146 }
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1147 EXPORT_SYMBOL(padata_free_shell);
bbefa1dd6a6d53 Herbert Xu 2019-11-26 1148

--
0-DAY CI Kernel Test Service