Re: [PATCH 1/2] padata: add pd get/put refcnt helper

chenridong
2024-12-06T02:13:50Z

On 2024/12/6 7:03, Daniel Jordan wrote:
> On Sat, Nov 23, 2024 at 08:05:08AM +0000, Chen Ridong wrote:
>> From: Chen Ridong <chenridong@huawei.com>
>>
>> Add helpers for pd to get/put refcnt to make code consice.
>
> Seems reasonable.
>
>> +static inline void padata_put_pd(struct parallel_data *pd)
>> +{
>> + if (refcount_dec_and_test(&pd->refcnt))
>> + padata_free_pd(pd);
>> +}
>> +
>> +static inline void padata_put_pd_cnt(struct parallel_data *pd, int cnt)
>> +{
>> + if (refcount_sub_and_test(cnt, &pd->refcnt))
>> + padata_free_pd(pd);
>> +}
>
> padata_put_pd could be defined as padata_put_pd_cnt(pd, 1).
>

Thank you, will update.

Best regards,
Ridong