* Re: CVE-2024-50228: mm: shmem: fix data-race in shmem_getattr()
[not found] <2024110928-CVE-2024-50228-7a2a@gregkh>
@ 2024-11-25 7:49 ` Nanyong Sun
2024-11-25 21:16 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Nanyong Sun @ 2024-11-25 7:49 UTC (permalink / raw)
To: gregkh; +Cc: cve, linux-cve-announce, linux-kernel, aha310510, Hugh Dickins
Hi Greg,
Will this CVE be rejected in the future? This patch has introduced a
problem and has been reverted:
https://lore.kernel.org/all/20241116233053.F1FBAC4CEC3@smtp.kernel.org/T/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: CVE-2024-50228: mm: shmem: fix data-race in shmem_getattr()
2024-11-25 7:49 ` CVE-2024-50228: mm: shmem: fix data-race in shmem_getattr() Nanyong Sun
@ 2024-11-25 21:16 ` Greg KH
2024-11-25 21:29 ` Al Viro
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2024-11-25 21:16 UTC (permalink / raw)
To: Nanyong Sun
Cc: cve, linux-cve-announce, linux-kernel, aha310510, Hugh Dickins
On Mon, Nov 25, 2024 at 03:49:44PM +0800, Nanyong Sun wrote:
> Hi Greg,
> Will this CVE be rejected in the future? This patch has introduced a
> problem and has been reverted:
> https://lore.kernel.org/all/20241116233053.F1FBAC4CEC3@smtp.kernel.org/T/
>
What is the git commit id of this change? Is it in Linus's tree yet?
And did the original syzbot splat get fixed some other way?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: CVE-2024-50228: mm: shmem: fix data-race in shmem_getattr()
2024-11-25 21:16 ` Greg KH
@ 2024-11-25 21:29 ` Al Viro
2024-11-28 16:52 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Al Viro @ 2024-11-25 21:29 UTC (permalink / raw)
To: Greg KH
Cc: Nanyong Sun, cve, linux-cve-announce, linux-kernel, aha310510,
Hugh Dickins
On Mon, Nov 25, 2024 at 10:16:37PM +0100, Greg KH wrote:
> On Mon, Nov 25, 2024 at 03:49:44PM +0800, Nanyong Sun wrote:
> > Hi Greg,
> > Will this CVE be rejected in the future? This patch has introduced a
> > problem and has been reverted:
> > https://lore.kernel.org/all/20241116233053.F1FBAC4CEC3@smtp.kernel.org/T/
> >
>
> What is the git commit id of this change? Is it in Linus's tree yet?
> And did the original syzbot splat get fixed some other way?
Revert in mainline is d1aa0c04294e29883d65eac6c2f72fe95cc7c049; patch
had really been pointless and we'd better watch out for its analogues
being introduced.
IMO "fixes a data-race" in patch description has become a serious red flag
for review by now. Some of them are valid, some are pointless and occasionally
actively harmful.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: CVE-2024-50228: mm: shmem: fix data-race in shmem_getattr()
2024-11-25 21:29 ` Al Viro
@ 2024-11-28 16:52 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2024-11-28 16:52 UTC (permalink / raw)
To: Al Viro
Cc: Nanyong Sun, cve, linux-cve-announce, linux-kernel, aha310510,
Hugh Dickins
On Mon, Nov 25, 2024 at 09:29:46PM +0000, Al Viro wrote:
> On Mon, Nov 25, 2024 at 10:16:37PM +0100, Greg KH wrote:
> > On Mon, Nov 25, 2024 at 03:49:44PM +0800, Nanyong Sun wrote:
> > > Hi Greg,
> > > Will this CVE be rejected in the future? This patch has introduced a
> > > problem and has been reverted:
> > > https://lore.kernel.org/all/20241116233053.F1FBAC4CEC3@smtp.kernel.org/T/
> > >
> >
> > What is the git commit id of this change? Is it in Linus's tree yet?
> > And did the original syzbot splat get fixed some other way?
>
> Revert in mainline is d1aa0c04294e29883d65eac6c2f72fe95cc7c049; patch
> had really been pointless and we'd better watch out for its analogues
> being introduced.
>
> IMO "fixes a data-race" in patch description has become a serious red flag
> for review by now. Some of them are valid, some are pointless and occasionally
> actively harmful.
>
Fair enough, now rejected, thanks for the review!
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-28 16:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <2024110928-CVE-2024-50228-7a2a@gregkh>
2024-11-25 7:49 ` CVE-2024-50228: mm: shmem: fix data-race in shmem_getattr() Nanyong Sun
2024-11-25 21:16 ` Greg KH
2024-11-25 21:29 ` Al Viro
2024-11-28 16:52 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox