From: Conor Dooley <conor@kernel.org>
To: E Shattow <e@freeshell.de>
Cc: Jisheng Zhang <jszhang@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/1] riscv: dts: starfive: jh7110-milkv-mars: enable usb0 host function
Date: Tue, 26 Nov 2024 17:55:55 +0000 [thread overview]
Message-ID: <20241126-overlying-estranged-97adaac4d1aa@spud> (raw)
In-Reply-To: <20241126075740.17419-2-e@freeshell.de>
[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]
Emil,
On Mon, Nov 25, 2024 at 11:57:25PM -0800, E Shattow wrote:
> Milk-V Mars set JH7110 on-chip USB host mode and vbus pin assignment
>
> Signed-off-by: E Shattow <e@freeshell.de>
Could you look at this please?
Thanks,
Conor.
> ---
> .../boot/dts/starfive/jh7110-milkv-mars.dts | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts b/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts
> index 0d248b671d4b..3bd62ab78523 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts
> +++ b/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts
> @@ -53,7 +53,23 @@ &spi0 {
> status = "okay";
> };
>
> +&sysgpio {
> + usb0_pins: usb0-0 {
> + vbus-pins {
> + pinmux = <GPIOMUX(25, GPOUT_SYS_USB_DRIVE_VBUS,
> + GPOEN_ENABLE,
> + GPI_NONE)>;
> + bias-disable;
> + input-disable;
> + input-schmitt-disable;
> + slew-rate = <0>;
> + };
> + };
> +};
> +
> &usb0 {
> - dr_mode = "peripheral";
> + dr_mode = "host";
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb0_pins>;
> status = "okay";
> };
> --
> 2.45.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-11-26 17:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 7:57 [PATCH v5 0/1] riscv: dts: starfive: jh7110-milkv-mars: enable usb0 host function E Shattow
2024-11-26 7:57 ` [PATCH v5 1/1] " E Shattow
2024-11-26 17:55 ` Conor Dooley [this message]
2024-11-27 11:00 ` [PATCH v5 0/1] " Emil Renner Berthing
2024-11-27 11:52 ` E Shattow
2024-11-27 13:16 ` Emil Renner Berthing
2024-11-28 1:31 ` Minda Chen
2024-11-28 8:01 ` E Shattow
2024-11-30 7:09 ` Minda Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241126-overlying-estranged-97adaac4d1aa@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=e@freeshell.de \
--cc=jszhang@kernel.org \
--cc=kernel@esmil.dk \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox