Re: [PATCH v7 4/5] media: platform: mediatek: isp: add mediatek ISP3.0 camsv

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Tue, Nov 26, 2024 at 02:07:35AM +0000, CK Hu (胡俊光) wrote:
> On Thu, 2024-11-21 at 09:53 +0100, Julien Stephan wrote:
> >
> > From: Phi-bang Nguyen <pnguyen@baylibre.com>
> >
> > This driver provides a path to bypass the SoC ISP so that image data
> > coming from the SENINF can go directly into memory without any image
> > processing. This allows the use of an external ISP.
> >
> > Signed-off-by: Phi-bang Nguyen <pnguyen@baylibre.com>
> > Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com>
> > [Paul Elder fix irq locking]
> > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> > Co-developed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Co-developed-by: Julien Stephan <jstephan@baylibre.com>
> > Signed-off-by: Julien Stephan <jstephan@baylibre.com>
> > ---
> 
> [snip]
> 
> > +static const u32 mtk_cam_mbus_formats[] = {
> > +       MEDIA_BUS_FMT_SBGGR8_1X8,
> > +       MEDIA_BUS_FMT_SGBRG8_1X8,
> > +       MEDIA_BUS_FMT_SGRBG8_1X8,
> > +       MEDIA_BUS_FMT_SRGGB8_1X8,
> > +       MEDIA_BUS_FMT_SBGGR10_1X10,
> > +       MEDIA_BUS_FMT_SGBRG10_1X10,
> > +       MEDIA_BUS_FMT_SGRBG10_1X10,
> > +       MEDIA_BUS_FMT_SRGGB10_1X10,
> > +       MEDIA_BUS_FMT_SBGGR12_1X12,
> > +       MEDIA_BUS_FMT_SGBRG12_1X12,
> > +       MEDIA_BUS_FMT_SGRBG12_1X12,
> > +       MEDIA_BUS_FMT_SRGGB12_1X12,
> > +       MEDIA_BUS_FMT_UYVY8_1X16,
> > +       MEDIA_BUS_FMT_VYUY8_1X16,
> > +       MEDIA_BUS_FMT_YUYV8_1X16,
> > +       MEDIA_BUS_FMT_YVYU8_1X16,
> > +};
> > +
> 
> Format in mtk_cam_mbus_formats[] is more than mtk_cam_format_info[].
> I would like these two to be consistent.
> Reduce mtk_cam_mbus_formats[] or enlarge mtk_cam_format_info[].
> Once these two are consistent, they could be merged into one array.

And the array could then be extended with fields to replace the
fmt_to_sparams() function.

> > +static const struct mtk_cam_format_info mtk_cam_format_info[] = {
> > +       {
> > +               .fourcc = V4L2_PIX_FMT_SBGGR8,
> > +               .code = MEDIA_BUS_FMT_SBGGR8_1X8,
> > +               .bpp = 8,
> > +       }, {
> > +               .fourcc = V4L2_PIX_FMT_SGBRG8,
> > +               .code = MEDIA_BUS_FMT_SGBRG8_1X8,
> > +               .bpp = 8,
> > +       }, {
> > +               .fourcc = V4L2_PIX_FMT_SGRBG8,
> > +               .code = MEDIA_BUS_FMT_SGRBG8_1X8,
> > +               .bpp = 8,
> > +       }, {
> > +               .fourcc = V4L2_PIX_FMT_SRGGB8,
> > +               .code = MEDIA_BUS_FMT_SRGGB8_1X8,
> > +               .bpp = 8,
> > +       }, {
> > +               .fourcc = V4L2_PIX_FMT_YUYV,
> > +               .code = MEDIA_BUS_FMT_YUYV8_1X16,
> > +               .bpp = 16,
> > +       }, {
> > +               .fourcc = V4L2_PIX_FMT_YVYU,
> > +               .code = MEDIA_BUS_FMT_YVYU8_1X16,
> > +               .bpp = 16,
> > +       }, {
> > +               .fourcc = V4L2_PIX_FMT_UYVY,
> > +               .code = MEDIA_BUS_FMT_UYVY8_1X16,
> > +               .bpp = 16,
> > +       }, {
> > +               .fourcc = V4L2_PIX_FMT_VYUY,
> > +               .code = MEDIA_BUS_FMT_VYUY8_1X16,
> > +               .bpp = 16,
> > +       },
> > +};
> > +

-- 
Regards,

Laurent Pinchart