From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: oe-kbuild@lists.linux.dev,
Selvin Xavier <selvin.xavier@broadcom.com>,
lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org,
Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>
Subject: Re: drivers/infiniband/hw/bnxt_re/qplib_fp.c:1090 bnxt_qplib_create_qp() error: we previously assumed 'res->dattr' could be null (see line 985)
Date: Tue, 26 Nov 2024 15:01:21 +0200 [thread overview]
Message-ID: <20241126130121.GO160612@unreal> (raw)
In-Reply-To: <da54caf2-26af-420e-bfd5-106881ce6b27@stanley.mountain>
On Sat, Nov 23, 2024 at 01:14:25PM +0300, Dan Carpenter wrote:
> [ I reported this last year and generally I try to report only report these
> warnings one time, but it still feels like perhaps a bug. Mostly likely with
> these the NULL check can be removed. But smatch still warns about it even
> with cross function analysis.
> https://lore.kernel.org/all/c2ff81f3-5de6-4498-b157-909d89e74fcb@stanley.mountain/
> -dan ]
<...>
> 07f830ae4913d0 Selvin Xavier 2023-12-07 @985 if (res->dattr)
> ^^^^^^^^^^
> The new code assumes this can be NULL
Yes, this if can be removed. res->dattr != NULL in all places.
Thanks
next prev parent reply other threads:[~2024-11-26 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-23 10:14 drivers/infiniband/hw/bnxt_re/qplib_fp.c:1090 bnxt_qplib_create_qp() error: we previously assumed 'res->dattr' could be null (see line 985) Dan Carpenter
2024-11-26 13:01 ` Leon Romanovsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-11-30 9:26 Dan Carpenter
2024-11-30 9:51 ` Dan Carpenter
2024-10-21 7:42 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241126130121.GO160612@unreal \
--to=leon@kernel.org \
--cc=damodharam.ammepalli@broadcom.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox